Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 15:04:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kushal Kothari <kushalkothari285@gmail.com>
Cc:     gregkh@linuxfoundation.org, kush19992810@gmail.com,
        outreachy-kernel@googlegroups.com, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, fmdefrancesco@gmail.com,
        marcocesati@gmail.com, straube.linux@gmail.com,
        philippesdixon@gmail.com, manuelpalenzuelamerino@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        mike.rapoport@gmail.com, kushalkotharitest@googlegroups.com
Subject: Re: [PATCH v4 3/4] staging: rtl8723bs: core: Remove unnecessary
 space after a cast
Message-ID: <20211103120448.GS2794@kadam>
References: <cover.1634967010.git.kushalkothari285@gmail.com>
 <baa1703e0c202dfb90e215b63b535161bd3ccccb.1634967010.git.kushalkothari285@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <baa1703e0c202dfb90e215b63b535161bd3ccccb.1634967010.git.kushalkothari285@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6Xnebj7bk9qDzZRYokQO25J+aDGEJ4XpizPf1f8hWviN42/OIFLxX0yAXG8P?=
 =?us-ascii?Q?zqo5VGowEHdfV5zRaxfmsqTol0uyr1sWU6jPbvucXnAaXpqTQWCgNt1TwXSm?=
 =?us-ascii?Q?mgnqpt5hWV++E83YNkC0bttuBm2MmBFFLFzXmLZZerfn98cxZdYusR647VGL?=
 =?us-ascii?Q?ZoA9+/okgVW6nKn0E+wEswAwdxOQjs1ZDobvjxRrbSQjbAqcjVH/OB7bUNUq?=
 =?us-ascii?Q?nRuuDFBxzKJcafR54JYMtVkeXbm8SGYAmyqrPgkRFE1ry+8ohBE+BCHo79Es?=
 =?us-ascii?Q?t2zc5XHwayZs9DZCP1+kPFVPoqsgOkEWFDtVti83Nn1TexstsmIm1hWRam2m?=
 =?us-ascii?Q?xQipgfdK7XcjqBWhPvz5S2Wb+KyL21RbNYDHCrfyoX+LfKuo68fckqhS0N47?=
 =?us-ascii?Q?qG65jvhwf/+1KEh3Ut/LcMIQqiFIIxDo5iKAKIicYkEcKMrynJIChMegoGiI?=
 =?us-ascii?Q?6h/UmSKoLca4ZITW17x/7rGJ1tZ/k1cr35GBgwoMHGlFeU6LWXzwphkjiqfL?=
 =?us-ascii?Q?tq3Mf9yctEJ8IJ+qGvNmKY7QuTI4VziecE67Qy1G5vH/9gbhw35njRX7I8mr?=
 =?us-ascii?Q?/Yho70/6cWWOqfpxcWbqIRXGTbDDkpoRVDAQvpnb0WMh5gfwKKd1riC5jssK?=
 =?us-ascii?Q?28+FUSlDoMdpZAI2t1bJrMsCP2tcuSt/qdnj1e8d+XJUO7c1Pk4EUmHXmqBl?=
 =?us-ascii?Q?tAbVUKquximKnf6/WVrza9IDSoq02wX7gihJ3p8Wuad1YP5lgql3mWexDqlo?=
 =?us-ascii?Q?yRnafFsp+sKf/r2YoHmtkZA2OiE5/bjKhqlEzsaTlY/pFY4hMlXVWlfdicWF?=
 =?us-ascii?Q?Q2pv1RoiMTfCM5/YZYPvnK4piWkBVPKbLlVUXn5VY3fOfQnlSqePHNOxQO6Y?=
 =?us-ascii?Q?3N/qzxTPtnCeM6++ad0kxt1pVa735JCWbFBjrmbYsCkAIxxjlmA/t5pj5RFy?=
 =?us-ascii?Q?RRwrnCSfMFacSFW7MpRxUa5LskSQm1hfimIkOHaG7k77OXfrqDvYtLOeqUhK?=
 =?us-ascii?Q?dKL9SG7H6kCgIZvO0Z4DGI5glRXEwwGrh7juVcAhvMvd7V5iVKa4JCbRxyZx?=
 =?us-ascii?Q?PGvYgpanrZvfcnEMcZVb2S2KOeEvKDp55k4CaYcudJ+m5M/o8GFrQwakTZzp?=
 =?us-ascii?Q?4aEvs4YfwT+L/6GcdiLxnd9s09GaoU08/rhGV7VRCm+oetSw4SW+kGpfRT2R?=
 =?us-ascii?Q?NyO2eTjSTQ6lizImsanM09Uktt0GyVJzeP4CHc2mhIGeiVj3WiwM5MVzikLO?=
 =?us-ascii?Q?Tpjw/BqdomDLI5liqnMSwybIiXqUlUSsDMLfy9Scm5lnjIhsbYh1hQiEc9P6?=
 =?us-ascii?Q?iEBT0HlV8oCPo7bbyCFkmzRhuuLeglugKFJjYFZFRz+UYnSbeagCqzEISB6f?=
 =?us-ascii?Q?DzGDz/KJzH6J12jIDGoCWgoFsFW5+/ggsRXPVZB0R3FaMqbzdYTy8Du7gC5d?=
 =?us-ascii?Q?Oy3WO4V+/VQiI5dAizpVUgQuhKHM+DFXJ7ncThx8yifkHYCqScdG881GwnHY?=
 =?us-ascii?Q?S4BOzKKLcF5c6N3l27BU69NDdE6wKo3Og8l5ifv9miSFDdUVfAKCfDDcw1Go?=
 =?us-ascii?Q?ZIUuXtt38dHjTH4wU0rFZABdx54PnJJ9ilRIL2Uy1oxk+I6T5C22wNVENSn5?=
 =?us-ascii?Q?LX1oU54Javnf+vZG+tlyaLGJnHTlh1L/F2h+wjoncZSPE30RCuWec2QpcI7T?=
 =?us-ascii?Q?Whtx9g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f94e2c41-3a2b-4684-88d7-08d99ec238ff
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 12:05:26.9708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aMup3n+eTknA8NeBJP5sG7tL/T2ifmoyhUCHQ824OoR0SDFhbDcxKggRyyWeBjeZr1MfNx2TNEg44o0EgatgPX0cTfzc/mPVktMNTWOfxCE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5679
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111030069
X-Proofpoint-ORIG-GUID: OG5gRwZro93kh7mE0itF_nJ6WOxh5-JO
X-Proofpoint-GUID: OG5gRwZro93kh7mE0itF_nJ6WOxh5-JO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This v4 patchset look good.  Thanks!

On Sat, Oct 23, 2021 at 01:05:49PM +0530, Kushal Kothari wrote:
> @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pc
>  {
>  
>  	struct sta_priv *pstapriv = &padapter->stapriv;
> -	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
> +	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
                                                                         ^^^^^^^^^^^
An unrelated note, if you wanted to send more patches.  These extra
parentheses could be removed.

>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr);
>  
>  	if (!psta)
> @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *
>  	struct sta_priv *pstapriv = &padapter->stapriv;
>  	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>  	struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
                                                                               ^^^^^^^^^^^^^^^
Same here.

> -	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
> +	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp);
                                                                            ^^^^^^^^^^^^
Here.

>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr);
>  
>  	if (!psta)

regards,
dan carpenter