Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] landlock: Initialize kernel stack variables properly
To:     Austin Kim <austindh.kim@gmail.com>, serge@hallyn.com
Cc:     linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211103071427.GA13854@raspberrypi>
From:   =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>
Message-ID: <7a71215c-58f4-081b-6a2e-030073f2737e@digikod.net>
Date:   Wed, 3 Nov 2021 13:17:19 +0100
User-Agent: 
MIME-Version: 1.0
In-Reply-To: <20211103071427.GA13854@raspberrypi>
Content-Type: text/plain; charset=iso-8859-15
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Austin,

On 03/11/2021 08:14, Austin Kim wrote:
> In case kernel stack variables are not initialized properly, there might 
> be a little chance of kernel information disclosure. So it is better for 
> kernel stack variables to be initialized with null characters.
> 
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  security/landlock/syscalls.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c
> index 32396962f04d..50a6f7091428 100644
> --- a/security/landlock/syscalls.c
> +++ b/security/landlock/syscalls.c
> @@ -320,6 +320,8 @@ SYSCALL_DEFINE4(landlock_add_rule,
>  	if (rule_type != LANDLOCK_RULE_PATH_BENEATH)
>  		return -EINVAL;
>  
> +	memset(&path_beneath_attr, 0, sizeof(path_beneath_attr));
> +

This memset is already done with the copy_from_user() call just below.

>  	/* Copies raw user space buffer, only one type for now. */
>  	res = copy_from_user(&path_beneath_attr, rule_attr,
>  			sizeof(path_beneath_attr));
>