Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 4/6] net: ocelot: add support for ndo_change_mtu
Thread-Topic: [PATCH v2 4/6] net: ocelot: add support for ndo_change_mtu
Thread-Index: AQHX0JQNbBf1f8rxU0yw3pmW3csadqvxvuwA
Date:   Wed, 3 Nov 2021 12:40:55 +0000
Message-ID: <20211103124054.pcgruuipw5cpup6v@skbuf>
References: <20211103091943.3878621-1-clement.leger@bootlin.com>
 <20211103091943.3878621-5-clement.leger@bootlin.com>
In-Reply-To: <20211103091943.3878621-5-clement.leger@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ItM2KfvRSuDOei3D1Y8QtEauzWJDaoDrH4Ney0/KUMoFl1g1FmdSc95oVa?=
 =?iso-8859-1?Q?X4CQcRBsGodYxoCE4uLEN/BCKAwzR/Fj+Uh41hPXgCyQvK3w8Z0rk8IIA/?=
 =?iso-8859-1?Q?0A2gJowFARq4EPM/z7/r2jTu3jik+TdlVEKm5m2mRIal5nfy66nC6r4BJs?=
 =?iso-8859-1?Q?TM3GrgRNAclA9INitm6ncLxtR3cjWx/m7S92UlY51/tTaLMcoRuFXoDb/V?=
 =?iso-8859-1?Q?JrqMd3QVWpTKWYPNvteoyX4nNemQX07RR8VLmz7a2xH9Klgz4AWF701KsW?=
 =?iso-8859-1?Q?En5D8t8PLkVYbJqkVoxyGIKmuCsLwZGIX9zVYR9UmBwuLESDJQTSS+XgEC?=
 =?iso-8859-1?Q?a4npnNv8ukohRPEmINt5f18Gz2tzQwEDS3wcK9EcMVz5wnu7nJli0ISlCJ?=
 =?iso-8859-1?Q?s+eRMaPXqIzGqulJzfneRdHOA6k23sH6fliKIlgNYKoFAacxxWCdpE7byo?=
 =?iso-8859-1?Q?apHpd+9PJU/qzSHM6/NgHiEN9inrpvbjLm8GHMjhCwUbjs/hVPmSVkqBq4?=
 =?iso-8859-1?Q?lmMpz7RWU1iZIJZuHuL5yc0YmqX404naF/YfVt2ZuP8VetneC2oq1DR5Yk?=
 =?iso-8859-1?Q?MDgU9Uw30G4gr0SgHAWGNKTlXn829g3LjQDUW+lBGHpmjxvlhf4b0Rq6/j?=
 =?iso-8859-1?Q?yl6DNZ7cY62nqCiJixy6eil8g+lYA26+O9mMQDVFMcq8xAUEXHoXVvMp/Z?=
 =?iso-8859-1?Q?+VRTaSbwsw5eBl39hudWwYiLdRhnFKzuKvr3UW2v0q98f8NqsBlTvyGu7H?=
 =?iso-8859-1?Q?ZW0EaHQJRlNIPhTkkYywW7HUrRQSP0QpWAx4MGHYEEmZhBaoMo1+HVXtkt?=
 =?iso-8859-1?Q?HSfZ96Mur9YqRh0P4ByRWMOA8Rnr/Jdfzci9RSACtS7xPguIWlWqZPtrib?=
 =?iso-8859-1?Q?PN69NfcER/k7XOTxvtVZLh02rK78DRdq7lS/UuBS6kAg+hHzKJlhBxslLn?=
 =?iso-8859-1?Q?sIdi2sxAVOP3vVG38XYK5zOM18m7pLnswucUMMHI5F8BPvVCHdsoYZA20q?=
 =?iso-8859-1?Q?9wUII5dDbexylfpJ6MTdIuO6g61MwqML6loEvrs7DOL1tM/OrPE9SjKsRN?=
 =?iso-8859-1?Q?pi9E8Xf6GPERxcHFdiz770fC3/kSjuJ8QxkVG1vSpWA8dERl9D+0Ce4l2w?=
 =?iso-8859-1?Q?oZo0gcammFbJ7kNtrbvNzEcor5FGOFGE/0UXf3WWHr9EJ5lnb8swd5TV4k?=
 =?iso-8859-1?Q?ldgqFSnPf7jLupgFr2yT+l+q4wVGkHXmcWiTG27Pov8sseXUJkOHorVLBr?=
 =?iso-8859-1?Q?MiUHU+vToOnKk88BosjqENUL+Nj/+lf+PVOIqao7j8v1xy7Q467kNVXUK/?=
 =?iso-8859-1?Q?7OItzFhX+HsVycGLyDI9UkuGuxOy+X0g1zTnlpNr0CVqIu4N7y8j6gdrdu?=
 =?iso-8859-1?Q?V9Z0+YusirGN1TKp6MN03oxbGOLTi9L/KvGO2e2CVclanEBJhFefWLbdQl?=
 =?iso-8859-1?Q?Lr+xtqmRhTNADMsc/ewumNl0LHzg13fRQ0jyVdWEwDzqciRd3qlPhNtPAr?=
 =?iso-8859-1?Q?4ZD2jkpC06acOgc4JqmwFQ1/5LUb3MVXpfxubPYqX9c27bQ1Y9QBiS7hCw?=
 =?iso-8859-1?Q?j8WKTpYyqk2hC7MrM8OvMO2dOvuasgTL+t9znpz5ugjp9rwcMO7f5wHACV?=
 =?iso-8859-1?Q?mlZ/ATtdEVFQopAe3X9NS6RA2Plm5ZBQFF4x50YUzwFps6QvjXADf4dub4?=
 =?iso-8859-1?Q?6TB0w77qzxnqH3lW4yC6khz5+pEPnD8ullkn0AE8?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <DC0CC7D3B73CFD4D953FA7705DF96B27@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f2e5bb1-1b77-478f-eabb-08d99ec72ddf
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 12:40:55.4256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4OfDUKYnIQc5j1BpL+1YlOE5gg4XZ0I5nsXgDfCqhHYGIS+4cFXf+9J1/6p0Rw2saJEwL75KgeduGYdfmx84hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5135
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 03, 2021 at 10:19:41AM +0100, Cl=E9ment L=E9ger wrote:
> This commit adds support for changing MTU for the ocelot register based
> interface. For ocelot, JUMBO frame size can be set up to 25000 bytes
> but has been set to 9000 which is a saner value and allow for maximum
> gain of performances. Frames larger than 9000 bytes do not yield
> a noticeable improvement.
>=20
> Signed-off-by: Cl=E9ment L=E9ger <clement.leger@bootlin.com>
> ---
>  drivers/net/ethernet/mscc/ocelot.h     |  2 ++
>  drivers/net/ethernet/mscc/ocelot_net.c | 14 ++++++++++++++
>  2 files changed, 16 insertions(+)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot.h b/drivers/net/ethernet/ms=
cc/ocelot.h
> index e43da09b8f91..ba0dec7dd64f 100644
> --- a/drivers/net/ethernet/mscc/ocelot.h
> +++ b/drivers/net/ethernet/mscc/ocelot.h
> @@ -32,6 +32,8 @@
> =20
>  #define OCELOT_PTP_QUEUE_SZ	128
> =20
> +#define OCELOT_JUMBO_MTU	9000
> +
>  struct ocelot_port_tc {
>  	bool block_shared;
>  	unsigned long offload_cnt;
> diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/etherne=
t/mscc/ocelot_net.c
> index d76def435b23..5916492fd6d0 100644
> --- a/drivers/net/ethernet/mscc/ocelot_net.c
> +++ b/drivers/net/ethernet/mscc/ocelot_net.c
> @@ -482,6 +482,18 @@ static netdev_tx_t ocelot_port_xmit(struct sk_buff *=
skb, struct net_device *dev)
>  	return NETDEV_TX_OK;
>  }
> =20
> +static int ocelot_change_mtu(struct net_device *dev, int new_mtu)
> +{
> +	struct ocelot_port_private *priv =3D netdev_priv(dev);
> +	struct ocelot_port *ocelot_port =3D &priv->port;
> +	struct ocelot *ocelot =3D ocelot_port->ocelot;
> +
> +	ocelot_port_set_maxlen(ocelot, priv->chip_port, new_mtu);
> +	WRITE_ONCE(dev->mtu, new_mtu);

The WRITE_ONCE seems absolutely gratuitous to me.

> +
> +	return 0;
> +}
> +
>  enum ocelot_action_type {
>  	OCELOT_MACT_LEARN,
>  	OCELOT_MACT_FORGET,
> @@ -768,6 +780,7 @@ static const struct net_device_ops ocelot_port_netdev=
_ops =3D {
>  	.ndo_open			=3D ocelot_port_open,
>  	.ndo_stop			=3D ocelot_port_stop,
>  	.ndo_start_xmit			=3D ocelot_port_xmit,
> +	.ndo_change_mtu			=3D ocelot_change_mtu,
>  	.ndo_set_rx_mode		=3D ocelot_set_rx_mode,
>  	.ndo_set_mac_address		=3D ocelot_port_set_mac_address,
>  	.ndo_get_stats64		=3D ocelot_get_stats64,
> @@ -1699,6 +1712,7 @@ int ocelot_probe_port(struct ocelot *ocelot, int po=
rt, struct regmap *target,
> =20
>  	dev->netdev_ops =3D &ocelot_port_netdev_ops;
>  	dev->ethtool_ops =3D &ocelot_ethtool_ops;
> +	dev->max_mtu =3D OCELOT_JUMBO_MTU;
> =20
>  	dev->hw_features |=3D NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_RXFCS |
>  		NETIF_F_HW_TC;
> --=20
> 2.33.0
>=