Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp448592pxb; Wed, 3 Nov 2021 06:55:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj8wFH0nxqpcer6SFZ3JTPYWeDrUqNoWBzO5MQvn2VwuZ7Lo4V5g0DZO/MP6M0/VMqEfca X-Received: by 2002:a17:906:b854:: with SMTP id ga20mr1178160ejb.308.1635947743899; Wed, 03 Nov 2021 06:55:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1635947743; cv=pass; d=google.com; s=arc-20160816; b=WXkhSNMEq9JmUZDCYj7knQd4tjQOqFG42HtAuPA2/WMBWeRQ72BjMaHoFHTkYbyY/B NTQrXwpy1UQiwO8X6Xm30khJZtwuM1WWiWQiPEBh+BqToOVCi/0+tJHL3hSv/qBIQsah jCybDLZnQ5FnUg3xkjW6LpPx2wLKjTc/bkVZOUG+PPSlGTnmKy0u8+P+sISkODu15Dzk 19WS0uHqz7Aa5wxpimgLO92xY52LyIBTpiaGFeZYis9HLXF23cWxySbO/8rEumCqNRMx W15YABZwNlUlqOrFUu6gK5Kp4SwKHZ3MO22YH5Ll1fr3xTxafRyicS0UKhOA7EWuE31e 9GuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=seKJXWAwKPt0HlTyQtw9cWNRWo8z3o3zV5fHVffk/V0=; b=x3pT438SjmJ6+99AOKM8Ed0b/rgvQvmVprpB6EBY5x945G35BtrFdFNlyP5DTQ6IpW 2DiIX20RZNpSXlIVrIsqktJ22qz//Qb8i4VqeWE3vtqApLeKW2zJIVP6etJOd1vR8TJI aNXQ0djQKNlAig4+WtSKMlwWiySikfZVnseNunQWFJKG/rd/T+g6tyhfsPPI3j8E84lW le69RTxO6c6LVloMWjYBxG/i/mb4Nsa+kUGlh0oq68HMoBALpf1nh9Npat4dHh2KXdQz Q0IZvnEHtoy/XihQ+NtY5JIDd9MV64+DfdA+Wu71emxXBO/XGmy8G1qSmNl6mHGOcqZm VwXg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=B+WOfCG+; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si4902656ede.284.2021.11.03.06.55.20; Wed, 03 Nov 2021 06:55:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=B+WOfCG+; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbhKCNz6 (ORCPT + 99 others); Wed, 3 Nov 2021 09:55:58 -0400 Received: from mail-bn8nam11on2068.outbound.protection.outlook.com ([40.107.236.68]:53495 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231925AbhKCNze (ORCPT ); Wed, 3 Nov 2021 09:55:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gt9B00QpDeDmeOjhJWvVzI5Rj+KwKEx1b9U48Nd6LgqwXSY0KWRQbwIYrHRLVofd5fzWEX1U3rw7Zq9xL9RVMDQ0lYfVEJZNRFKqCnRndVWt7ObKVZNQXfv5SjBIdCZJyR2FXscITIrFdxvwabkhTBO9SnQV/b1yCqVpAWGUKps7weD7HzSsZCogXl1NP5Yr/HYcf63atWl5bb2Psk5pmUILhYRHMZNme9nzmCVbYgC+XVmk/j8KGqHM4M9CCTrd4MhWMu3h9JuEJ/wztOiBKhhgAba0pj23nhOsYYRAU5Uut6lw1W8cWmGwmQDZ6ojl63Eappb0kkz7shmOdNEUug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=seKJXWAwKPt0HlTyQtw9cWNRWo8z3o3zV5fHVffk/V0=; b=RpvjCGrRLAEeXzJYvtTUOqLL3h2MsgMQVRWjXvc+zHX/ZZds93KkL/lkgoThfPJJi2VKhf5mFuRaUma5iymOBo6f/4Uek+4GDhvGF5MMGp2NfqFArmZ6huqe0QXBhO2vVRr6bU72xeJnXV718TBlQVK3Xz1cpx4lS+cZVUzg7xAxRrJ4VFwuagOTdKE6QB1BIMInjU2JmXFsGCWp3rlLWipdYYuiH0z5oZ/p5ALdNOP5TP+xK73bxHPmBv3tFSuQaomuIsmQ20B/bi9c9njuhVP0N18I9lqyjRzCRggWOtn5/uCrRUosUXrLFcMqx6WIfgGLr2TMC4wcu4wqFLeMQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=seKJXWAwKPt0HlTyQtw9cWNRWo8z3o3zV5fHVffk/V0=; b=B+WOfCG+i9qJJMjIcl3RPUsQAkdvxCqMJ/71TQS51cC/wb2ZCKtkhcHpTnpJd8jWzlWwqSF7LwQ2phURt7mDuV38Lid0WLZ5D/rxDYUSqFLcDeLuMc61q3N/fJV/AdgyCgSs693fXpfZUZ3pCjkQ4ODyJJufDZH7J4sHqA+Ash1JDReZRw0/JtHJzuFECtueSGHUlLYTRy6mXdxNWLLM5IC7clhzr3ouhB236yWvSD+dL8+oLd6KzazO2fCAGW9xHNHFaBHEhDwREOHmx1RU7zKJybQGjZA1QX5HtXCER/oNUeUB5YQQTE0hW4RZ3QB0f/OlkNOj/POMwOF/SxxV5w== Received: from BN9PR03CA0711.namprd03.prod.outlook.com (2603:10b6:408:ef::26) by BL0PR12MB5538.namprd12.prod.outlook.com (2603:10b6:208:1c9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 3 Nov 2021 13:52:56 +0000 Received: from BN8NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ef:cafe::61) by BN9PR03CA0711.outlook.office365.com (2603:10b6:408:ef::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 3 Nov 2021 13:52:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by BN8NAM11FT042.mail.protection.outlook.com (10.13.177.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 13:52:56 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 3 Nov 2021 13:52:55 +0000 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 3 Nov 2021 06:52:52 -0700 From: Sameer Pujar To: , , , CC: , , , , , Sameer Pujar Subject: [PATCH v2 05/10] ASoC: tegra: Fix kcontrol put callback in AHUB Date: Wed, 3 Nov 2021 19:22:21 +0530 Message-ID: <1635947547-24391-6-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1635947547-24391-1-git-send-email-spujar@nvidia.com> References: <1635947547-24391-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 146634ce-22d5-4c99-7ba4-08d99ed13d6f X-MS-TrafficTypeDiagnostic: BL0PR12MB5538: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 77myj5ntfHvOY7PJVPHLgxyB5sXjltjZswKprh3JsoCXxLgmNweg0UhAt0j7afilKZ6XEtEFDB6wtPo6kHhI8yk25zOhwZQ/K0ZuSoPiOXvdA+zB6MlM8Oe0S+KEYlTHg5zx4pn+bqb0Dwuqvj83A90EIu80rnsRrE5+72d2j70Riy6JBv48JLrGoyGNQ2Z6MgTrEOCpBYBPiIzgx/71NJ18b8Xmyphy/Gjsjs8ate5m/fIpGpxUnYSG3A8E9Iv9Ko0REtzEdJGA8hi2lQEbtXlIZNZ6jOOPxrC/28DIlBJ4+L6/b05tOgOCZdTwZ7YLPqkTCmLQd5Qn/yutFpU9YtK2e72x/i3KXgwqp+dic6+nA8UtHkTGi/XSQTBzAfI1zLOGAhelP2wo6fKtb3w6R3S4ruPeGpH7Ip5CFCWgpKbTXMyqjhYZrLxQNPkAP+JBPfrdloVdZNcI7ESD4/8eg4SYyKd4S6pimKqglpn5tdM393Jmj6oHsSB4shkLtLF6ebrwCoxIykqGlSkFlKSCT+I8lExlqZKV/NLmMqyV23xI4l99VHWPGePESrR7hSnfzFAJMMqYuKlUUEngFcdCg/H3hxrKvvQn9KeQESUi1piXZjpqgqVioHRkoRmOpfAdpKKRFKYo9+YkDOLVZBUaoKi5pxa2Mk5aj3T6n0h+EQAF+bCFC9W1aHUMglYLDU9/muKNK7Ol5+xme5GwOep6fA== X-Forefront-Antispam-Report: CIP:216.228.112.35;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid04.nvidia.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(7636003)(4326008)(5660300002)(70206006)(508600001)(356005)(316002)(54906003)(110136005)(70586007)(2906002)(426003)(2616005)(336012)(36906005)(82310400003)(26005)(186003)(8936002)(8676002)(6666004)(36860700001)(47076005)(83380400001)(107886003)(7696005)(36756003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 13:52:56.4206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 146634ce-22d5-4c99-7ba4-08d99ed13d6f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.35];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5538 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kcontrol put callback is expected to return 1 when there is change in HW or when the update is acknowledged by driver. This would ensure that change notifications are sent to subscribed applications. Update the AHUB driver accordingly. Fixes: 16e1bcc2caf4 ("ASoC: tegra: Add Tegra210 based AHUB driver") Signed-off-by: Sameer Pujar Suggested-by: Jaroslav Kysela Suggested-by: Mark Brown --- sound/soc/tegra/tegra210_ahub.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/tegra210_ahub.c index a1989ea..388b815 100644 --- a/sound/soc/tegra/tegra210_ahub.c +++ b/sound/soc/tegra/tegra210_ahub.c @@ -62,6 +62,7 @@ static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, unsigned int *item = uctl->value.enumerated.item; unsigned int value = e->values[item[0]]; unsigned int i, bit_pos, reg_idx = 0, reg_val = 0; + int change = 0; if (item[0] >= e->items) return -EINVAL; @@ -86,12 +87,14 @@ static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, /* Update widget power if state has changed */ if (snd_soc_component_test_bits(cmpnt, update[i].reg, - update[i].mask, update[i].val)) - snd_soc_dapm_mux_update_power(dapm, kctl, item[0], e, - &update[i]); + update[i].mask, + update[i].val)) + change |= snd_soc_dapm_mux_update_power(dapm, kctl, + item[0], e, + &update[i]); } - return 0; + return change; } static struct snd_soc_dai_driver tegra210_ahub_dais[] = { -- 2.7.4