Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 17:28:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: hal: remove goto statement and local
 variable
Message-ID: <20211103142814.GX2794@kadam>
References: <YXjXsChOpaTThkxT@Sauravs-Air.domain.name>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YXjXsChOpaTThkxT@Sauravs-Air.domain.name>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pwohrlyt24LQs6DATJLae0y16KJjqywxdycJ39CuxSr14dlgiXkRTBzGE8T/?=
 =?us-ascii?Q?f9t6sntECorHlS8ckkqw046901lSH5QG+dczsEeyCKLC+yZdE6ChjtuFkJKq?=
 =?us-ascii?Q?HgGPD7AgKlme3PMi85i16/zRPdL07ka/KbS7lFx6p6psYG56NIY+yeH0bFCV?=
 =?us-ascii?Q?k8uYG3FqMfxDxyRNw2RYvXr1i6vouQwy8Vc6GKy17egoL1vN3llGRCWcDAtp?=
 =?us-ascii?Q?1DTUAFK05Y2hzuq5caF4aCSoH3uBnRmH9ZKvzlifpQNiyMgmGkG3V6eEcVou?=
 =?us-ascii?Q?+X3jHdjT0etd6zTVPVqZ2g7BlS2iIYgp0q4XJBWDrVtIL+rFBoPAVwUEQKoq?=
 =?us-ascii?Q?kE819VCGF5QEh5VBF2tTdA9Gqp5+uKFe/DTfhWEV2PCjOaY7xdtmF55DbxnA?=
 =?us-ascii?Q?LVgoqsOpBGvJZjA7KMIcfxhPu4m2a3oYrWC8uHKkqex8yFanLS34/EVYoAfi?=
 =?us-ascii?Q?p4/Nsp0mMGlE3WhHqYmwh35GlkWlLDjZR949hIxi6+NP3SLFa7PyeS+JC0Fi?=
 =?us-ascii?Q?qmXnanN44KPFtmXm5AlA12SKHCVEXfEHl9aa6mJ5UXnHBGsStcaxi46DLPCf?=
 =?us-ascii?Q?rIzwMNnWFItywrNLUHWzD8V68I5ZqK905CLWnLzAvFJWQW+x55Y/ouocB3Q9?=
 =?us-ascii?Q?zTjDQjCBaMiiP0QPNA4MO+m4TeEUU1OX3QvFPTJskjf0afxkct3DZIT4IkyG?=
 =?us-ascii?Q?/OVQnttcm4CvYjaL/xn93WjNqGj/2UPgf/oXD2bxM2l0Ivqu//cfKukaGiiy?=
 =?us-ascii?Q?mKte8ck7IAoVVbwkZYcFAPzip6AvEf1WZZymfFEuVKu22n0T9h4XSS4DIbyc?=
 =?us-ascii?Q?Nnz/EfKE7dFvrvbTl87kOGtpyGRhitV56yhYgMFIJoLKJqsVKEIPYn1A5wXe?=
 =?us-ascii?Q?WfbzghbhIGomqaHh/HyGG0xjYpOOW5pFGx38bidjjCaRsdW12KKjhr2M1vbD?=
 =?us-ascii?Q?Bxr4+eor3S1fAQr7W4pfW8UkH5pJptlDmzawkKXes8ta4qpcmeCHqnEip0ec?=
 =?us-ascii?Q?YBeUj39/N1NB2lwwtvY4QVnGCPN4SIzRCvfYTb5IESEN8hfCjjP6t8J4xoTP?=
 =?us-ascii?Q?t9x0XlUP8qQK6jHoAvl97TgQExZ8l1tcuzfu7CdGdyLz5FUphNw105ufbDeT?=
 =?us-ascii?Q?S+f0twszR8qwY8GwP/vTm2m2w76SYZjsUP8RT7NfsBFT2Ly1GUtmKPuOZiEw?=
 =?us-ascii?Q?hJ0StKCi3WLTvqNZR7dLAiG+Ut014iO3xBrFDeFGN1NsNkjBeK2b8CJTCLMp?=
 =?us-ascii?Q?g5dmoMZsCwfzUk+oWq87zUTCO0t+rP9uxnuNt54yWvMnPEYJoYF7m3vd+D+d?=
 =?us-ascii?Q?nawcwE9M9U1aatZUq/pAjiDSgoEIZyWu8Tr6hVG6EtGXE7YuVp2VKHs9gIXr?=
 =?us-ascii?Q?589oxqjYAnVsD+RqvCuixvxv1CqIqJOZ5tMjmxnQg6L6pBboh8C8wEg6ytw4?=
 =?us-ascii?Q?Rj7/Yvkure3ie2dpA3T7XKtkTvkkWJoy0VEvmiVuCoMuM4uxrPsE7/4aXWkm?=
 =?us-ascii?Q?nEfxUlm9wQp4+MOK+cE31sfriK35zb1gDjXILFvXEnm3pUVpDuW8lqaaL8rE?=
 =?us-ascii?Q?PDvuagIXjgASM5xgFvIZFX1oEth629Lykjp3mOQa/RFM421duy7lr6JEH66w?=
 =?us-ascii?Q?bLW3HzZNURJwuOl+j/VMYhkGIOvAXFeswDXeJXA/oQFnGvIcl4pANAlN7pcB?=
 =?us-ascii?Q?qoOheQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13526c94-debe-48e4-5509-08d99ed63682
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 14:28:32.7255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PRf3ZSlEQApRz2Nb+yUZuCt81hYK0EPRCsBzDNRZ+TPLBw30q6EaaOSqtb5rFnT4qxBaABlNR53kiTzzuAAUp2TyVXgsGlkAsDGL1Bw5opM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1479
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10156 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111030082
X-Proofpoint-ORIG-GUID: IetIOVoPpqpHA9snwJexWtQjgWMBketE
X-Proofpoint-GUID: IetIOVoPpqpHA9snwJexWtQjgWMBketE
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 27, 2021 at 10:08:08AM +0530, Saurav Girepunje wrote:
> Remove the goto statement from FillH2CCmd_88E(). In this function goto
> can be replace by return statement. As on goto label exit, function
> only return it is not performing any cleanup. Avoiding goto will
> improve the function readability. After replacing the goto statement
> local variable ret is also not needed. So remove the ret local variable.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter