Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp572760pxb; Wed, 3 Nov 2021 08:50:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+x8irvMyaVT8mJ0pBqx/nPnjXfosRhJf67+4W44tFXJJ97tyjyQiTa2DEdSUdrFYAkryP X-Received: by 2002:a50:fe0b:: with SMTP id f11mr51912178edt.231.1635954627868; Wed, 03 Nov 2021 08:50:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635954627; cv=none; d=google.com; s=arc-20160816; b=hSNN+qXzG6snOohS32IFWw1lk93E9IdNt04G8COOnFWaVnTFq8N3Zc+B9IRBojFtBJ 54I7rNPlR1ZV2+K0Zxf6NGydBYRGSSVnfPheFQRlmuR+S7lcz0ItLqxm8QzBBURIKjtu ALJkeqyLW6pJXOmiMgqNEoIaKpYKLB2Q9uMvhoXBAj2YryM5p08KYUemyVUb0bdh+wLI eKKGEipDzR/yz82ZgpEkgFdyZpQGTAXFlQGeeEq0vse4SGiYfnLOayMWlnBS8bznteJX zVKuj0P6lRdLkHySnfGq256FSlzV3NW577kMKYPKCpsjFFY5L30qvkwZjG9SiphZhI4q wk0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uvhCYO3u6RDwlw78dmgr43XyvS0FTkLqrMBwebmLY98=; b=vOD/AeQYOa5ueyjXi2tnzAnDgwUh3lUPRhdn9nR+wS+/td9yhT1bq2SCuBaj9qOVe6 mJS3uEkyzTBavXUrX7Hcc92hb/ozs+6L1Ov6sl/oaNHD5lQmPDgiwX+OdmC4Q6Vwq2v2 avw+8lMgb2bqu9t/GIodL1yl+lzLGiqFGT6YzOkhOihm6J/wgFLo56Et9H61OQfZZErz 8BzTx0fKZBdllXalDSWwrIIC+l9JTNLuXqzpgc9HHG+AsoRhgtTgcM73WbkJtDasq8Bo qG76TJ2wCNWgmX+mr2qJPqls0Tm1mlhFlcMNdOnD89Xn7yTMXBIbUBn4pOx84EDkTa33 qbdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZimQOUk4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb21si4657668ejc.63.2021.11.03.08.50.04; Wed, 03 Nov 2021 08:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZimQOUk4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbhKCPuZ (ORCPT + 99 others); Wed, 3 Nov 2021 11:50:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:34058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhKCPuY (ORCPT ); Wed, 3 Nov 2021 11:50:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 82E7360E73; Wed, 3 Nov 2021 15:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635954467; bh=ShZNa7IW9gaF+i032Z807KygJzIVvjgwfigBHlZygoM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZimQOUk4jdQdwDMhecAVgUsdtQ3K9TwgQybjHJlfCrXzeqQmtgJR/tsZKd4nZKmN5 8W0eWWO3l4hlIcmACaHjGlc2O50HhOFvBsxE4o/YgqDE1Bn3CIf/p3rPW6fWoi1pWy f5Su3+xYGuN7pAdj5apkZapCReGbEVB7Zf8SRBKiX5dZ/sXoTUnOcfpncpCN6kOge+ nuqcArUV/yBjjC7uZmlCAlqWRDkDq3ULk6NLiaUG1v/9azpygcv/2z2RCpAq+7Yde3 SNnrWQlehQGRA2bTRyT8CzOsqlB0A+yub8si1KATIcQitEmIFpwYKJ63aIDWTBW+pO FoWqSgynBzEuQ== Date: Wed, 3 Nov 2021 08:47:46 -0700 From: Jakub Kicinski To: Jason Gunthorpe Cc: Ziyang Xuan , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: vlan: fix a UAF in vlan_dev_real_dev() Message-ID: <20211103084746.2ae1c324@kicinski-fedora-PC1C0HJN> In-Reply-To: <20211103135034.GP2744544@nvidia.com> References: <20211102021218.955277-1-william.xuanziyang@huawei.com> <20211103135034.GP2744544@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Nov 2021 10:50:34 -0300 Jason Gunthorpe wrote: > (though I can't tell either if there is a possiblecircular dep problem > in some oddball case) Same, luckily we're just starting a new dev cycle and syzbot can have at it. We should probably not let this patch get into stable right away - assuming you agree - would you mind nacking the selection if it happens? I'm not sure I'll get CCed since it doesn't have my tags.