Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 03 Nov 2021 17:06:41 +0100
Message-ID: <s5ha6ilkyum.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Wang Wensheng <wangwensheng4@huawei.com>
Cc:     <perex@perex.cz>, <tiwai@suse.com>, <broonie@kernel.org>,
        <joe@perches.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <rui.xiang@huawei.com>
Subject: Re: [PATCH -next v2] ALSA: timer: Fix use-after-free problem
In-Reply-To: <s5hh7ctkzi8.wl-tiwai@suse.de>
References: <20211103033517.80531-1-wangwensheng4@huawei.com>
        <s5hh7ctkzi8.wl-tiwai@suse.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 03 Nov 2021 16:52:31 +0100,
Takashi Iwai wrote:
> 
> On Wed, 03 Nov 2021 04:35:17 +0100,
> Wang Wensheng wrote:
> > 
> > When the timer instance was add into ack_list but was not currently in
> > process, the user could stop it via snd_timer_stop1() without delete it
> > from the ack_list. Then the user could free the timer instance and when
> > it was actually processed UAF occurred.
> > 
> > This issue could be reproduced via testcase snd_timer01 in ltp - running
> > several instances of that testcase at the same time.
> > 
> > What I actually met was that the ack_list of the timer broken and the
> > kernel went into deadloop with irqoff. That could be detected by
> > hardlockup detector on board or when we run it on qemu, we could use gdb
> > to dump the ack_list when the console has no response.
> > 
> > To fix this issue, we delete the timer instance from ack_list and
> > active_list unconditionally in snd_timer_stop1().
> > 
> > Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
> > Suggested-by: Takashi Iwai <tiwai@suse.de>
> 
> Thanks, applied now.

BTW, while reviewing the patch, I noticed that we have also the
similar code path for a slave timer instance that has the same kind of
linked list entries.  I'll submit the corresponding fix patch.


Takashi