Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 13:11:33 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ziyang Xuan <william.xuanziyang@huawei.com>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: vlan: fix a UAF in vlan_dev_real_dev()
Message-ID: <20211103161133.GS2744544@nvidia.com>
References: <20211102021218.955277-1-william.xuanziyang@huawei.com>
 <20211103135034.GP2744544@nvidia.com>
 <20211103084746.2ae1c324@kicinski-fedora-PC1C0HJN>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211103084746.2ae1c324@kicinski-fedora-PC1C0HJN>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cTFpd+40/eoMrkJSVKEftdugvUghu1Od9/iEJfaVoQ3UhwtMKH8lo1NZebw5?=
 =?us-ascii?Q?bXDvaf7+gXo20lAQRR7wiZDsLYDEX+/uObWpPertHh5/H7qjJyx0s8LklBt5?=
 =?us-ascii?Q?xB5fJ7RrXsNIsmL9OdsMhp8AHxF/Bt0cZpJy1v343aMqS57pWRsfro/CsFYf?=
 =?us-ascii?Q?TOW1cZ9MqBP2ZYgplINxUjlW/zCYO/zQ6WyN5FLeQ9ClMn2DTs5GvAMoq+qH?=
 =?us-ascii?Q?VZ2eQu8smdoN8fDXpnyPP/d7vRSqsU3AFSMtR7BuqdgHm14dLfR7hJgGYF/z?=
 =?us-ascii?Q?5myxfNNeC17YVsPaJn0zSafqTnTlDcZtwDHOrQRZrQQJR7q411HbbDU19Hws?=
 =?us-ascii?Q?7YosK39GGyVAK3z38SBm7Znhl39XlfnUzKA2RoOu9FHu5Lyu3Vs3GyVfHoYu?=
 =?us-ascii?Q?eEBfjsDfopWcW6XUZ3dyslZ7N1K/+x/6So/mHmS62fRIjXwW88UKoHiraEBn?=
 =?us-ascii?Q?w+P0mvvgqhFhNAy5wFr2A6+iZ4BTytYSbDZ6m7sc7qXLO95gdu0u1GaHmQCh?=
 =?us-ascii?Q?CKpnUwUcYE7qpQXj7ediTz1sRzJI1AkjUAJbL3hbvJhpriDNbhQuBFSxi5fv?=
 =?us-ascii?Q?Mjm9bLKW4WARL2AOiyta12479YpYAK7bVkmqWthr1J4CyBbvFkckwSpGCdJe?=
 =?us-ascii?Q?14weAjayMiOXn3kb+bV0ZrKqgTcbefAXnVcTE+xceM8DS7Hd7NQYrEayPUT3?=
 =?us-ascii?Q?4H/mig53OnvtWU6s56oTrszQ8tGdw/42dmS4gJrP4W0uBUr/dVgKDd2Ic8p1?=
 =?us-ascii?Q?clgsiR+CpXAa+o3ciaA6MSNtcEXiOUv9lciMgZQnn0EbxlwmNqvJABsfq0mz?=
 =?us-ascii?Q?QAFhvp+06QNJb0zgpKzZosOCsGW6WadWdBM9/eyh6f2RtTuzErlRPluMrnBS?=
 =?us-ascii?Q?SQ/ifvWh4FYgHUjdGApqHnRFWzvwxqO658BGuZoaw8ZawVnKScf2mhFdQJc2?=
 =?us-ascii?Q?/YCCRORHMjZnmIHPjHuT0tMGMGEAR/ckN9WJQV8tcg7kZUJ29qFkfOgclkGR?=
 =?us-ascii?Q?2OAXqmP7qtGPcT+LF5oNR/c0DK3lvK/SBYcdQQNuQRiABWOoWaEUb1U+V6BT?=
 =?us-ascii?Q?Ms567URbA402iKBN3X6lyNfF5YOjG/La5RvCvtf6NLITnnOvXZAYycBfc1SV?=
 =?us-ascii?Q?jje0M6FtRthmHJsPm9e5YkrUOiwALtTgUoaaarWwBTVd7JtLlXYFssCbWHFm?=
 =?us-ascii?Q?Nl2phEDLqzn0Vr086WLBrPlaGLq3/AcSljL0wmbt2ZwNwWherGedU8wJV/uD?=
 =?us-ascii?Q?35tWJXArl1b3OroKedMj09u1vIE6JdiEJbwfdIESVzSzHHWJiHKgjmLHIMaj?=
 =?us-ascii?Q?3BWBujB+j0U0tuOy+ggVir/H8TDdpPShXIu66B7hxPQJpGpQ2ruxEIJR6dht?=
 =?us-ascii?Q?TrT9MhbHgEgHLDG14+sYjgyc3ki5f9uPNw1mlxFrzknbZ7pnlavkeQSt3Wfc?=
 =?us-ascii?Q?y1WzFhOGb3D4H9NZAvLTpk6msnSyB/ubjNo26WrTrha1NWr35lseATDZoUAg?=
 =?us-ascii?Q?wRtxI3iaMhzP5dzVczaN5NswwL3QlWVq16Ef+4AsPU/amIU7pmcLIC2CnMFM?=
 =?us-ascii?Q?tUY/+By3JJMI5WGLN+M=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2463bafa-d139-4f1b-307a-08d99ee49b6e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB5520.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 16:11:34.8093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBW8l+/p4qAEIm/RG+QL/vtEd4SAVT5CzMK/Oxu1FztSzyUDPlujGgD2gkfa86fv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5462
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 03, 2021 at 08:47:46AM -0700, Jakub Kicinski wrote:
> On Wed, 3 Nov 2021 10:50:34 -0300 Jason Gunthorpe wrote:
> > (though I can't tell either if there is a possiblecircular dep problem
> > in some oddball case)
> 
> Same, luckily we're just starting a new dev cycle and syzbot can have
> at it. 
> 
> We should probably not let this patch get into stable right away -
> assuming you agree - would you mind nacking the selection if it happens?
> I'm not sure I'll get CCed since it doesn't have my tags.

I will make an effort, sure. It is hard to be confident due to all the
stable selection emails I get :|

Thanks,
Jason