Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 11:13:08 -0500
From:   Han Xu <han.xu@nxp.com>
To:     Christian Eggers <ceggers@arri.de>
Cc:     Michael Trimarchi <michael@amarulasolutions.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Stefan Riedmueller <S.Riedmueller@phytec.de>,
        Greg Ungerer <gerg@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Christian Hemp <C.Hemp@phytec.de>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi
 clock setting for i.MX6
Message-ID: <20211103161308.n5vxrllgil3ntpxs@umbrella>
References: <20211102202022.15551-1-ceggers@arri.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102202022.15551-1-ceggers@arri.de>
User-Agent: NeoMutt/20171215
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z8nysXbA5W+341JYyh3JXXD4jNnqr3+t6tBGRV85k7MMGinpI4Bf0krQFw0Z?=
 =?us-ascii?Q?GGpr/NHltR/ARrjY9eceUn8HRadM/BfmmmHjFwJTMlIo2l2Yy/6BqJMj3LH3?=
 =?us-ascii?Q?kZn39pdHcqXcPkItAA1/+Yw8/2EknpVgMGqBv8Ft67kc2T6YBkdxHdbloPiT?=
 =?us-ascii?Q?wHBvSYXR6BZjEKQEOwBpDCJK+C+n9tmjn7rrB0F6sO9stuMxE9sIVoRVgzac?=
 =?us-ascii?Q?E8eG5BUOnSGzycrgbru2RZGSZ6tI2mFX+mFcAg7cFNomQ3akFXWJVs2FeO3f?=
 =?us-ascii?Q?8A8CfkdXutmRCqoTh5zoh8eHrKmro862v/dLBFomCFIV56BRUT7vDC0vNb2e?=
 =?us-ascii?Q?Ld5Mp2IQkhcl+uZSpLzbFzKlF4qOVHegK7kArkwo8QOFGJc1gwCIszYFSXIq?=
 =?us-ascii?Q?CZ1ckfzhdm+SH99LseAaGIAh9YokOKxGZRBI7x77rHB+PSINbgONJJpH3bIr?=
 =?us-ascii?Q?WEE2S1pj8BLuT7qQc9EDCyyno9/RETaxsD7rZ9WD0RE8UKjx0FNe4bnV3cK1?=
 =?us-ascii?Q?HM63DlfDj9h2NZhcrhIm+iWYFYmfwuDrDKrbZ82vaxxzzWnMZsvpl3B3MEa8?=
 =?us-ascii?Q?8uHNL++7VcxEMpYYD9+2oC7f+l8S8W58SDq2sivxH25Y4aqrwnFpbL/Ga/hD?=
 =?us-ascii?Q?xjjT+IyZP7KW0Z+7DKNkNX17TNJMwcTWzeoMs4EYz4jYhpnI88NxvuFlcFxI?=
 =?us-ascii?Q?6jtCVXAgqzWOlJfeFWqbHs6MGF9k2n7YH+B7bmjXhmz+J4851jpMecFVrAvv?=
 =?us-ascii?Q?dAWCdiyRKxwRGcwn5HCZRweUdDINN9jHmk7HtnZkiTBrQI7E9NBkTXvJkHku?=
 =?us-ascii?Q?i5IqxBYxpq7jmAv5H9CSTXHG4V7SApynYALM3niQUC4zqEL2x6Vd8nEPNDte?=
 =?us-ascii?Q?5CO7+wTrmGp4nfD9UxbBaYLoWN6bssalQ5dmqn394lOmwqHdHtLFrPKtaXYu?=
 =?us-ascii?Q?qy8p2fCZWBTUPWypN5KAcfCwiRhXv0g/JulnTQVWh/htM60IIDQ/WW5xNyVk?=
 =?us-ascii?Q?tblOxPMc9J1stUJPYX199xhDR/h9asqQuF5JEja20c14gnKZxIvkeM8bxB4R?=
 =?us-ascii?Q?olzZkr6ZmTtSq9Ds4FUCba/lc/D1p3Trq0B/bnQzrti0hzEXRpSkmmH3rhGB?=
 =?us-ascii?Q?aqUFgk3FZ591F+nfQg4Hzqj1EvM9XlPWbiOyVk6MhdvMZS+MBjH9JdfpUka5?=
 =?us-ascii?Q?Z/KkPdJr4kXB+i4wQr5nbudo3NHNr/iKnwCeUhU4UpfdphvoM+Z7mc1itnrD?=
 =?us-ascii?Q?UNjNCKDdsCpWTF/0p5dYictWKVXGLGh7M5inPbFzScswNx07rK3V1hqw6HJu?=
 =?us-ascii?Q?WMtJIv8pk8/TcnvyySljrXU+nv4T9V/QYv29vxCCducgtDT1QlVAiPyYzVN0?=
 =?us-ascii?Q?WRE4kPAPxc3++ugOSvIzTeCjL69fZSEsNXGVx9b3WGvd5Rd4yKpheJt8M/BZ?=
 =?us-ascii?Q?uNkVy31eNDAuXMgxnhTegJh1cXW6LPbiuvzX3OnMzAQTlmgIFpLmrUtYGEHI?=
 =?us-ascii?Q?F/fYWcF3W0sXl8nAecI0EPTjCob9vbLF82zzWoycR80yE+Q/J7rP/afXruKm?=
 =?us-ascii?Q?zUT65i6kbw7+btHEqMU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0972bc5d-5367-4484-7189-08d99ee4d957
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 16:13:18.8641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QQwR5ulbS52UyTrGUCMyldOGB9oPcJWtMrmEDRxp8IV3o+HN0GLXQcEuM83hu21O
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9273
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/11/02 09:20PM, Christian Eggers wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
> 
> There is no need to explicitly set the default gpmi clock rate during
> boot for the i.MX 6 since this is done during nand_detect anyway.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Cc: stable@vger.kernel.org
> ---
> @stable: This patch fixes a bug because this (superfluous) call to
>          clk_set_rate() misses the required clock gating. The resulting
>          clock glitches can prevent the system from booting.
> 
> Changelog:
> -----------
> RFC --> v1
> - Cc: stable@vger.kernel.org
> 
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index 4d08e4ab5c1b..a1f7000f033e 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -1034,15 +1034,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this)
>  		r->clock[i] = clk;
>  	}
>  
> -	if (GPMI_IS_MX6(this))
> -		/*
> -		 * Set the default value for the gpmi clock.
> -		 *
> -		 * If you want to use the ONFI nand which is in the
> -		 * Synchronous Mode, you should change the clock as you need.
> -		 */
> -		clk_set_rate(r->clock[0], 22000000);
> -

Acked-by: Han Xu <han.xu@nxp.com>

>  	return 0;
>  
>  err_clock:
> -- 
> Christian Eggers
> Embedded software developer
> 
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>