Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp630970pxb; Wed, 3 Nov 2021 09:44:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqnD8f+0T8zeUeBVndbabhswKaPcR10Em4c3/zqgLWGnOmhvdG13in10OtJ2NH9VTFbiAL X-Received: by 2002:a17:907:3f07:: with SMTP id hq7mr43502356ejc.420.1635957849462; Wed, 03 Nov 2021 09:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635957849; cv=none; d=google.com; s=arc-20160816; b=oKB8JNpc+22X47BJi6xJgd+tkd2xmGfw1sGVsrkbitP51kP7q90w6YCS6fKo7QD5mz NxovMaMgES/C/y4LvKNygthtEGEFhojc1Cl6fgPDyMg6ysV2JqJ0w2ZOb/4mhbWA4gq/ Nx7VOL84DtA2s0X1Ktxswp2qa9jQnz3VJF6VtvPG2yZLIkKOHKdVwaY3po1eul5XkOle ti1tgw3Ma4FT5/St8TjAGemgiYYRjSVDZqfudXExzzSWkMSH/uQlHSPDSLp9eds9LCXq 5zRDx7xm8l59bKGPC6BoZrVoMKd47jGPzUXIv4be0shVoIgygMdmF89R+7P4S2g+qGV0 9mVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=gNXNowf+gVg+0SwAZFwkXo338LR4OwBwJwdP6d1BrCk3X874cSxZoFImJ5fDDgoEOd CF1mU7h/MYpI0Lwl+cqIc9PQdH6s6uMVjJHUZ5OPkbAfkv3TcplBm0/y2aj9/4fwcymS hZ8Bt+VimGPb/RJHozRlrWs26Hj3zBVSeNQJC+gAN//vbmw5yVU7/HZ7iwPStRuCJLZR DHRkC/EoG0LHED4zD8xuzgzXOiYjyXqGOF/OxxvJ5osNCPhMpTdqtPjuRNywKB2MeJ9Z S4/Oc5p24i1a+QaLLDuXR1su+36yoVVK8IiFBn96RIdm0KpqUBD8J+3nVVNT1S13gi3R QD2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wL305YpM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa30si4672904ejc.246.2021.11.03.09.43.42; Wed, 03 Nov 2021 09:44:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wL305YpM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbhKCQob (ORCPT + 99 others); Wed, 3 Nov 2021 12:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232860AbhKCQoa (ORCPT ); Wed, 3 Nov 2021 12:44:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB684C061714; Wed, 3 Nov 2021 09:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=wL305YpMdGf01r1YkYJCQhU9IX FKqEKdw5uxClkcSIOys/GD/BtTQBjilWqF0bN9pdBAzSxStZ8zTEuLV8acPlQiXbwNNlmtc1DSnhQ bKZ0wkvBrd8BATICZuTILD8TruUXDegEyMS/7SM/6ovhyBRMgtRrhkGeUXVQJ9amXZrv8DYRZ7T8B p7PRtxxfxelo+E/TdoKQ5Q0hkc7BuutJwt37eIKAWuuw861f9ZmzTwG2GyU+vEQvmL8+0GyDLj5e4 UPxACVShhN/VflAy7u8l5GcKb5wpZb/7WxGIBS5Oo9z7dk+LB/KDQUX9ukc7CLM1DSXtnKJ5PhcLV Qbt4M+TA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1miJKi-005oS6-Ma; Wed, 03 Nov 2021 16:41:52 +0000 Date: Wed, 3 Nov 2021 09:41:52 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hare@suse.de, hch@infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter Subject: Re: [PATCH] block: fix device_add_disk() kobject_create_and_add() error handling Message-ID: References: <20211103164023.1384821-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211103164023.1384821-1-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig