Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <704e71ce-e6c6-6492-8f20-47e4fad8cc39@suse.com>
Date:   Wed, 3 Nov 2021 17:47:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Content-Language: en-US
To:     Charles Mirabile <cmirabil@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Serge Schneider <serge@raspberrypi.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        linux-rpi-kernel@lists.infradead.org, fedora-rpi@googlegroups.com,
        Mwesigwa Guma <mguma@redhat.com>,
        Joel Savitz <jsavitz@redhat.com>
References: <20211029215516.801593-1-cmirabil@redhat.com>
 <20211029215516.801593-4-cmirabil@redhat.com>
From:   Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 3/5] drivers/auxdisplay: senshat: Raspberry Pi Sense HAT
 display driver
In-Reply-To: <20211029215516.801593-4-cmirabil@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M25tOW1nSnlHSk5HSVVIR1ltN3pwd25yUEpsajduMWR4TnVNdnJWRkx3L1ZC?=
 =?utf-8?B?UU81d0RYaTdoM1FLbTNaRzFkOExSbk8wZmYva1FKVFBVTUdnenpaeW5Obk0z?=
 =?utf-8?B?WDhzRVpFdVd1ZWR0akkwOU1TV01YalVYYzdaL0ZEZHpicHpWM1M3eVlaMUR6?=
 =?utf-8?B?b2VhalJHNWk0RW0zYjlJQU5qL1kyWW9INWRPKzNsWVNEam1vb0FIU3lpTGk0?=
 =?utf-8?B?UEV1TVpKMm9IcWYrbS9WYnpJaGtQa1I5ajlMbi9pVlA2TlZLUjd6RVF5Y3lE?=
 =?utf-8?B?RVJUblQ4V0lBajlLNFkyckRlR042VVNmUU1zamJ2TjVOc1YraHU0ajlULy9H?=
 =?utf-8?B?Qlo4V0lXMUtOT0QxbVljcDUzWGd6eDhFYkNXbFFFK3htQ1Rlb25YRnFrVndQ?=
 =?utf-8?B?NHgyUFBiZWhFTWFuVURMeWhWT1YzK1I4ZVpjb09UdllKUjl2WXpRTmYyaFp6?=
 =?utf-8?B?M0x2dXdqK2p4aGV5YVdsWXpYQ3BqQ2x0NjZ1elhKdkp3WmFuQmtiR0E3N0FV?=
 =?utf-8?B?SjRRbTEydkc2bFRmYWlhQmZ6ZnFHVnU3NlBUZlhLcUxqSGZNMFpwNDcvMUZV?=
 =?utf-8?B?WnVmK2o1Mis3UlNXc1hjRDNwQjBNUFBBV1FieFlMS3E1blFweHduVnVvQUkw?=
 =?utf-8?B?NWZiRytqVDE5aTZrVmxveUFGdHphSmJjL3lLemkvd0wxbURTSnlUM3oxQ2FH?=
 =?utf-8?B?UVlhaHp6eFhlRjV4Y0xxQnlFWE9sbkFpMkNpZ3ZxcHBHWVZzd2haUkZkaXhY?=
 =?utf-8?B?N2RIaTFIY0VkKzMrL1NLOTdaTUxQV09IM2pMckw5VGZrRllOMDkyOWVrZFJ2?=
 =?utf-8?B?SGhwczIwRURkRk1ESlpPWTJManZtcTl1OEcwKzNkNlJrTlhreGZMcmkxcHBx?=
 =?utf-8?B?UFJRWFJxL0hOMHdSRUxGTUJZNUJDTzhvUlFwSytzaVNnYmJRa1REVHZ4b0pH?=
 =?utf-8?B?RFBtdGJGM2JSSGxSV09UNklSV2hVWUk5NldBYU9xUUZRZFFmeXp3WmVJYTl2?=
 =?utf-8?B?eDF0bndYelBxTWJlVW9LemJpZUJKRXJJOFR1cjZUYVB4T2FlQ1lFbmphMS9E?=
 =?utf-8?B?SWFlUXlaamFQenFJQXlCSUtnY1pxOXY1SmhvSTR5RmMzN3BobDgrb2FWVHRD?=
 =?utf-8?B?WnR5VXgvQjV2Y1BnRWMvYU5FUnUwQ3lzWmhrNnJKQlN1eXlhckoxZXBIdGFH?=
 =?utf-8?B?M2hncWFqdW1pWk4xL1hTbi9GTGpXcjNtV1N1MDRoYmpraFBSdUpkYlduM1VM?=
 =?utf-8?B?NCt3ZVdEVDNZYkE3KzBqdFlzOHVBck5GaVdPcEFuVlEyTThXNldOUkJvZkZY?=
 =?utf-8?B?ZHlWWkIzMHFRWmRLeTFhdjBXdUlkVVJtYW9FMGtwZGlRRjZxSGJCT3FlVjdu?=
 =?utf-8?B?UFBYZzFVRzE4UUFEL1Z6bGFHQllXaDZ2ZE1DdG9Gbnhybm90ZGhBUkZUUXdH?=
 =?utf-8?B?UUY0TDZnRFhzQWFOYnNDMEdnTDVnbkJKZytBWFozT0JlQU1OQXBtUWFodVRP?=
 =?utf-8?B?REZ0Z0d6NVFKcThXZ2Frd2d5VzJESjQ5VUo1QUJwU0duMkN4SEQybFVqb1dB?=
 =?utf-8?B?L0F1Tk01dFkvQzNCZDJna0RxLzZDS3IxL2VDMXZNcEcvZDZHbDZhRUNiYjNO?=
 =?utf-8?B?dENXdHI5V25pRWdUTlBJVDU0R05QL3FLV3R3ZWdORXludnBnT1Q5M2MvaHZt?=
 =?utf-8?B?Q0dyTmFaZkJvOVlrY01zTFFnOEdRRklCTEVaTlRFMXlXdDFFdkdKeWFsekZ4?=
 =?utf-8?B?aFdUaitqUVI1UjFYUWRTR1oxVGtYb0E2YjBPTktGOG5UaDczYkVWbm8yRVl1?=
 =?utf-8?B?WCthR2FWMkFoN2IwbHllL0RJUG95bGM4MWRMcjdpNkx6OTZLWE5SeEU1N2pF?=
 =?utf-8?B?SkxtV1dOK3pOV3E4bUp3K2NZYWtqbDI3ZDZMdXhYQ051Y1puQkRCM1AyQTEr?=
 =?utf-8?B?WHhLWlBUOWRnR21SbTh4d0hpYWZmajZxcXFVSWpUMXhRWmZxSGtVZWcwS0Z0?=
 =?utf-8?B?NG1pWHNsUFJUNnMvTFI1UHFCdWlPZUFMa2NBOFJPcFRKS0FCOC80eFIwOUFE?=
 =?utf-8?B?ZFJmc3BBRDY4V1pQVnhwNEJPMzVOMUVZYjB5N2tkbUErR3EyeTcxUTRyY3Fq?=
 =?utf-8?B?a0o5WCtmSnZ5ZWJEMUtzOTE5Y3NNUFE4SnFRVzZpNWI4cGVldTFmcVNPUmpB?=
 =?utf-8?Q?oavjLQjmhVNbljyRgpp++NI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74b98c14-aa96-463e-919c-08d99ee9a5ce
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 16:47:39.6642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EEkYWOdAU17rADuOkKUvrYnUs4E2350FVh75o/aAzaGmhJBK47uZQq0kM4MMbEnHEZ9iBlaLjjRJrj34QeuSZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8119
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29/10/2021 23:55, Charles Mirabile wrote:
> This patch implements control of the 8x8 RGB LED matrix display.
> 
> Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
> Signed-off-by: Mwesigwa Guma <mguma@redhat.com>
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> ---
>   drivers/auxdisplay/Kconfig            |   7 +
>   drivers/auxdisplay/Makefile           |   1 +
>   drivers/auxdisplay/sensehat-display.c | 258 ++++++++++++++++++++++++++
>   3 files changed, 266 insertions(+)
>   create mode 100644 drivers/auxdisplay/sensehat-display.c
> 
[....]
> diff --git a/drivers/auxdisplay/sensehat-display.c b/drivers/auxdisplay/sensehat-display.c
> new file mode 100644
> index 000000000000..5980ad23fd4f
> --- /dev/null
> +++ b/drivers/auxdisplay/sensehat-display.c
[...]
> +
> +static ssize_t
> +sensehat_display_write(struct file *filp, const char __user *buf, size_t count, loff_t *f_pos)
> +{
> +	struct sensehat *sensehat = container_of(filp->private_data, struct sensehat, display.mdev);
> +	struct sensehat_display *sensehat_display = &sensehat->display;
> +	u8 temp[VMEM_SIZE];
> +
> +	if (*f_pos >= VMEM_SIZE)
> +		return -EFBIG;
> +	if (*f_pos + count > VMEM_SIZE)
> +		count = VMEM_SIZE - *f_pos;
> +	if (copy_from_user(temp, buf, count))
> +		return -EFAULT;
> +	if (mutex_lock_interruptible(&sensehat_display->rw_mtx))
> +		return -ERESTARTSYS;
> +	memcpy(sensehat_display->vmem + *f_pos, temp, count);

So we copy from buf into temp, from temp into vmem and then we 'transform' vmem 
into the representation of pixel_data.

As you are implementing the user-space interface, couldn't we just change the 
pixel representation there and get rid of the transformation?

> +	sensehat_update_display(sensehat);
> +	*f_pos += count;
> +	mutex_unlock(&sensehat_display->rw_mtx);
> +	return count;
> +}
> +
> +static long sensehat_display_ioctl(struct file *filp, unsigned int cmd,
> +			     unsigned long arg)
> +{
> +	struct sensehat *sensehat = container_of(filp->private_data, struct sensehat, display.mdev);
> +	struct sensehat_display *sensehat_display = &sensehat->display;
> +	void __user *user_ptr = (void __user *)arg;
> +	u8 temp[GAMMA_SIZE];
> +	int ret;
> +
> +	if (mutex_lock_interruptible(&sensehat_display->rw_mtx))
> +		return -ERESTARTSYS;
> +	switch (cmd) {
> +	case SENSEDISP_IOGET_GAMMA:
> +		if (copy_to_user(user_ptr, sensehat_display->gamma, GAMMA_SIZE)) {
> +			ret = -EFAULT;
> +			goto out_unlock;
> +		}
> +		ret = 0;
> +		goto out_unlock;
> +	case SENSEDISP_IOSET_GAMMA:
> +		if (copy_from_user(temp, user_ptr, GAMMA_SIZE)) {
> +			ret = -EFAULT;
> +			goto out_unlock;
> +		}
> +		ret = 0;
> +		goto out_update;

That's just a 'break;' correct?

Regards,
Matthias