Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp643443pxb; Wed, 3 Nov 2021 09:56:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzo8BwXsTmKOtCiVgJEBojgkYftLQWbsFFlaZWYw4tRfyMtBHEnebactWc7KGq/msIQyxcy X-Received: by 2002:a17:906:fcc8:: with SMTP id qx8mr13397726ejb.370.1635958604530; Wed, 03 Nov 2021 09:56:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635958604; cv=none; d=google.com; s=arc-20160816; b=pEqrdyX9cG+UdPcNIvOj0UQ+mPOLwAfQ3yKLUgh4gSO3KG5c+UeLwYMZPmOeFisuHZ F0qWD1EF6UEOZmVhcETREzUPJ+Oa6eyH3ED0GpXTX580zJDgpQLzCVR3cLWOpJJpassb 8fl7MBG6fMhjU/R0Pzkwc7UQyR319dpynY1mIvJkylmvlbMOyI22arUTgkmk/hIl+w/e iJwsOHR5NuNsd+Fnu3HC4pm1gXmrVnFwCdugBwlObxOW15XcPImtaWJWEgi9yEOD+2hX eXnK6DEKKqWFTx2ZhqUCGkowd42lOBFWInzCi2cWqhuj8qaZ5U6sq4t2dki7m+bLJ+Pl EeFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ySf8hnRGgcGBFPw1OqHjYfFXWjAWp6d1U3iHxpW19Ys=; b=XiPEgGwk5BN9y1kPzOjpaob2OfbhxLgCi7tp5r0iFtSD/20KT+zBQW7SG8WLhN04A4 RmH430B+ifHHEHY2gtsMKSAyajUs3/y/oqd/WJLL/kicHXGe90bJfpdz/M4IbWCoXn+r jrECCyDM1HaHsk+vIDJsSu+H0z7fZUHRkx2gCtrlF/dCMOTTRAYBc5NCG0mh04fKrDqF AxMBifQY+P3h9Ie9EJoDpKzsP/3APX2Qf51wp+IhO7eGSOK9JcFzvZqSd3JG3/Zz50Qs ulqUqIcYGCeiKkaU5Fw1/j3R2eiq1qxMz5hCvN0jR3reMYxBMnd3w1bPlHBsnHAF4eoO E2Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ldSzTLqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si3856382edq.114.2021.11.03.09.56.21; Wed, 03 Nov 2021 09:56:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ldSzTLqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233022AbhKCQ41 (ORCPT + 99 others); Wed, 3 Nov 2021 12:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233019AbhKCQ40 (ORCPT ); Wed, 3 Nov 2021 12:56:26 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F839C061714; Wed, 3 Nov 2021 09:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ySf8hnRGgcGBFPw1OqHjYfFXWjAWp6d1U3iHxpW19Ys=; b=ldSzTLqtpw/28nPKVoQb8qdoIl adNO9XYwY4XgBBEak4LtLCfJawj4TSHN1Zs1ixHSOgc9FVO2phfzsIPyw7GhYQHx9Ip/VTlSKHepv 9JoeYyoxUB8qpgUiLTH+CFDqvflsyuoCMgCWDQpoOgmRvESUSiaGVSm90mSXGWiG0rQrXPd6eq2n/ WS0RM0xU89huiOSx4wU5D5N+09BOBbDCOjPyDYyOQOMcTnikykET90sbRn+DNK8WXwWQDTswR1iTL RUddkojWuOMhQTYIT33jxUp03PILjo25IBZW8Nj6+xtkJ2LboKVAHqbZyfpfKgaj83OHbb/24fWJM 1v8+APyA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1miJVt-005rED-HI; Wed, 03 Nov 2021 16:53:25 +0000 Date: Wed, 3 Nov 2021 09:53:25 -0700 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Jane Chu , "david@fromorbit.com" , "djwong@kernel.org" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "ira.weiny@intel.com" , "willy@infradead.org" , "vgoyal@redhat.com" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [dm-devel] [PATCH 0/6] dax poison recovery with RWF_RECOVERY_DATA flag Message-ID: References: <20211021001059.438843-1-jane.chu@oracle.com> <2102a2e6-c543-2557-28a2-8b0bdc470855@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 02, 2021 at 09:03:55AM -0700, Dan Williams wrote: > > why devices are built to handle them. It is just the Intel-style > > pmem interface to handle them which is completely broken. > > No, any media can report checksum / parity errors. NVME also seems to > do a poor job with multi-bit ECC errors consumed from DRAM. There is > nothing "pmem" or "Intel" specific here. If you do get data corruption from NVMe (which yes can happen despite the typical very good UBER rate) you just write over it again. You don't need to magically whack the underlying device. Same for hard drives. > > Well, my point is doing recovery from bit errors is by definition not > > the fast path. Which is why I'd rather keep it away from the pmem > > read/write fast path, which also happens to be the (much more important) > > non-pmem read/write path. > > I would expect this interface to be useful outside of pmem as a > "failfast" or "try harder to recover" flag for reading over media > errors. Maybe we need to sit down and define useful semantics then? The problem on the write side isn't really that the behavior with the flag is undefined, it is more that writes without the flag have horrible semantics if they don't just clear the error.