Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030308AbXAEJDw (ORCPT ); Fri, 5 Jan 2007 04:03:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030371AbXAEJDw (ORCPT ); Fri, 5 Jan 2007 04:03:52 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:39343 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030308AbXAEJDu (ORCPT ); Fri, 5 Jan 2007 04:03:50 -0500 Date: Fri, 5 Jan 2007 14:33:47 +0530 From: Srivatsa Vaddagiri To: Andrew Morton Cc: Oleg Nesterov , David Howells , Christoph Hellwig , Ingo Molnar , Linus Torvalds , linux-kernel@vger.kernel.org, Gautham shenoy Subject: Re: [PATCH, RFC] reimplement flush_workqueue() Message-ID: <20070105090347.GC18088@in.ibm.com> Reply-To: vatsa@in.ibm.com References: <20061217223416.GA6872@tv-sign.ru> <20061218162701.a3b5bfda.akpm@osdl.org> <20061219004319.GA821@tv-sign.ru> <20070104113214.GA30377@in.ibm.com> <20070104142936.GA179@tv-sign.ru> <20070104091850.c1feee76.akpm@osdl.org> <20070104180901.GA344@tv-sign.ru> <20070104103107.e33768d7.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070104103107.e33768d7.akpm@osdl.org> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 629 Lines: 21 On Thu, Jan 04, 2007 at 10:31:07AM -0800, Andrew Morton wrote: > But before we do much more of this we should have a wrapper. Umm > > static inline void block_cpu_hotplug(void) > { > preempt_disable(); > } Nack. This will only block cpu down, not cpu_up and hence is a misnomer. I would be vary of ignoring cpu_up events totally in writing hotplug safe code. -- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/