Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp692121pxb; Wed, 3 Nov 2021 10:44:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztpgKX1/cZp/OT3mx4uPlTazFrIQT0uexqPWLkG1ivuSi/YzDo6k86ZuZFv2lAqJ6KvvHI X-Received: by 2002:a17:906:b794:: with SMTP id dt20mr42014446ejb.371.1635961452135; Wed, 03 Nov 2021 10:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635961452; cv=none; d=google.com; s=arc-20160816; b=WRomWb5NfVdSNA7YguXBQ8UpkvkWdvQO6Mgi0fD8WlB1IOY1YviZ23WnltqOsj0YDX q12s4apIqOIcPGOMNTxnzxUTktrNkKzoLwAXq5q9GrMABjlDgFYdxOLvIxN2Qm2fkMnq MH/PmzUhP0pVVrmCb+b/EFyC4Plk2s2LZV1bkyFJDFYMigEVOlRjdA6YR+lZUOd8VvgB 00gc09UZE84m9U9RdIvBtoB/XZvz6D78m6hiuQ4+8iTFapdvxG7ps49ax62kRkih12Zq zG5rhD48kMdyZobqWvRIf3gYLCnbsuuFfqKMgrylmzEQaee1Yl3AHPV5vzNU0n8khfmN hbHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=8w2VytewPeRX4QkQuUg/BDVtpcxVWCV69c3Z6Wv2sj4=; b=uwmF+4d5JAoj3rEkD9UqpFyED2Dy+mqogCr7RteJ23WxRH8LrxWl+56g2qz1TdWrYq qJkkIePom95/tL6pwNv2bsi4ztN/6QYKwZuHr9VzXbUG4HjhLFb/loZOTdyxcFLWgQHc 1OvSVVP8wJ14L+bNqy1LQEvqPeO+PwMTND1N63F3WrWM+qhbqIpcMBon9RV8GNebAQag w2dB2kqyq5QkSMuXikjNrLyVTg47hHmidtxJr5rZbGycYN4QH0RzqSBh111YpMUxqKIw mKGmaDnqZ2CTJGpHTAmypwEihSSlbAn9eZA2qFYLw1ZvMdwMao+LGdA9iwrMlw3zSVT1 2PEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=kWIx5CS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kz10si3844382ejc.582.2021.11.03.10.43.49; Wed, 03 Nov 2021 10:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=kWIx5CS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbhKCRl4 (ORCPT + 99 others); Wed, 3 Nov 2021 13:41:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbhKCRly (ORCPT ); Wed, 3 Nov 2021 13:41:54 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD9FEC061203 for ; Wed, 3 Nov 2021 10:39:17 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 17so5232944ljq.0 for ; Wed, 03 Nov 2021 10:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8w2VytewPeRX4QkQuUg/BDVtpcxVWCV69c3Z6Wv2sj4=; b=kWIx5CS8nvY10TsruGTm4C3fKrM9wXsuvooi2CRs+RYshqzqTzNF0+zH+R36YM1KlG SXfOVbgb6TD5u3JxH7olKllrHzG6It7/DWNDjtiH6i7IGeC8VO26drKULHHoTboLtZqr qt6acogm5Cw/YIO1D0fm+BHOtNKGbrIkhMajJNiNOM0CHv3OUXeA/JAyXansys5U55At D5CyNObB1Mxv4G39O+PuDZVtGKecvzxA0M5Hd3/Weo/TEztQZP5T57VuPaX/aGBBGdHw VMOGod5Y4HRwZSVvrWpcFL9AePxL6Vmq4JCuYYm2vgg9x9JX2Ecxpqz7znCnzZDjLfYT QOEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8w2VytewPeRX4QkQuUg/BDVtpcxVWCV69c3Z6Wv2sj4=; b=fInmS/GhF+H5yn2A6Ezhb7Gpr78GiII7/elJOSFnfPpAgtxIucAr8j3nyO6F5p9HGo Nistt+xjL0+mYvQOyqwhsZ4dRtWXw2w3xGug9VugFmo/V17AksBCvvjSIYo8xe05Z4XD 7axAy/0grLEckNlNUNReb5pbxafHf8FdK9Rue/LRjOIEhPn16hifIFjJddHh5SWjOzzb dmTO14KTMsEaMKxpVYAlA7CBAklL9lrE7gDK0Fv3LP7FcrUVqVXqff+pnGAu7qbfRLr0 +4QpxXyDJbg5wBoZrwyobEK0Y8jyaT9Ei5PitmkW0dbSbgi5PrzJ+Rs+AvV1QFgBf2/u lCAA== X-Gm-Message-State: AOAM5339v00l6mHpq3jqHy4902yrevWNgkweVY7f8AdC3JOVYneO9E1J Cw8xDj6NFaGN3nE9AJ+WneODEN0u19EFOr1hhz43M8WTSRU= X-Received: by 2002:a05:651c:551:: with SMTP id q17mr18274510ljp.202.1635961155911; Wed, 03 Nov 2021 10:39:15 -0700 (PDT) MIME-Version: 1.0 References: <20211103165845.38226-1-mkoutny@suse.com> In-Reply-To: <20211103165845.38226-1-mkoutny@suse.com> From: Shakeel Butt Date: Wed, 3 Nov 2021 10:39:04 -0700 Message-ID: Subject: Re: [PATCH] cgroup: rstat: Mark benign data race to silence KCSAN To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: cgroups@vger.kernel.org, Johannes Weiner , Li Zefan , Tejun Heo , Hao Sun , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 3, 2021 at 9:59 AM Michal Koutn=C3=BD wrote: > > There is a race between updaters and flushers (flush can possibly miss > the latest update(s)). This is expected as explained in > cgroup_rstat_updated() comment, add also machine readable annotation so > that KCSAN results aren't noisy. > > Reported-by: Hao Sun > Link: https://lore.kernel.org/r/CACkBjsbPVdkub=3De-E-p1WBOLxS515ith-53SFd= mFHWV_QMo40w@mail.gmail.com > Suggested-by: Hao Sun > > Signed-off-by: Michal Koutn=C3=BD Reviewed-by: Shakeel Butt