Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp730372pxb; Wed, 3 Nov 2021 11:22:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuW9XEcWO37l4vvB9+dAbduBWKoB0Wc2OmdIs9/9gWwDFpH0miZCra7s+4ZFSu0asedTC9 X-Received: by 2002:a02:c49a:: with SMTP id t26mr62384jam.121.1635963747302; Wed, 03 Nov 2021 11:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635963747; cv=none; d=google.com; s=arc-20160816; b=D3MPgTpuvdfJ9QCWXh57kZt2uaJK822CeEha7rsFI92pZF+ZY9H/5eKv9PuBzelKNa CGtk2FF3AkRiLfp05eHHuhW+7TAhqZFK0Syv9amYZndjSnRtXEFFZ1QUDL0Au6ikEO1k DV6GSraftm3PxdG61Bgvo399WqNJdnLdxAJVnrBbVrUeX7LRS2EvKgkqUgbESNi1REPp iCZwVk/l76DTymjpN2EanVMP1/Ob9M2oExueteCmaTAFq0FrwhTqSNSwCtaSebOJT5lz FQSgG34WKP4ksTTsiSDHoZxe4pYn5Z0K+OmFRyhGSv7Fnz5ipfUII51zPkdpwIybAO1i 0c2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=11vKg57Njp5/2Imt+4jz+GIDckX5ZnDow2+XYpvIoTo=; b=QFQrx/rGe8h4kYRce4VdRABLWN/vnoMiHEJytirw4X9Y2TZXQzP0J1WJ3tRmSkzu7z 1Rw6CVDH+1Nf9ba1YNKgVg+Uc2qrTrv7FrsbT6zeXEtAn3UgCWmg+/J+LucH0QG34xsM RzKp0jR7LvO3WPHkd+SkfYHsrsExZCeTC21AgoBRsBhZVDzFi2YNaHPguS/XINfyylf3 6O0VgZw/LNVAUsjU2qAxjaC4e2ahy+YKsm9qDQhDJ6S5Ip1HjVoI6bcl4Uc9xo97/haP uUqoI2z9jlZS3kEs0HWp1lfCZMvnEdFXc7P4Y3zddHpMRzgVT9/Jmc76hdlTQcdT12PY WLjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si4889890ilv.35.2021.11.03.11.22.15; Wed, 03 Nov 2021 11:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhKCSXu (ORCPT + 99 others); Wed, 3 Nov 2021 14:23:50 -0400 Received: from verein.lst.de ([213.95.11.211]:60792 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbhKCSXs (ORCPT ); Wed, 3 Nov 2021 14:23:48 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6319F68AA6; Wed, 3 Nov 2021 19:21:09 +0100 (CET) Date: Wed, 3 Nov 2021 19:21:09 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hch@lst.de, penguin-kernel@i-love.sakura.ne.jp, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com, efremov@linux.com, song@kernel.org, martin.petersen@oracle.com, hare@suse.de, jack@suse.cz, ming.lei@redhat.com, tj@kernel.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/4] ataflop: address add_disk() error handling on probe Message-ID: <20211103182109.GE7745@lst.de> References: <20211103181258.1462704-1-mcgrof@kernel.org> <20211103181258.1462704-3-mcgrof@kernel.org> <20211103182016.GB7745@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211103182016.GB7745@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Or maybe I should stop nitpicking for these cruft drivers. I'm ok with this and the next patch: Reviewed-by: Christoph Hellwig