Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp787047pxb; Wed, 3 Nov 2021 12:22:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6i7nUGXbzxEkEaw3mhKvRD15KZjF/ryCnxm/fF5rUgKdSKGu2U66cb9KLQoVHYxkajPpj X-Received: by 2002:a05:6402:289f:: with SMTP id eg31mr32693650edb.192.1635967345345; Wed, 03 Nov 2021 12:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635967345; cv=none; d=google.com; s=arc-20160816; b=dBye/2M/eEhoYiaB596TEgr8De3SZraipRNit7GrBGCOny8Ipdlrf3U+OYIswPtYPy b1OxMv3vR1MIGhS5xjyO9wQcsH5lOiMZihK+6asg3HIf1GtRLJw5Icg7P5IR17n+ruq3 9Hg5RaFM4NZihar8zU5UOU8xaruX3BciAuBKTYIWCCaJKptB2axHEvl+0wCJC5/0tKLg KJRQglqI0CcNNSLfwmzei/LBgvdV06lD7fRDlTe7P67Y1QWUbmYwUVOmZbSTGIv6fe6Y pXnyk3I4NcMGiluoM+ogFxq1z56xKCPiCkspo/qUGNpeh93vKK8EzLD0OQsdrmDo1i3o STqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1Iu08SoRTNCEQ47Cus2ClCFoXZXiJnOw4ySFu+g0PR4=; b=u5UfEUQecB5NJNOHFoqtvxw1oyHwvGPHtu1eJ+uEYfbPWky9dHhkywpXBwfUk1yrXl bLIBrjLqKhCWazi57B4M6ST+M+0vZM3W23d3pY/MDt/DbFU/jGM2gIZinkRl2jmLO26e gdsrizXT/7nzfEwXGFi1uL4i+RHrBkRFf9Tk9xq/dcggA/UfbqbHCE1UYREnwbzU8Lqy f9TTjFieHiLUJ3V0QNi9YVvcleNeTZMJIGvAx4ct6eWbj3MAzeh6Wr4hL8YVCOlYADe3 AnAathaXDXFWnGXV9bqvQUQCcY62fHFE4W7DQvBWLJXnOJA7bYKLLNwYEzx1FaliSYXI 4CJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ho36si5087017ejc.607.2021.11.03.12.22.01; Wed, 03 Nov 2021 12:22:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbhKCTWJ (ORCPT + 99 others); Wed, 3 Nov 2021 15:22:09 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:65394 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhKCTWI (ORCPT ); Wed, 3 Nov 2021 15:22:08 -0400 Received: from pop-os.home ([86.243.171.122]) by smtp.orange.fr with ESMTPA id iLnEmtQIGUGqliLnEms32M; Wed, 03 Nov 2021 20:19:29 +0100 X-ME-Helo: pop-os.home X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Wed, 03 Nov 2021 20:19:29 +0100 X-ME-IP: 86.243.171.122 From: Christophe JAILLET To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, yang.lee@linux.alibaba.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] ASoC: codecs: Axe some dead code in 'wcd_mbhc_adc_hs_rem_irq()' Date: Wed, 3 Nov 2021 20:19:27 +0100 Message-Id: <57a89cc31eb2312addd3c77896d7df8206aef138.1635967035.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'hphpa_on' is know to be false, so this is just dead code that should be removed. Suggested-by: Srinivas Kandagatla Signed-off-by: Christophe JAILLET --- This patch is a follow-up of: https://lore.kernel.org/kernel-janitors/988948f7f266aa00698704687537335b7e6a67b2.1634455711.git.christophe.jaillet@wanadoo.fr/ --- sound/soc/codecs/wcd-mbhc-v2.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 405128ccb4b0..b905eb8f3c67 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -1176,7 +1176,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data) struct wcd_mbhc *mbhc = data; unsigned long timeout; int adc_threshold, output_mv, retry = 0; - bool hphpa_on = false; mutex_lock(&mbhc->lock); timeout = jiffies + msecs_to_jiffies(WCD_FAKE_REMOVAL_MIN_PERIOD_MS); @@ -1210,10 +1209,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data) wcd_mbhc_elec_hs_report_unplug(mbhc); wcd_mbhc_write_field(mbhc, WCD_MBHC_BTN_ISRC_CTL, 0); - if (hphpa_on) { - hphpa_on = false; - wcd_mbhc_write_field(mbhc, WCD_MBHC_HPH_PA_EN, 3); - } exit: mutex_unlock(&mbhc->lock); return IRQ_HANDLED; -- 2.30.2