Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jens Axboe <axboe@kernel.dk>
To:     Luis Chamberlain <mcgrof@kernel.org>, hare@suse.de,
        hch@infradead.org
Cc:     linux-block@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        kernel test robot <lkp@intel.com>,
        linux-kernel@vger.kernel.org
In-Reply-To: <20211103164023.1384821-1-mcgrof@kernel.org>
References: <20211103164023.1384821-1-mcgrof@kernel.org>
Subject: Re: [PATCH] block: fix device_add_disk() kobject_create_and_add() error handling
Message-Id: <163596772995.186346.6961527014377680159.b4-ty@kernel.dk>
Date:   Wed, 03 Nov 2021 13:28:49 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 3 Nov 2021 09:40:23 -0700, Luis Chamberlain wrote:
> Commit 83cbce957446 ("block: add error handling for device_add_disk /
> add_disk") added error handling to device_add_disk(), however the goto
> label for the kobject_create_and_add() failure did not set the return
> value correctly, and so we can end up in a situation where
> kobject_create_and_add() fails but we report success.
> 
> 
> [...]

Applied, thanks!

[1/1] block: fix device_add_disk() kobject_create_and_add() error handling
      commit: 3554ce121f632db1f56f4e28dfe37da846617c9c

Best regards,
-- 
Jens Axboe