Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211103122441.3208576-1-alexander.stein@ew.tq-group.com>
In-Reply-To: <20211103122441.3208576-1-alexander.stein@ew.tq-group.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Wed, 3 Nov 2021 22:13:28 +0100
Message-ID: <CAFBinCCMKk-dKvVuhLyoNLkK_D-kYbv99c5-w6C2gKXd53e5Aw@mail.gmail.com>
Subject: Re: [PATCH 1/1] clk: composite: Fix 'switching' to same clock
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alex Bee <knaerzche@gmail.com>, Chen-Yu Tsai <wens@csie.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alexander,

On Wed, Nov 3, 2021 at 1:24 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> During commit 6594988fd625 ("clk: composite: Use rate_ops.determine_rate
> when also a mux is available") setting req->best_parent_hw got lost,
> so best_parent_hw stays NULL during switch to the same parent. This
> results in the (debug) message:
>   clk_calc_new_rates: lcdif_pixel not gated but wants to reparent
> and the following rate change is dropped.
Thanks for investigating and fixing this!

note to myself: only clocks with CLK_SET_RATE_NO_REPARENT are affected.
This might be the reason why it wasn't spotted on Rockchip SoCs (yet).
I have Cc'ed Alex and Chen-Yu in case they're investigating breakage
on Rockchip SoCs with linux-next

> Fixes: 6594988fd625 ("clk: composite: Use rate_ops.determine_rate when also a mux is available")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Best regards,
Martin