Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1369-gd055fb5e7c-fm-20211018.002-gd055fb5e
Mime-Version: 1.0
Message-Id: <107f229e-9060-49f2-bc4b-c12e2d0c1b59@www.fastmail.com>
In-Reply-To: <20211103190426.1511507-1-tyhicks@linux.microsoft.com>
References: <20211103190426.1511507-1-tyhicks@linux.microsoft.com>
Date:   Thu, 04 Nov 2021 07:58:33 +1000
From:   Alistair <alistair@alistair23.me>
To:     "Tyler Hicks" <tyhicks@linux.microsoft.com>,
        "Lee Jones" <lee.jones@linaro.org>
Cc:     "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core
 dependency
Content-Type: text/plain
Precedence: bulk

On Thu, Nov 4, 2021, at 5:04 AM, Tyler Hicks wrote:
> Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that
> simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following
> linker error:
> 
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices'
> make: *** [Makefile:1187: vmlinux] Error 1
> 
> Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells")
> Cc: stable@vger.kernel.org # 5.15.x
> Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>

Reviewed-by: Alistair Francis <alistair@alistair23.me>

Alistair

> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index ca0edab91aeb..d2f345245538 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1194,6 +1194,7 @@ config MFD_SI476X_CORE
> config MFD_SIMPLE_MFD_I2C
> tristate
> depends on I2C
> + select MFD_CORE
> select REGMAP_I2C
> help
>   This driver creates a single register map with the intention for it
> -- 
> 2.25.1
> 
>