Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1055162pxb; Wed, 3 Nov 2021 17:31:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg5uLs2NcPM4MnIsmkNh8mGdt+rp6z5/fQko80m/SrkIFjmeTT2J9zA694AmVh25atX187 X-Received: by 2002:a05:6602:1614:: with SMTP id x20mr5994059iow.71.1635985902485; Wed, 03 Nov 2021 17:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635985902; cv=none; d=google.com; s=arc-20160816; b=rcHdh4bn4UjPPgCcIuYH9OsMkzE4y56o1gyrGiZQX0PCS0ieJf9sahCwWJutzfKFIU iLs3vkWH5CXkPDzASXMRDcoCWKwxmG6CZQm2FXUmFH3N9Fs5Hj2bJBVZrs8C5DLTqmUC 5d8kQNSI2dVi9BwUsc9OAkNuCsrHrZ8p0hydx6LKvUTRVMENtcT2MjIBL9rDAhLW+b75 7xSmmkKDVTtlgyZU3I9387lfy1ceS7vcIMuHhRq6CPdhmkeDwZMtZmEEcAt/lkNXcKrT dWQxNSlA4ZUFsfI9iZn8OiP90H38ra1QbxnvdcCUW/hOuPqVHe6bQzPTXT27VKYFrfcP nz6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:dkim-signature; bh=uYjj4f3K7aLt9wIaWKUjF6y1lKdICOYwfejCWHB3aF8=; b=CkmI4Xe+yE7RzYE+b0X1xdzXj73TgR8TvkJTnLVO5BOK1lNzTn9ONGz1KQjbRCqQDc 9RwNkd9Gx8oH6Ied3oI75KUuaLAGYv2961QNL+lKu6Mq0sjW1LN4Tsad+lQtn71Okt6A v+wbUs74Ij5dIAqssFaLAk0zR2rjmIkpcyCihUsjas3sn0/qgSBKDgMuOjCVFfueLQbD lvalqmrs7HqefJhghn2Quqmp3KO3lWKHer/qw0gIqydTa9/8yrMDKiLFFru8rrQgznt+ 6QjlAzlt9VHPgux1ZhMDdo0dLYmCeFXUOdqZlItwdcNIioMMYuBREDXE2GUQhXQ5t0/h kAqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Uhm3v8WN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e2si4416075iov.23.2021.11.03.17.31.29; Wed, 03 Nov 2021 17:31:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Uhm3v8WN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233608AbhKDAbe (ORCPT + 99 others); Wed, 3 Nov 2021 20:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbhKDA3I (ORCPT ); Wed, 3 Nov 2021 20:29:08 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A908C06127A for ; Wed, 3 Nov 2021 17:26:31 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id x5-20020a1709028ec500b0013a347b89e4so1953231plo.3 for ; Wed, 03 Nov 2021 17:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=uYjj4f3K7aLt9wIaWKUjF6y1lKdICOYwfejCWHB3aF8=; b=Uhm3v8WNND1uUP79qkh3iF9ngMS/QpmsXEC/6vevUuzviyfyF3+tSzE2rdmLrNYnov ivEPHlTaSTgUBPTTi0LsyRVmw9xXp2mzAafjmpRwoFL1KovVk8wtgK3U+1IWl+jiRT2o 7QOXBMeLcoMyFIuk8nfYq8Z4cK4ySxLX4VQvCwivT4uBC8D1531XJeoZcVX+WcQdgv/2 15XpbR3gJyAolfjM0WcGNgJS3ceK1iyuvg9S+WhHGJq+B2HdNn7lGmW8IZ2NF2RpaP0n 2NlCasOBpN6Ngo/ODMi6fT9lbV6fzIJZALi7PZVoZsnpUFpAWoSzDGNfxoR0u+D8gkJP KhsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=uYjj4f3K7aLt9wIaWKUjF6y1lKdICOYwfejCWHB3aF8=; b=QCZo+pu1PkSQQqtHJOhosO0EAr9H/rtiz60gQo/9FSv1l+gaDlJx1OxBvOwcyrb7v7 jXkMLDWz1fwOJyDnlSlxmaoPQk243J+wEsctMf6+/LMmHCM+f8HcagFnT00q4UVMOgpC WpLh0YU66NQH98Ti7N0aBQGvXTzGOopG2AI4JQuPNOXjEeRVJVtpq4yrTuvfLifd4SKy UaejlpcSVtWjJ3k7vachOO6rbi3SBGrMP53hUzzSflX/OoonlTQnVnxxPBkzvv7oqs36 1R3gPQGYRtyydU6RKz+/m7GRwM3Du8B0y0gPVuG/tMAp0nuKNsdqefaQRdDxci3iZNbt zXUA== X-Gm-Message-State: AOAM532mApb02mlSdZl2PIrz5BgfFgy7GY0GS58GV8uXh6JVJqjLt0GW IVMqYrk59B5jSourCPT8q73vGkDwUPM= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a05:6a00:1511:b0:492:61fe:9fa6 with SMTP id q17-20020a056a00151100b0049261fe9fa6mr9114017pfu.57.1635985590891; Wed, 03 Nov 2021 17:26:30 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 4 Nov 2021 00:25:20 +0000 In-Reply-To: <20211104002531.1176691-1-seanjc@google.com> Message-Id: <20211104002531.1176691-20-seanjc@google.com> Mime-Version: 1.0 References: <20211104002531.1176691-1-seanjc@google.com> X-Mailer: git-send-email 2.33.1.1089.g2158813163f-goog Subject: [PATCH v5.5 19/30] KVM: x86: Don't call kvm_mmu_change_mmu_pages() if the count hasn't changed From: Sean Christopherson To: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Paolo Bonzini Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Ben Gardon , "Maciej S . Szmigiero" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point in calling kvm_mmu_change_mmu_pages() for memslot operations that don't change the total page count, so do it just for KVM_MR_CREATE and KVM_MR_DELETE. Reviewed-by: Sean Christopherson Signed-off-by: Maciej S. Szmigiero Signed-off-by: Sean Christopherson --- arch/x86/kvm/x86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 80183f7eadeb..4b0cb7390902 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -11836,7 +11836,8 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, const struct kvm_memory_slot *new, enum kvm_mr_change change) { - if (!kvm->arch.n_requested_mmu_pages) + if (!kvm->arch.n_requested_mmu_pages && + (change == KVM_MR_CREATE || change == KVM_MR_DELETE)) kvm_mmu_change_mmu_pages(kvm, kvm_mmu_calculate_default_mmu_pages(kvm)); -- 2.33.1.1089.g2158813163f-goog