Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <8be3ee89-7fa9-4611-3fda-c152ca9fa444@quicinc.com>
Date:   Thu, 4 Nov 2021 09:54:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to
 YAML format
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <collinsd@codeaurora.org>, <subbaram@codeaurora.org>
References: <1635836275-8873-1-git-send-email-quic_fenglinw@quicinc.com>
 <YYMLKCspjdyaKWUK@ripper>
From:   Fenglin Wu <quic_fenglinw@quicinc.com>
In-Reply-To: <YYMLKCspjdyaKWUK@ripper>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/11/4 6:20, Bjorn Andersson wrote:
> On Mon 01 Nov 23:57 PDT 2021, Fenglin Wu wrote:
> [..]
>> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>> new file mode 100644
>> index 0000000..05bb114
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>> @@ -0,0 +1,122 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/spmi/qcom,spmi-pmic-arb.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm SPMI PMIC Arbiter
>> +
>> +maintainers:
>> +  - Fenglin Wu <quic_fenglinw@quicinc.com>
>> +
>> +description: |
>> +  The SPMI PMIC Arbiter is found on Snapdragon chipsets. It is an SPMI
>> +  controller with wrapping arbitration logic to allow for multiple
>> +  on-chip devices to control a single SPMI master.
>> +
>> +  The PMIC Arbiter can also act as an interrupt controller, providing
>> +  interrupts to slave devices.
>> +
>> +  See Documentation/devicetree/bindings/spmi/spmi.yaml for the generic
>> +  SPMI controller binding requirements for child nodes.
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^qcom,spmi@.*"
> Node names should never contain "qcom,". Seems the agreed upon node
> named should be "spmi@.*".
>
> The rest looks like a reasonable conversion to me.
>
> [..]
Thanks, I will update it in patch V2.
>> +examples:
>> +  - |
>> +    qcom,spmi@fc4cf000 {
> Regards,
> Bjorn