Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xin Ji <xji@analogixsemi.com>
To:     a.hajda@samsung.com, narmstrong@baylibre.com,
        dan.carpenter@oracle.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        sam@ravnborg.org, pihsun@chromium.org, tzungbi@google.com,
        maxime@cerno.tech, drinkcat@google.com, hsinyi@chromium.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        bliang@analogixsemi.com, qwen@analogixsemi.com
Cc:     Xin Ji <xji@analogixsemi.com>
Subject: [PATCH v12 2/4] drm/bridge: anx7625: fix not correct return value
Date:   Thu,  4 Nov 2021 11:36:09 +0800
Message-Id: <20211104033609.2634452-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?II+LejYBx8TBAs+MRqI4ZABvGj4/oea9MB0MH900/l8os0n+2Cj63bgj/i6k?=
 =?us-ascii?Q?rT30C1dDQ1/+tq3DzWgfkpZjooTSPCZUKJ/IxGnn4SxDV+sKAV0FJ8PmN3+3?=
 =?us-ascii?Q?4ON9K9JzmHrcjo0A5p4GTF6aYzEzSMJHoT0qU4gKA4oQIXTj3WwhZoT5xkXz?=
 =?us-ascii?Q?IAQrkmqSvZnpGMmRtsmHX+nfyV5i7/JO90I6WXVectczB2Ns3IwC5hNvRxAQ?=
 =?us-ascii?Q?G/tEjbh5P9hpytGwAGAvnQsrey6837JfSqdv2c1BoEwxAhekG6xJcEmGoZW0?=
 =?us-ascii?Q?BNrHR9Hc0CQpIq8Tt/PBJYpac5EvkTGbxhwRgJcVIXL/RtC9xcFP5DTpYcmY?=
 =?us-ascii?Q?iywmw5v9UIyLjyIZKcNrLTPbbvnrdkzJq4vjScJk4RlvhpctZqRLg3sIKLow?=
 =?us-ascii?Q?+gxsWvU1JG+M0sgW7PLX1IxnTMJcOlfdq6BEUVHTQ6hxmZZFj6P9+eQ9jJ1u?=
 =?us-ascii?Q?ASAt3neRNv4je/j3pIl6yXnXGC0yLdCD/qkNSA5EwMtSiZKZa4rEr4HYCGfs?=
 =?us-ascii?Q?EKuC4+oJ4/OCv/HwEPKtlfVDhlQgIZwbDyu0sCcxOFWOcU2EVOKz9xa1ds/T?=
 =?us-ascii?Q?W+MB3TK4azcZHi3XZXo5GHqtaZfaZ6AH02Dn03xbCUzWFTdzQxPIivVdCHFW?=
 =?us-ascii?Q?BvS3w3e5opJzfL3HIfZN+r8n4/ygmy4WyTkzE1obpLh+ZQ4GA6Ka19BUdEvb?=
 =?us-ascii?Q?BnfDaiu3lKXznmcxk2eL3vNG9UlanByF+vBrL4Psollnz1k6Ygr03MwaQJ/L?=
 =?us-ascii?Q?OtrMiOKXUktDJclePH0kpcrUZcj0dflw6+ja+BVFchrkEWY6Knp4Ulp3TEQA?=
 =?us-ascii?Q?LsP4yUA0AIwyeCs35t8NQI4tm5aXPhG7hGfXfVBt3LAweAmwJo3uxJwLPthL?=
 =?us-ascii?Q?1beePZ02JVYJRcaOuFB4dAOC12FG1ohvV6Aiz6+HixnSwdlE3UmRvNvMK8f0?=
 =?us-ascii?Q?OZtlk1pZZ9ENCJD8RkvcZxXRrGKZ0WdC1rK4p33kC3MSSWzWeQ+oIxtjFyFO?=
 =?us-ascii?Q?wWIbX4w6pcYxG/CnMCSQeZ5a9uCcvZj9fq4oxnSnfwCQoDtDlMWAMOItl/0L?=
 =?us-ascii?Q?wfnThba9fbqSOFOEo70gdNfcvxO58UXSkhPrmCSqavOsxaYosLRV56qn64eu?=
 =?us-ascii?Q?957uqtbbfmM02ngyWMMjfJujMkPb9OhDZy/1cGRtYF483NbzBGTLlOSrBOq6?=
 =?us-ascii?Q?/K3aOCQh/FjnlcZlar8cqUTCHfOhf4rc5Zi54mbHa8a2JunZ7OMJPqbi0kyu?=
 =?us-ascii?Q?uoxrCQl3lj7/q/TMi8HXIaLVMONVpjoPTmH5zHav2OavJ1Hd0CQcR4v5ECtG?=
 =?us-ascii?Q?SkvZ74P07LOSAzacFivY+DOy+5H31rCKQM0LsjwKJ5Kc3SSuS8/Jl+8KNCg/?=
 =?us-ascii?Q?QDDzrnME1z61Q2CzePhBVPpc3/aBBKCtJVh1O5cN8/rsTxlK7J/PMTDb8kSN?=
 =?us-ascii?Q?dPM0+ovQ092C4e3jxFqAsUZiTsNH6e9PGEkcyjusahBj7fOvam8z0hfrfUMN?=
 =?us-ascii?Q?IT74DTKxuoUHw762UbowmCrkXxtWApKm3+/0TIP86uJ/MEEZzmH4g/0UWqmh?=
 =?us-ascii?Q?lP+NTteoaIKzCA4WOvN1aIwxAhKWYFy3TU7naBIwy5DReSGR96lOT3sEqvnF?=
 =?us-ascii?Q?nByT5ysiQXsQKE1WJAmraSs=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7fe66a4-c235-4002-b760-08d99f4442b1
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 03:36:17.6167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wPtRunVBlBdHbQ5jLZFhEE5zHNphlmCLaQRkK3FcVAf4ChokYXaf1ohYA9V3x8HL6Q2ULFkCMjdd5o3rLyM2Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4277
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At some time, the original code may return non zero value, force return 0
if operation finished.

Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index d0317651cd75..f48e91134c20 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -191,10 +191,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
 			       AP_AUX_CTRL_STATUS);
 	if (val < 0 || (val & 0x0F)) {
 		DRM_DEV_ERROR(dev, "aux status %02x\n", val);
-		val = -EIO;
+		return -EIO;
 	}
 
-	return val;
+	return 0;
 }
 
 static int anx7625_video_mute_control(struct anx7625_data *ctx,
-- 
2.25.1