Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1331600pxb; Wed, 3 Nov 2021 23:49:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygn9xqfIXfZP8833Z2A8mAtag2KdyaI2s/G9ASR5xmlLTB8zWZO+zdpHPFpIh8WcxemWaW X-Received: by 2002:a05:6638:1606:: with SMTP id x6mr2271253jas.17.1636008576602; Wed, 03 Nov 2021 23:49:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636008576; cv=none; d=google.com; s=arc-20160816; b=EObhknDFnVzDFDHZ7bfMS0sEKd7XB6cN1Uipy49mYLckxrCFWtosWZFQ+OM9tXMWbm ZwZD7Vo16ra+7nKr/j5SF3R14qQ56tNuJnaLEtFGMmWgVLpyae/cNp0LYiLkaTvomrUl F/xazdCLKCkfUod3AuGG2afLS6aenui03PTzlIi6SylKpbI4U2yI/XYsnOnEdIPMBbgk u7Tp1IQVDrfUKU7XdgHRMlgt5Iqq0dEReP1r69GXj7gPVJT3oV2thmE9gT2yE8hzxztb UEcAb6mFgRowd46rZFlmN2Vc9QG7BdVZdzvsTe/rLZ42OvLRi0cwuQzmaSsppp8LL5YO 9BRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=E7Lb39v8JgwIKFwWNwZqrpLx/viQ/ss7YEIY/nQme7w=; b=n4FR663yiLfJdK6ExWw+Xqp5AwTh44kflK1ToxQVro2m1CbtqhWn2Flkihe9XS/32y R8ilVCeycSCzyyYRPYa6310RXbRvniD1kj30VzxFJN1qcYZXSnVNj3cquJOf/g63937F cHJlhPv8xx/dsf6a9S8482fEqNbTIlE+QMN/gxSG2cRRxbTdG4GFVlliK/0fZMO1xiYS hzKJqOlCw+rfYvGZeq15BRuWHmL9727gTF0eMMrV4wBuVPhiiqllI/Z3QAJnTl1kbgHF ptpx0D3Z8iqp7cgzGeL1Ri99DTIIfP/5NwJ6G3DzGPQT0/AUbrZr3Nnh5bFI5WOETUFC 5Thg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gugSXww7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si500061jag.43.2021.11.03.23.49.23; Wed, 03 Nov 2021 23:49:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gugSXww7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbhKDGur (ORCPT + 99 others); Thu, 4 Nov 2021 02:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231253AbhKDGuF (ORCPT ); Thu, 4 Nov 2021 02:50:05 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC90C0432E5; Wed, 3 Nov 2021 23:45:50 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id f5so4583090pgc.12; Wed, 03 Nov 2021 23:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E7Lb39v8JgwIKFwWNwZqrpLx/viQ/ss7YEIY/nQme7w=; b=gugSXww73OmmqMpEsCtSDZM8HVRRBRxmWRe9oJkR23JO0J3vA1DTW4wgBsp0/lp/Zd TYAnDN89AYVcOS5zkTIyntZC6yqVJZ4eITwgNPGafaCZ4kO0maZisXQQBHu4rM5fFq1h i1+yDPEBfS8+ZDOR6NQhPmY79GH1EYiEcxt4F391CJiVvTLuCM8N5Ey0mw6xuvjN3aaw 6WIX0FPlEl0APw//zhtlbGxghcc7BeiLCyNaelxj8TQZKq2jAzn3QQmH/cl8UJZ//SY8 yapaQVfo1ieYYR4bgQ/c8Qr50oTaefS5OlNj+5HZHmM2vSUkago9Gs0LJLuEUFxX20wa RbEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E7Lb39v8JgwIKFwWNwZqrpLx/viQ/ss7YEIY/nQme7w=; b=soLPNQaJdoReX8ojCRN5Go/frIb58X2dGsMlUOmYNa75bNob3ZDbX6SxqzXQO6nFJD Iw2SygVNGmxFtnQIsUWaON9Ki+P2GHHZgchAOwGQGZ3hmAvc+pxF5KQh5ruMAUqBbMjz 75+J1z+OvwghaTdfCnK6Gaahve3aIuf0UKcMm2nQ+mDtlozpeszOW2UeclW+2ZUFoxQ3 1SjmX11TI2Vwih9cKsUG2ChfNbvAmFxSptWbrJURe+VT1FD3B4YBcLqlAvuhUMkEykqA xLn1mNSHKHtbH7ekDmzUSqVltpHUaMdBmEodqdnVOgipqxrG2ChaQ+jJVUlKQED7iIIm jhrA== X-Gm-Message-State: AOAM533/ri+jnzZgVPRndL1DvYI/CuuE4JnM9MduMHI7oegJMGFtlynA WntC4ExTCdKx8LCWp8r97ww= X-Received: by 2002:a05:6a00:b82:b0:494:63ab:d61b with SMTP id g2-20020a056a000b8200b0049463abd61bmr2073779pfj.30.1636008350589; Wed, 03 Nov 2021 23:45:50 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id d20sm4502359pfl.173.2021.11.03.23.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 23:45:50 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: luo.penghao@zte.com.cn To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, luo penghao , Zeal Robot Subject: [PATCH v2] loop: Remove duplicate assignments Date: Thu, 4 Nov 2021 06:45:46 +0000 Message-Id: <20211104064546.3074-1-luo.penghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: luo penghao The assignment and operation there will be overwritten later, so it should be deleted. The clang_analyzer complains as follows: drivers/block/loop.c:2330:2 warning: Value stored to 'err' is never read change in v2: Repair the sending email box Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers/block/loop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 1f91bd4..941b482 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2329,7 +2329,6 @@ static int loop_add(int i) goto out_free_dev; i = err; - err = -ENOMEM; lo->tag_set.ops = &loop_mq_ops; lo->tag_set.nr_hw_queues = 1; lo->tag_set.queue_depth = 128; -- 2.15.2