Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1335265pxb; Wed, 3 Nov 2021 23:55:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypOB/KHSANu+jl2P6CQJrnaSSzG1F4ZHI5E/ZI0VLZ/YgksrWhp9gZ5bLq4b6ASQuhrcDo X-Received: by 2002:a02:bb85:: with SMTP id g5mr2433353jan.130.1636008911777; Wed, 03 Nov 2021 23:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636008911; cv=none; d=google.com; s=arc-20160816; b=tzYiNp6WrBCNLn5yE0JRc2/igTO9KEgMopcHlpEFlL6ddwEZ1S4/CJ6QyjcLdZtJxs 6jJhkO890hhIuT5jf5G1M2Et/dMqsJAT/I9I2/HqyKVg3wRuumSeAitG8CQ1UzvO3sFM bvms2veK8HEVQnk9Syl4/MkcDrdin/9vOwb1a9t+mySDU4Be9qBTrFI+cQ2XTdLU576W OzIvI0hYFyUNKM34QBPvn9/098w+05FTLCPUttQE2G3HV6LcQ2BAmZl/K5vo6dFGUlGb al0s2YwofM3T2jQshkdL8ztc/G277CMcIUBIav/k64Y4ufSwRQk62xRGZ32W6yNGf/DG AR+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AmqWbFtMRKjP/RYJLNtNwVoR7JKadqFB+epBPQPtrdE=; b=IkieO0KTeL+3+N23NaJwLNhuoITcTwTuy6fnzUYmqiVjCRhTAZB6RG5kEtouREJv9d 0m3qod6BGGxcL9EyWjMwXyveWXmVAxCmmhbvcE2c8JiXH+CZLZvFsPtF8waVycCSoXv7 qcbF5VUikggPfZmvPdQ9vJVLri4D3gEzJJkeHJzNpiBvoFpwYZoVqEFyZE8VnsO0z2BV DVx14d7lG+nhWamjgN7rd8VF3sgc7WAIg70q7XOhnT2vr4JHMGPbW3AlJLSJRpnnp2xN qJ2jyjuV1BKsF5RQhdwaoVVDO9nupIbayfh9FkrdfBIqr9275sc5NLJIatxOo2KLl/K/ 2ZQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=j8q3HYWX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si10029722ilu.63.2021.11.03.23.54.59; Wed, 03 Nov 2021 23:55:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=j8q3HYWX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhKDG4n (ORCPT + 99 others); Thu, 4 Nov 2021 02:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbhKDG4l (ORCPT ); Thu, 4 Nov 2021 02:56:41 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF44C061714; Wed, 3 Nov 2021 23:54:02 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id b13so5718820plg.2; Wed, 03 Nov 2021 23:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AmqWbFtMRKjP/RYJLNtNwVoR7JKadqFB+epBPQPtrdE=; b=j8q3HYWXl0/V6GEchczRjUTymFAGpd8AEm4NLL1XFtGllfhMZn+ll7hWRKjuuKcBfS Yz2UEWnPILR872/9x4gocwZMDoOhl3GQEizfYBvUzX/UQt73M1k3FvlZStAEzB0JMYV+ UeBZG1fiOb7CWRcfEdY0wvl2G4haNN77SryH9Db5/yWgz1q/GrCbxvpxqQ+AB2FsaIEC YtlwM2jn2S43PA9ccfCsQZzoMNZJ3Dhf71IFUrzop9uI6SysBPCigmsXo2D1y0mubDov KpRwU+QO/PPHAZUXxXsqri/NnILV//ejQA97lu4t3V99Ra4hVAntb7RDAp+SwMMmreLt DY4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AmqWbFtMRKjP/RYJLNtNwVoR7JKadqFB+epBPQPtrdE=; b=28GjoCyB1fa8OkObjbf3Cbneluyyl9DnzrrF9B3hdX1DenStOfSVPA9v/dPGY5Q3BZ PFUSR/JpbVmMejM+OSreU0AVe6KDGJcphItKw7ZttY8A0Cvz0rXM8V8BBpOF3rpZHOsO 5KLSoUzEZYq95ZBEY0U71Dtk6i8AOf1WKieQno12XLFwOfcb0Jm7k5w7PWP2j9n74b7v Oca0HIQHws4MISWwKOZz7x0YhL+1ewQ9xksvprKtuyNzDZEKZoVSHehtnrCftuiwsaCB xZOTvVz/11tnIzGUEBHyYrLJrgrP21mgp3mmqvPGZOUc44hbF2zX7v9GlxKMlJHXPp0q V6OA== X-Gm-Message-State: AOAM53288Am9sw2xJUqQR05SCWz6NJGoeudwLu6GC+qudTMwvGAlsyvc bfAyBDDlXYGixmMgkw4c9Xw= X-Received: by 2002:a17:902:b597:b0:13e:9ba6:fed with SMTP id a23-20020a170902b59700b0013e9ba60fedmr43743350pls.32.1636008842559; Wed, 03 Nov 2021 23:54:02 -0700 (PDT) Received: from debian11-dev-61.localdomain (192.243.120.180.16clouds.com. [192.243.120.180]) by smtp.gmail.com with ESMTPSA id o1sm6638518pjs.30.2021.11.03.23.53.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 23:54:02 -0700 (PDT) From: davidcomponentone@gmail.com X-Google-Original-From: yang.guang5@zte.com.cn To: ecree.xilinx@gmail.com Cc: davidcomponentone@gmail.com, habetsm.xilinx@gmail.com, davem@davemloft.net, kuba@kernel.org, hkallweit1@gmail.com, bhelgaas@google.com, yuehaibing@huawei.com, arnd@arndb.de, yang.guang5@zte.com.cn, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: [PATCH] sfc: use swap() to make code cleaner Date: Thu, 4 Nov 2021 14:53:50 +0800 Message-Id: <20211104065350.1834911-1-yang.guang5@zte.com.cn> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Guang Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid opencoding it. Reported-by: Zeal Robot Signed-off-by: Yang Guang --- drivers/net/ethernet/sfc/falcon/efx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index c68837a951f4..314c9c69eb0e 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -817,9 +817,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries) efx->rxq_entries = rxq_entries; efx->txq_entries = txq_entries; for (i = 0; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; + swap(efx->channel[i], other_channel[i]); } /* Restart buffer table allocation */ @@ -863,9 +861,7 @@ ef4_realloc_channels(struct ef4_nic *efx, u32 rxq_entries, u32 txq_entries) efx->rxq_entries = old_rxq_entries; efx->txq_entries = old_txq_entries; for (i = 0; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; + swap(efx->channel[i], other_channel[i]); } goto out; } -- 2.30.2