Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211103133845.78528-1-wangkefeng.wang@huawei.com>
In-Reply-To: <20211103133845.78528-1-wangkefeng.wang@huawei.com>
From:   Marco Elver <elver@google.com>
Date:   Thu, 4 Nov 2021 08:00:00 +0100
Message-ID: <CANpmjNO6-=dLN=K6R7DrqZmZ5Q8NfORV9kQvwK9kcjCRQhuFaw@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] ARM: Support KFENCE feature
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 3 Nov 2021 at 14:26, Kefeng Wang <wangkefeng.wang@huawei.com> wrote=
:
>
> This patchset supports Kfence feature, tested the kfence_test on ARM QEMU
> with or without ARM_LPAE and all passed.
>
> V2:
> - drop patch4 in v1, which is used a new way to skip kfence test
>   see commit c40c6e593bf9 ("kfence: test: fail fast if disabled at boot")
> - fix some issue about NO MMU
>   - drop useless set_memory_valid() under no mmu
>   - fix implicit declaration of function =E2=80=98is_write_fault=E2=80=99=
 if no mmu
> - make KFENCE depends on !XIP_KERNEL, no tested with xip
>
> v1:
> https://lore.kernel.org/linux-arm-kernel/20210825092116.149975-1-wangkefe=
ng.wang@huawei.com/
>
> Kefeng Wang (3):
>   ARM: mm: Provide set_memory_valid()
>   ARM: mm: Provide is_write_fault()
>   ARM: Support KFENCE for ARM

Looks good to me.

Acked-by: Marco Elver <elver@google.com>


>  arch/arm/Kconfig                  |  1 +
>  arch/arm/include/asm/kfence.h     | 53 +++++++++++++++++++++++++++++++
>  arch/arm/include/asm/set_memory.h |  1 +
>  arch/arm/mm/fault.c               | 16 ++++++++--
>  arch/arm/mm/pageattr.c            | 42 ++++++++++++++++++------
>  5 files changed, 100 insertions(+), 13 deletions(-)
>  create mode 100644 arch/arm/include/asm/kfence.h
>
> --
> 2.26.2
>