Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1548205pxb; Thu, 4 Nov 2021 04:27:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDzE0w07ROIwa6UA83NOFesMEu6O8AZ+q1+f8A+mfUTcBWb7X2g4pnw1pkVERNIie1MKy5 X-Received: by 2002:a17:907:6e1c:: with SMTP id sd28mr29645558ejc.28.1636025263769; Thu, 04 Nov 2021 04:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636025263; cv=none; d=google.com; s=arc-20160816; b=obphW2uB4Kx8Hqp4NTpTU+1nLzyjH7xqH3oRHATsQVVHUqG+cHRnEEUEGKKUMu+1Bu rrMuePgmq4X7eK/u6ohzuoUkBu6URyCHS9LQ4fwdYtylLRu+aSG9nvVGUM3XWKNrSj5X pbgy8bGaGJlu/pm7xKo40JN5iGZ7ByHqnurhBIPz//rJaGBjZWK3Cs27RDkDjx7fSLsY FkVKKwY2rse8Rmjjpb3QeUHY7PapQjQyoRPVVfy/GuY4DDFCFSvHh3WWbjjwnn3k2EGd VZGyjE2kWS7yIfpVfI5ivwUcL0+dq3JiO2RQhbqerMvaIzVJALIbE9/BbC16W1VYprv4 e7Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VUK+H2tInuMO2LxHeEzJumaLNplRG9sxOQ55vl0u9AE=; b=EjygWCTcF7BBiMe+9kjFd4OrDIu/GqyBh0d5N4gOsPIILJs/BPG7EbuxZ0EdMA5JTc DJqiHiOqWIzDjkJ7lU9dcjY84ZM0Rw2Xvp0T6GbkbSrrQHzJ+aQ9795SVD9pX8AJvyrL VODhir6eB53oUpqi0Hvb1t41YnUDXxDz5cJbYOwfW+4aVNW0JpDy8cbAQSETjUND4zZY iPYqJENAKMLyjHp7TJ43gLGvgaYwNpiqLHjZv8fDSYbyg6lzKcr7csbntmzWWnOBIbWl K3dQr2d8X8UTukKGO9T5DEKzqg1eIKC2Y8rK0GJGcCDVtRD4ns3I2iYzfCZtJHK8EVpP dY7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si7215473ejv.769.2021.11.04.04.27.19; Thu, 04 Nov 2021 04:27:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbhKDL0W (ORCPT + 99 others); Thu, 4 Nov 2021 07:26:22 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:49358 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231371AbhKDL0P (ORCPT ); Thu, 4 Nov 2021 07:26:15 -0400 X-UUID: 5ab882aad921464298719cf6ada16547-20211104 X-UUID: 5ab882aad921464298719cf6ada16547-20211104 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 449265518; Thu, 04 Nov 2021 19:23:34 +0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 4 Nov 2021 19:23:33 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 4 Nov 2021 19:23:32 +0800 From: Zhiyong Tao To: , , , , CC: , , , , , , , , , , , , Guodong Liu Subject: [PATCH v1] pinctrl: mediatek: fix global-out-of-bounds issue Date: Thu, 4 Nov 2021 19:23:29 +0800 Message-ID: <20211104112329.8446-2-zhiyong.tao@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211104112329.8446-1-zhiyong.tao@mediatek.com> References: <20211104112329.8446-1-zhiyong.tao@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When eint virtual eint number is greater than gpio number, it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue. Signed-off-by: Zhiyong Tao Signed-off-by: Guodong Liu --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 45ebdeba985a..12163d3c4bcb 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n, desc = (const struct mtk_pin_desc *)hw->soc->pins; *gpio_chip = &hw->chip; - /* Be greedy to guess first gpio_n is equal to eint_n */ - if (desc[eint_n].eint.eint_n == eint_n) + /* + * Be greedy to guess first gpio_n is equal to eint_n. + * Only eint virtual eint number is greater than gpio number. + */ + if (hw->soc->npins > eint_n && + desc[eint_n].eint.eint_n == eint_n) *gpio_n = eint_n; else *gpio_n = mtk_xt_find_eint_num(hw, eint_n); -- 2.25.1