Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Nov 2021 06:33:51 -0500
From:   Segher Boessenkool <segher@kernel.crashing.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     davidcomponentone@gmail.com, sxwjean@gmail.com,
        Zeal Robot <zealci@zte.com.cn>, linux-kernel@vger.kernel.org,
        nathan@kernel.org, yang.guang5@zte.com.cn, paulus@samba.org,
        aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner
Message-ID: <20211104113351.GK614@gate.crashing.org>
References: <20211104061709.1505592-1-yang.guang5@zte.com.cn> <20211104210637.3c424bcc@elm.ozlabs.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211104210637.3c424bcc@elm.ozlabs.ibm.com>
User-Agent: Mutt/1.4.2.3i
Precedence: bulk

On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote:
> On Thu,  4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote:
> > From: Yang Guang <yang.guang5@zte.com.cn>
> > 
> > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > opencoding it.
> 
> So if swap() is in the above include file, then you should include it.

It is included from kernel.h already (which is included from delay.h).


Segher