Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1586499pxb; Thu, 4 Nov 2021 05:08:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtyFefdVQr182jJvvnPLk7St0UcWcc9mtQQQtmuDHvCJUlpuVv3BN8B2zMP2RlaFEYzJLE X-Received: by 2002:a50:da48:: with SMTP id a8mr68733940edk.155.1636027709448; Thu, 04 Nov 2021 05:08:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636027709; cv=none; d=google.com; s=arc-20160816; b=OU6lyb6Ig9Kde7t8rtK8LCHWrlAJufCJBLzEuNpWOjeCjnKXwJ03HesntbJ5j3dYus gRaNqntGZ1eXRw8h+3kUSvBxrh9PFTp+lQzDqd0fAkaPjD6VyxasUjwnwAHqyMQAhq2S abTWhlfM6HDR4lA4HTj4hGQVRRkB4q79RxkDpZ1Sy26+LJorXNGAvOAufoz3ycBdh+Wl xUdmhU4WuzjcR0j4jAwTZC1oQsTzlzrC+Z/OOn2Uj4as8ry2xJH0DBwFcxYtNRf6P50o +qWtBo8Z0VC9pjzOm0qBx0l+GURk4WDeMf9AXSQVrTp9tqtgviPLnRXILmPqPmE483u3 GVFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=/ySgigL9cfrmSPMQ7eaLkHoZWvLaX6xobF6y4aeYovg=; b=b9I354i+b75fTPRpChVT9IWLXGJzNQfuMYA7QM9tiHufj4gRWTzouW6FH2ZpAZBGQx 2wF6gpWndUO7dxpcC6y2fOtcwIK5asmuQ4vG5xKsgOPucUdoM+H7qPnXKXsMCy21gYyo 2Z5+XqZloiyIXrmtgWjbAiFQ+z+CVl+9DDGdyU1rsLpgOz9ARORbeRW4MFXVDVaqRkdc sg+c+SoioMDuu8UDtEsJgdeP+YTSoadZztnVCVMNvlCWH0xk5h2hC5YNk77uRXSvzP6s XsU977pzbXc5w0cDdHi3YYNf6v3vMdH8JQ/Q7BwW7+cb+0RGOfprc63P/NY2aEWxXUiY 7Wgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=o3GORacJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qf31si9778822ejc.782.2021.11.04.05.08.05; Thu, 04 Nov 2021 05:08:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=o3GORacJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231504AbhKDMIm (ORCPT + 99 others); Thu, 4 Nov 2021 08:08:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhKDMIi (ORCPT ); Thu, 4 Nov 2021 08:08:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9546061213; Thu, 4 Nov 2021 12:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636027560; bh=SnYYpxSRUg67hd+Xit15R1TqiZu+34ZFEvrRwplYLzo=; h=From:To:Cc:Subject:Date:From; b=o3GORacJsT9uLQpEl5H7J02DV7zs2O5f3Gq0Wfc8n3hSuXy+b+lGaWwj6tm0S0GHn eX1NgSOjkHOB1U/Hl12sAeXkVVoq3nBqpHwRNb8LLUvRmblbv2sY81Rv3szoOzKO/B +5qeVq5kRPcYyBLJ7N9oZPnahJq+gfLep4pRu7E0d8SbwXZ2Da7+0vGWyzDH0KBFdI Yjepfp3EVHet33eUWMKQ2Swi+NQdwTH4/waYOmZjPxrGcMjupg6Oni2WzROXPu/z/d ITQkALbn/Ff1fkqcMsiRfVS8xu12k9LyHch7/YNE/p2X4hD5biS82kG+KrkyJzraHF fFa/p8mdtVL+Q== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1mibVG-005nHb-47; Thu, 04 Nov 2021 12:05:58 +0000 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 0/7] Address issues preventing camorama to work with atomisp Date: Thu, 4 Nov 2021 12:05:49 +0000 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series address some issues at atomisp that are preventing camorama to work with atomisp driver. After this series, I can use camorama just like on any other device. The frame rate is slow (~7fps), though. Not sure if this is due to some sensor limitation or because of some other issue. Anyway this is a start :-) Some notes: 1. Patch 1 fixes an issue at ov2680 logic. It probably needs to be reflected at the other supported sensors; 2. MMAP is not working. So, it requires a newer version of camorama that has support for USERPTR. 3. There's nothing special on Camorama for atomisp, except that it has support for USERPTR. 4. Camorama currently doesn't allow changing the resolution of the camera. That's because of several things: a. The driver has a scaler, supporting resolutions from 32x16 to 1600x1200 on Asus T101HA. b. The atomisp driver doesn't implement ENUM_FRAMEINTERVALS; c. camorama is not prepared for cameras with scalers on it. It just lets one to select the resolutions enumerated by ENUM_FRAMEINTERVALS. Mauro Carvalho Chehab (7): media: atomisp-ov2680: use v4l2_find_nearest_size() media: atomisp: move a debug printf to a better place media: atomisp: fix VIDIOC_S_FMT logic media: atomisp: fix enum_fmt logic media: atomisp: move atomisp_g_fmt_cap() media: atomisp: fix try_fmt logic media: atomisp: fix g_fmt logic .../media/atomisp/i2c/atomisp-ov2680.c | 127 +++----------- drivers/staging/media/atomisp/i2c/ov2680.h | 3 +- .../staging/media/atomisp/pci/atomisp_cmd.c | 59 +++++-- .../staging/media/atomisp/pci/atomisp_ioctl.c | 157 ++++++++++-------- 4 files changed, 162 insertions(+), 184 deletions(-) -- 2.31.1