Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <70683ce5-cc77-ebc1-b534-7c2d3a92d715@oracle.com>
Date:   Thu, 4 Nov 2021 09:54:22 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH v2] scsi: scsi_debug: fix type in min_t to avoid stack OOB
Content-Language: en-CA
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     gregkh@linuxfoundation.org, jejb@linux.ibm.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        dan.carpenter@oracle.com
References: <1635861997-987-1-git-send-email-george.kennedy@oracle.com>
 <yq11r3wr8ck.fsf@ca-mkp.ca.oracle.com>
From:   George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <yq11r3wr8ck.fsf@ca-mkp.ca.oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzA1Q3Y0M2cwamp4VkRGZTNDL1BmNEhjSVNXdnNMSnZ1eXY2NTV5d21Vcjk5?=
 =?utf-8?B?dWxzeVlpNjhrVHcrcUpjK2dGNzJvYXlvbzhqNmtjK0FzNkJ0ZkFsUm1md2xN?=
 =?utf-8?B?VjA1V0dVQjNGblhVcXh5UndBL3kzdGpsRlpqaVJldXZrcE5KWU9jTzh3NW1F?=
 =?utf-8?B?bkgrWWhBVmVVVjZkNGYrdSt4YmdYdHBtaFZnNVYyeUNhYU1qODhXa2tTcXRj?=
 =?utf-8?B?SFlJUjM5VGlTMXNIWTFTZGtlWnJVU202bFRLL2k2SHhybitHRkoyZXord0pk?=
 =?utf-8?B?V0xPaWNKbGlxLzE0L0t0L2lBQ3JkUkN5RDJHR3dpMUlmd0gzT0NqRUhBajJR?=
 =?utf-8?B?bVYrL0FSYUd4V3BzWmlVY1FQM0luOWFFTjRheUtQbHp0V2tSczZjWXVBTUxZ?=
 =?utf-8?B?NlUwSEQydHByNURpbGdaOWFvVmhvcW5kSHhvMHZLbGUrd1Y3SFV2L1FFaFVO?=
 =?utf-8?B?UTY3c2NwTGVUNGJMdzgycytabnFXL3hFTnE5WnNJaytveTZhWDJManlrbCts?=
 =?utf-8?B?cXBNUHJOVXh0dFQvTEN5OEFUNDBhMEROVXZPWno3Z0ltUU90WkYyRExEKy90?=
 =?utf-8?B?MHNkRkI3SUw2Q0JndVFRSmsveVB4aGhXUWdaazZabjY1RmZCaWNkTkNBWlJW?=
 =?utf-8?B?ek1VTmUxZDJZVTA5N2REdnZDbUhtMG9wQ252TkMzMTQyTWZWczZKMUpGMHZw?=
 =?utf-8?B?VXVpeEhVTFh2SmhrVkllRDFuNFZRVUc1SlZSODJaM0FWQkJKd2Z4R3Q2T2Jq?=
 =?utf-8?B?QVhDREVDdThxd2VKV1BteXA5TUFrVkgybWZvL0twTVlEU0t3WFlrR3B5Mk1E?=
 =?utf-8?B?dklxc281eFRXUkhLejZNV1FrVGQ1ZUVnRXJtcldjQTN2K1ZkTGJYTjdlRzNu?=
 =?utf-8?B?YjN5SE1kQ1V6OWE5OU41c3ZoVWcvNjZoeGFOUWZJK25IUHhMWGMzZVlBajhZ?=
 =?utf-8?B?cCtiSGlLV1pITnlOcnJhbXNXaWE2VityaGZJZkh3RzB3VUlsYWtwSlNKM3lR?=
 =?utf-8?B?bVQ2aEYxR1drTGI4cmptNE9XYWZlSkZRS3ducHhWZjJUMmcwU3hFMDl2dVdN?=
 =?utf-8?B?MzVGTnc1elRMMjVsYmd1SkJGQWttZTlSajlRdkU0QnlpNFhpVHJTcEdaWndo?=
 =?utf-8?B?RXd2YUVPQnJIcE5vb2RENFA2OUhsQ0tMQjhOYmRNak5jdFRsSDBPWTFmY1NC?=
 =?utf-8?B?a0hXczdaSXlEMjl3RW9TSjVrTDRKQmlpdCt2clgvLy9Ebkh6VEZIYzVUNlF1?=
 =?utf-8?B?UnhhNkJweWNzVzBMajQ0S3hxTWQxdHdTZzNOV1N4ZjMwV2ZTTjYvOTdoYnRv?=
 =?utf-8?B?eDBXL0NEOVVneFFSVFdxMWxIdEpDWTArREZEWWgyQXZYeGFhMFVFSmxHT2Jm?=
 =?utf-8?B?cFJuNTJrU0lyTGhKRmNQOGVlbmZGb1I4N3RDRzRYdUxWU2tWckZmcGV5cDZ4?=
 =?utf-8?B?TlhZb281VXBybGtHQUtkbDhtMEw2YXlOQXhiWTZ3em5reDQ1UlMwajg4QnM0?=
 =?utf-8?B?VDQwZVRNWEgxMGFTTVdwN1o2Y0VvMXAvZXRYQXlVc08ySS9MM0RmYThDbDNy?=
 =?utf-8?B?U0dnUm9qUGFQVjhEazViM1Fycmx4MzhjNkxWdjd4Rk5ZZnBoUnB1Qm9IQzM5?=
 =?utf-8?B?eWM2ZEdWeEVNTGpVYVo3WFhoYTV4NmNlbEJBMHkreGpFZzk3WmhkK1FtK3ZT?=
 =?utf-8?B?REJkVzBZTFFmV1lkc3ZEYldIMmJpSnhxd2c4a0dCbzBKdmNSOWtqWkpGM1l5?=
 =?utf-8?B?bmFEM3hUQjlLSCtqQ2hlYlk5Rm1xNXBrbzNSS3Q5dDBjZmRTbE1vUjVlUVRu?=
 =?utf-8?B?REt1Vk1ENFlpU0V5aXVQdW1CbHVkUnZBUTNWY0RUeHR5MXg0bTE5TVcxZkNh?=
 =?utf-8?B?MStqZ1JScUxJYnBxYzVERjArbW5GTHpUTGpnb0lRSDdtcFZEaGpDWm5HY2NU?=
 =?utf-8?B?T09XSWhSbk11K2d5aWo5S0huQXIvY1VIcWwvZWJldWNWS0ZmVHpFRGZjV08r?=
 =?utf-8?B?SDhoT3dPUzlxbHZ2bGFzNFplRVQ4WTA5WnkyWjM2QjIyZ2VmVVFDUGxHWGJZ?=
 =?utf-8?B?NTVCdjlmeGliVkl6bU15VUZyZzlzVnpDc2sveEVuc2h3VjJHbks5NExaU3M2?=
 =?utf-8?B?YXRKekgwL3FTNllwUXBQdjY2MjRVY3VpL1JDWkd3aXRHcjZ3cEI4dXVObkJw?=
 =?utf-8?B?dEdzY3FtWWVueHdCdjJnUWFSQ3JkWlM1NEZnZXZMcWd1VWRIT1FCcHdQUUda?=
 =?utf-8?B?bW9oTnBIYWEzQ3ZRTlBhV29DZ2lBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 935b5792-92b4-4936-8ae6-08d99f9a9d51
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5192.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 13:54:26.7581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iuM2O5oWlNTVP0PdIhl5Fj/DabN8ZuNSQNYoLHu66NU2wad5aQpxE2xt81i0x0Ko77uE3ycy6CETf60tkTkyYPZxCtqN1GkJWXXIAbYNTaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1235
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10157 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111040058
X-Proofpoint-ORIG-GUID: ZBT767pokS_InucnYYoUXOII7di3R6fi
X-Proofpoint-GUID: ZBT767pokS_InucnYYoUXOII7di3R6fi
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Martin,

On 11/3/2021 9:59 PM, Martin K. Petersen wrote:
> George,
>
>> Change min_t() to use type "unsigned int" instead of type "int" to
>> avoid stack out of bounds. With min_t() type "int" the values get sign
>> extended and the larger value gets used causing stack out of bounds.
> This needs to be reconciled with the following commits:
>
> f347c26836c2 scsi: scsi_debug: Fix out-of-bound read in resp_report_tgtpgs()
> 4e3ace0051e7 scsi: scsi_debug: Fix out-of-bound read in resp_readcap16()

The proposed patch should supersede the above commits.

George
>
> Thanks!
>