Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1715450pxb; Thu, 4 Nov 2021 07:15:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxL8qXgomPmAg5sMLS+DRw2zp3b0nfTANN0mEPV/Eeo+f2eiRrz3niUVHJm2zQPi79DofaV X-Received: by 2002:a17:906:dfe4:: with SMTP id lc4mr11610602ejc.125.1636035351188; Thu, 04 Nov 2021 07:15:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636035351; cv=none; d=google.com; s=arc-20160816; b=VGou00eR447WFv0BCtQ8U0WA86HMWwrL7kqih2LAKjU2GStrTke6z8APFrovR2mcWs pS3fzezaLEjPkv5lRcY2naQRjcOwnEgMWLeeBKOFAcGhO7ARflWIIW3jH2yzu+t+UxPW ISgBOI8R5Eo52/FZJmMXGr+sBT0XkSWBjNiLmjS99fqCjtWQ7JmV3EqDMBapy4jOkxO4 BT3ywJn3Sd/0+CM67PxOe2BjXcwxlAZuuVQp8Q7OXhTsPHtGmDE+gKBQ8etgKBaamefZ PYb67+9/hHPU41XoYQ0B/ZoqP2sifrSa0dOLDbqZcyDi6IoZqLMg3pMmTEAG3h/QK4qT iKcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-filter; bh=m2VDAM2LgZwK23bpeTVTQg2Pflqf2h5GtAHZ5yFkZCs=; b=L34urc5RtdoNCAuI+Ypaf4YTSOOgVURCvGu7/PHrtGaCM2BUdLk1whPqpGzgjN0vdd NKzyXtC20YqeyXFtjXWqlx/120KcasZ4Fc0NItUGVq9BIVnEhyoLT2hPYE3N3QrJRdYR NO0T6hlt4W7SAPHl9r17BUx0ln2itXu6cU9wdi1TahLOuJRmiZFSLTTOYH8nzkz2xD8t f1M11LTqsLM+zt2b93fs8u23SUcBv/E9pjepbDSphPtkH9BKMQi2pWl7n+Vii84qVtmc YOVB975sKKo0HbpO6KVKlfZTlV01g7A+TRMoiLe4oDS0pkdWUXPfzf4A3k00qLImSYVU dO8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=T5IAZK7G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb5si10477937edb.172.2021.11.04.07.15.05; Thu, 04 Nov 2021 07:15:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=T5IAZK7G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbhKDONA (ORCPT + 99 others); Thu, 4 Nov 2021 10:13:00 -0400 Received: from linux.microsoft.com ([13.77.154.182]:34754 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbhKDOM7 (ORCPT ); Thu, 4 Nov 2021 10:12:59 -0400 Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 86A0120ABA90; Thu, 4 Nov 2021 07:10:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 86A0120ABA90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1636035021; bh=m2VDAM2LgZwK23bpeTVTQg2Pflqf2h5GtAHZ5yFkZCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T5IAZK7GpQkwVv8RglhvlxLWlMvcXR0UkDY9BxJyQmZSkf2tAfVodaHOkOBpynlRh DeHc5FYlfF7cxK0W+NrSkfC3TO1IRjl6AryOSd3VKHNyFOt0LyeO++JamAcrtnGpva Q+cWSfIRhcx/7Cgz85G3IowwqRUGciH17/yJBZiA= Date: Thu, 4 Nov 2021 09:10:19 -0500 From: Tyler Hicks To: Robert Marko , Lee Jones Cc: Alistair Francis , Linux Kernel Mailing List Subject: Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency Message-ID: <20211104141019.GE3600@sequoia> References: <20211103190426.1511507-1-tyhicks@linux.microsoft.com> <20211104135347.GD3600@sequoia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-11-04 15:00:40, Robert Marko wrote: > On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks wrote: > > > > On 2021-11-04 08:24:28, Lee Jones wrote: > > > On Wed, 03 Nov 2021, Tyler Hicks wrote: > > > > > > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that > > > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following > > > > linker error: > > > > > > > > ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > > > > simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices' > > > > make: *** [Makefile:1187: vmlinux] Error 1 > > > > > > > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells") > > > > Cc: stable@vger.kernel.org # 5.15.x > > > > Signed-off-by: Tyler Hicks > > > > --- > > > > drivers/mfd/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Looks like the same change that has already been applied. > > > > > > Could you rebase on top of the MFD tree please? > > > > Ah, that commit wasn't in for-mfd-next when I wrote up this patch > > yesterday. > > > > I think that the Fixes line in that patch is wrong as I didn't see this > > issue in 5.10 and reverting c753ea31781a fixes the build failure. > > Hi Tyler, I would agree with you on the fixes tag. > I messed that one up, c753ea31781a is the correct one. It is probably better to overshoot than undershoot with Fixes tags. :) Lee, I don't know if you rebase that branch (I doubt it) but if you do to fix up the Fixes tag, please also add an explicit Cc: stable tag since this affects the new LTS release. Tyler > > Regards, > Robert > > > > Tyler > > > > > > > > -- > > > Lee Jones [李琼斯] > > > Senior Technical Lead - Developer Services > > > Linaro.org │ Open source software for Arm SoCs > > > Follow Linaro: Facebook | Twitter | Blog > > > > > > > -- > Robert Marko > Staff Embedded Linux Engineer > Sartura Ltd. > Lendavska ulica 16a > 10000 Zagreb, Croatia > Email: robert.marko@sartura.hr > Web: www.sartura.hr >