Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1773898pxb; Thu, 4 Nov 2021 08:12:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+lkG1FuahCpYpyTURAhfND4Lohb5fRJSiugE2dKCbvQjJJCeoQhQeGlSmDjJdHHaD+e4d X-Received: by 2002:a50:c909:: with SMTP id o9mr68840092edh.122.1636038759932; Thu, 04 Nov 2021 08:12:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636038759; cv=none; d=google.com; s=arc-20160816; b=quXjNGkF3nmuL+vRrC9qTFUDNqfURPged4VqC5iNHTCj/sbXv6Yr1b5jVwsma3jGj0 UZ+9ILLwweFlO/EaiSs1cXBcQRvxVldw2BeerFOHsfTbAfWQiNrjVxOZOFwIG/mpjmgS 4qXvFCKXw2hYphWist+Dj4Wj4fxUheduxBp1RjFcq8i1dYpV1CYd0i3edI2NH2KHp5g2 Z0rYnxMS75ZmgWw4LSYBqJjP4UsXse2tdDdnyPQ3SqRLPIp2C9YvYk2h5R9sqvujS24O CT0YDZjHsRs73XsqeJUod8mqX7StxzHmTRJ4UinXmv5LOfAu6yHsGwttj9J4CzcQM+2e GayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=3ywmMVxU1QE82sngKIrgn0zqKdXE91GwTMkMfV+uhLU=; b=p465cBY45xZHn7NRb9TyXFSdKY8YB81ZpVAOnRbpmPXpn1Qx0k6Wv2nwBkDG3kzJly EijcpDQ+sXRYbwh8aiwKrTaWm5+89FECw9V5CM5VwrAnReLMOasEkl91btWlHsWKim00 BayqJOnuwd25EV475e70Wm7eFyHN34sjhkciUOyIIaPrdXowdjYm0J5O+3USOc5kJKNx ZQGa4CrA0QyDGDiXg6kzt7Fp2Y5rHpgSEw4wngFRhT3ulp668aGj6a9V490Ao24fQ2HP DCDkfVF7K5bJ94sIa0nBqEKimbZwQqYxJDVEa9MP6XrhNY0kqj2bxgPLwdtJcXmegXFi Hbqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oqg61gZV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si8121523edf.39.2021.11.04.08.12.15; Thu, 04 Nov 2021 08:12:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oqg61gZV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbhKDPMN (ORCPT + 99 others); Thu, 4 Nov 2021 11:12:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:37982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231380AbhKDPMM (ORCPT ); Thu, 4 Nov 2021 11:12:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4C8D61244; Thu, 4 Nov 2021 15:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636038574; bh=ifwFRJOtxIAgi3YdD5ELIcT21UTszvpduiP183mPeRE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Oqg61gZVsJ9MS4QPEEux1j8z+uYsgllgJwG4RdnZOvFrVe/a3riKCBTh+WbmPXYAp NV88sbASbPh07kNLCIsCPLgME3SSNcrLyDvugQuP6Sr0Z99B8uvLca9Usx8WUzb1Du VZSocrcig4FcgrT9yrpMb5Shfk9VidKyrk3OoCwsHi6nMYAd2HhpOlsk9k6pfmUDR2 wZW6a5e7q53FHKaksZWtxSaCv/OcCpy0d/vnkHIzVyXphEZKIfmX2xw3RXrxNYEKwC TGxCXcBme7u/1xjTVRF2zab5mLUMxdZam8+rS7ghlrl367KLPaS7akAdpGuYzGkjgT yqmKFFMD7PlxQ== Message-ID: Subject: Re: [PATCH v2 0/2] ceph: metrics for remote object copies From: Jeff Layton To: =?ISO-8859-1?Q?Lu=EDs?= Henriques , Ilya Dryomov , Xiubo Li Cc: Patrick Donnelly , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 Nov 2021 11:09:32 -0400 In-Reply-To: <20211104123147.1632-1-lhenriques@suse.de> References: <20211104123147.1632-1-lhenriques@suse.de> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.42.0 (3.42.0-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-11-04 at 12:31 +0000, Lu?s Henriques wrote: > Hi! > > Here's v2 of this patchset. The differences from v1: > > * Instead of changing ceph_osdc_copy_from() in libceph.ko to return an > osd request, move that function into the cephfs code instead. > > Other than that, the 2nd patch is quite similar to the one from v1: it > effectively hooks the 'copyfrom' metrics infrastructure. > > Lu?s Henriques (2): > ceph: libceph: move ceph_osdc_copy_from() into cephfs code > ceph: add a new metric to keep track of remote object copies > > fs/ceph/debugfs.c | 3 +- > fs/ceph/file.c | 78 ++++++++++++++++++++++++++++----- > fs/ceph/metric.h | 8 ++++ > include/linux/ceph/osd_client.h | 19 ++++---- > net/ceph/osd_client.c | 60 ++++--------------------- > 5 files changed, 94 insertions(+), 74 deletions(-) > Looks good. Thanks, Luis. Merged into testing branch. -- Jeff Layton