Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5a8772c3-7999-4675-59fe-c20ee2d66510@oracle.com>
Date:   Thu, 4 Nov 2021 11:21:36 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH] scsi: scsi_debug: fix return checks for kcalloc
Content-Language: en-CA
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        dan.carpenter@oracle.com
References: <1635966102-29320-1-git-send-email-george.kennedy@oracle.com>
 <YYN81hZyBZ2dU3Wu@kroah.com>
From:   George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <YYN81hZyBZ2dU3Wu@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THVFRWpmQ2Nja2ZlU3BSeGpuMVIrcEVQSjFqU1V2ZVRhb0laVTlvczBOSTVj?=
 =?utf-8?B?aEdTc2YwRjdsWEpMd1ZZT2wxZU5YZDBoWkduU3I5eVg1cFpEQ044V3ZnYnlK?=
 =?utf-8?B?UEk4eTJpQnQwSzBHRHYrc2hoMHlGQm5aSGt2cS9JUHlNL1NwcEtDMWZST3Bp?=
 =?utf-8?B?SDN3R2xYRlBpY3Q0TFZ4R3B1V2REWHdiT2FmSFViZ3lndEd2Ti9QK1FpTlB2?=
 =?utf-8?B?Y080WjBGVXprd0hIZGpYdEtibG5vNW1zcFBsZHVqTVpwNGlOT0Z4OVlVTElq?=
 =?utf-8?B?d0FMRmJDQUlEOEFNbEprYkZJTENENm9TaWpwUzEzcDdHRWJLelgwZWFQRG1j?=
 =?utf-8?B?ZkxRZ055cWdKZ1NVR1Z2c0s1ZzlOZ0c1UjQrVU1LRnhQVDNqRFlkbExIcnhi?=
 =?utf-8?B?Y25YRVdrTGhPaXZmTlZQQzVpRHZsVjBQREV0RDZXaDF3VC9mMjh6a1R1d1c5?=
 =?utf-8?B?YUdSaVByTGlsYU1ScklIM0tCVFd6NGgyRitlc2wwMUZKZTJYdGlOd3c5aURS?=
 =?utf-8?B?QmlWeUQvRnhHN2ZjN01LVktPY3lrbWd3OUNLYUR0dUtWSUxWUjJKcWl3aWc2?=
 =?utf-8?B?QUNRY21sbEtrdlYvNHZlaGJRbG5RTDc0M1VsNjlFVXBzdTRPZ0g5aGE3TFNM?=
 =?utf-8?B?RHE0WUo5NXFoUUg5RVJwUG9nU01WWS9BRTdLV3ZnMmxFaDk5NW9HbGJNeStr?=
 =?utf-8?B?VmxEK3FLMWlHTmRmNnRQWmpmUDM5NXluZE5HVDFZblUyY1dmcDVBRFphaWty?=
 =?utf-8?B?ekQ0NHlXVFNZTlRHenVYc3Y2dDNqcHN0aEd5VHVqSkpDc3pOVjUxNGJ3M3h2?=
 =?utf-8?B?ODRlMHZjSTV1YVljbzMzZC9aRXN4WWM2RDI1N1A4NHI1emdCbGFxVTVMNFJP?=
 =?utf-8?B?djFUckxsMVFVMWU2MEFBWHVqWFNrSUZuaWVnWWdNSnJVRVJ5dWN3ZVpod0gr?=
 =?utf-8?B?MXNqb3dQYzRQUnUvZ1FaMDNtZVJ6czA3NkY0TlI5NENUczBON1E2TDFGc3Uw?=
 =?utf-8?B?VXNob2pHRjFRdS9Oc1JoTlV0bzNwT05nMWJ4QVNTR01MaWZJOUlaR2tTbjFD?=
 =?utf-8?B?a1hGbnY3Y0NERVQrVXp5bFlyVnErU0J2SDVWajVET2xWOHpHWTlRdlZYL3gw?=
 =?utf-8?B?cVFXNHVPNkloZU1lajJ1Q29rVlY1VEZ2SDJLMU9qaGh2eHBmcW5mL2RZMTN2?=
 =?utf-8?B?M1A5VjBYbEhsRmFhTWozQzVWM1o3SVRKM0JhSTMvOFladDJRcW5XV0FNRTdl?=
 =?utf-8?B?Z0dWTHJhVXZweUd0RzRRM2dRNjhQZ2ozM0c3TjNnKzA4R3VqMHBKeFVwVGtF?=
 =?utf-8?B?Ly8xMklIMTUzT2I2WjU1TUJFUlE3VzgySExWTWlUa2RycGNXdk9oUUF3cit4?=
 =?utf-8?B?TzFIdHVUcE1VYlVYa3h2dktQVnQ4bEZTSC9YZW5ZRUREQ2JpU1YwUzlUdGpM?=
 =?utf-8?B?T3BZK3VvNTJndGFVUEg5VlJOb2x1NlEyYlhhQklONmsrL0hUWHkxUTRTbHIr?=
 =?utf-8?B?RGkzR05HZG9IWkpncS9yZE9kSlAxTlFCUVVtb1hBZXBDa2Z1MWtzbXBDTkZI?=
 =?utf-8?B?L3JFblhLVEUzTE9iVEdsNDdFWGFaRFRkbU85VnRRWEI4Vk9lM0ZRZjEycHZz?=
 =?utf-8?B?SG1rK2g2cjFNZnNCREdDOTAydnFCbHJEblBPZmtBRExFVDJ3RWg4ZjNMUlUw?=
 =?utf-8?B?OXFuUEVyZWtwUm9wd3dqU09XelBDY3BSMDdzVXBvRk5GbEJLLzBoYzVZbVhT?=
 =?utf-8?B?c0F0Z0NtR1ArQlpzYjVkaE9JVXlxb0tlc3BYbXJkUFFJNENtajN6bHBiQVY4?=
 =?utf-8?B?Vk8yQjhrU3BSY28xS0FkUzhqWXpxRFZwOUpORTd5UUU3UzhnaHNVMkVnekpr?=
 =?utf-8?B?ZE5XZ1NtdU80VkdGdHhLYWh1R1psOWh4MUMyNjMyZGd6d1pEZWF1VU9xZ2V6?=
 =?utf-8?B?THFRdnBSZm1DMk5DQnVEQlRLNXNjRUxaUW8xOWFCVVhaanZEM0JWaHVOQ2M3?=
 =?utf-8?B?SlpyNDJxN2pPb1JzUXdjNEZmYzlETTd4aFY4U0pGS0kxTHd2OTNCRE1oeENo?=
 =?utf-8?B?djJISnhYeWVEalIyM1loT0F4VSswVWxpbGRveVJEOHhwSWtPc0UySkpHUXJ4?=
 =?utf-8?B?WXMzL2pvWjh4L0xPdVZMUWU2UlVnNzlSMUNRQnloNlRvR1FBbVNwQUVSNFZm?=
 =?utf-8?B?S1o3VVB0cXVqL0RWZE9kV3puU25BaWRjLzd1ZXZVS0ZGNExmY0RraTNRMGRI?=
 =?utf-8?B?dFJhNVNjU1k1L0x5RWU5bm4wRkNnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8055167b-e9c0-47a8-1706-08d99fa6cd03
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5192.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 15:21:40.4217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gKTVoYgzj4ijr6rFjlH5bowRV/2DlZ1ob7zPxY2H4Um/wKo5tiu/1EvzZ0ahOiDXyrx3oSo8v7lM3J769lqur1wpuTSfA9BCdCmkPytw4FA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1857
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10157 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111040058
X-Proofpoint-ORIG-GUID: CA9I1pL3lBgjgPDXQ5tYTPR8uSpBmyoL
X-Proofpoint-GUID: CA9I1pL3lBgjgPDXQ5tYTPR8uSpBmyoL
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/4/2021 2:25 AM, Greg KH wrote:
> On Wed, Nov 03, 2021 at 02:01:42PM -0500, George Kennedy wrote:
>> Change return checks from kcalloc() to now check for NULL and
>> ZERO_SIZE_PTR using the ZERO_OR_NULL_PTR macro or the following
>> crash can occur if ZERO_SIZE_PTR indicator is returned.
> That seems really broken in the api, why is kcalloc() returning
> ZERO_SIZE_PTR?
See Dan Carpenter's explanation.

kcalloc() purposely returns ZERO_SIZE_PTR if its size arg is zero.

See commit: 6cb8f91320d3e720351c21741da795fed580b21b

>
> Please fix that, otherwise you need to fix all callers in the kernel
> tree.

Here are the kcalloc() args:
/**
  * kcalloc - allocate memory for an array. The memory is set to zero.
  * @n: number of elements.
  * @size: element size.
  * @flags: the type of memory to allocate (see kmalloc).
  */
static inline void *kcalloc(size_t n, size_t size, gfp_t flags)

Any call to kcalloc() where the size arg (the 2nd arg) can possibly be 
zero needs to check for ZERO_SIZE_PTR being returned along with checking 
for NULL being returned, which the ZERO_OR_NULL_PTR macro does.

In most cases throughout the kernel the calls to kcalloc() are with the 
size arg set to a sizeof some data structure, so ZERO_SIZE_PTR will not 
be returned and a following check for NULL being returned is all that is 
needed.

Thank you,
George

>
> thanks,
>
> greg k-h