Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Nov 2021 15:37:14 +0000
From:   =?iso-8859-1?Q?Lu=EDs?= Henriques <lhenriques@suse.de>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Ilya Dryomov <idryomov@gmail.com>, Xiubo Li <xiubli@redhat.com>,
        Patrick Donnelly <pdonnell@redhat.com>,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ceph: metrics for remote object copies
Message-ID: <YYP+KrFWyLmfKY9v@suse.de>
References: <20211104123147.1632-1-lhenriques@suse.de>
 <b2fcd4ff9dd84ceb90650d24b56bd704985c85b8.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b2fcd4ff9dd84ceb90650d24b56bd704985c85b8.camel@kernel.org>
Precedence: bulk

On Thu, Nov 04, 2021 at 11:09:32AM -0400, Jeff Layton wrote:
> On Thu, 2021-11-04 at 12:31 +0000, Lu?s Henriques wrote:
> > Hi!
> > 
> > Here's v2 of this patchset.  The differences from v1:
> > 
> >   * Instead of changing ceph_osdc_copy_from() in libceph.ko to return an
> >     osd request, move that function into the cephfs code instead.
> > 
> > Other than that, the 2nd patch is quite similar to the one from v1: it
> > effectively hooks the 'copyfrom' metrics infrastructure.
> > 
> > Lu?s Henriques (2):
> >   ceph: libceph: move ceph_osdc_copy_from() into cephfs code
> >   ceph: add a new metric to keep track of remote object copies
> > 
> >  fs/ceph/debugfs.c               |  3 +-
> >  fs/ceph/file.c                  | 78 ++++++++++++++++++++++++++++-----
> >  fs/ceph/metric.h                |  8 ++++
> >  include/linux/ceph/osd_client.h | 19 ++++----
> >  net/ceph/osd_client.c           | 60 ++++---------------------
> >  5 files changed, 94 insertions(+), 74 deletions(-)
> > 
> 
> Looks good. Thanks, Luis. Merged into testing branch.

Awesome, thanks.  I'll wait until this is merged into mainline (which will
take a while, of course) before I push changes to the fstests.  Adding
further checks to the tests that use remote copies was the drive for these
new metrics, and I've already some patches for doing that.  They'll need
some cleanup but it doesn't make sense to push them before this is
available upstream.

Cheers,
--
Lu?s