Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Rob Herring <robh@kernel.org>
To:     Akash Gajjar <gajjar04akash@gmail.com>
Cc:     Liang Chen <cl@rock-chips.com>, Johan Jonker <jbx6244@gmail.com>,
        devicetree@vger.kernel.org, Chen-Yu Tsai <wenst@chromium.org>,
        linux-rockchip@lists.infradead.org,
        Peter Geis <pgwipeout@gmail.com>, Levin Du <djw@t-chip.com.cn>,
        heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Alex Bee <knaerzche@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20211104075234.8020-1-gajjar04akash@gmail.com>
References: <20211104075234.8020-1-gajjar04akash@gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Add rock pi s dts support
Date:   Thu, 04 Nov 2021 11:12:52 -0500
Message-Id: <1636042372.246110.3458346.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Thu, 04 Nov 2021 13:22:24 +0530, Akash Gajjar wrote:
> Rock pi s is RK3308 SBC from radxa. Rock pi s has a,
> - 256MB/512MB DDR3 RAM
> - micro sd, sd nand flash (optional on board 1/2/4/8Gb)
> - 100MB ethernet, PoE (optional)
> - onboard RTL8723DS 802.11 b/g/n wifi + Bluetooth 4.0 Module
> - 26-pin expansion header
> - USB2.0 Type-A HOST x1
> - USB Type-C DC 5V Power Supply
> - 2 LEDS, 2 Keys
> 
> This patch enables
> - console on UART-2
> - nand flash
> - sd card
> - 100Mbps ethernet
> - USB2.0
> 
> Signed-off-by: Akash Gajjar <gajjar04akash@gmail.com>
> ---
>  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3308-rock-pi-s.dts    | 208 ++++++++++++++++++
>  3 files changed, 214 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/rockchip.yaml:473:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/rockchip.example.dts'
Traceback (most recent call last):
  File "/usr/local/bin/dt-extract-example", line 45, in <module>
    binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
    return constructor.get_single_data()
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
    node = self.composer.get_single_node()
  File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
  File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 850, in _ruamel_yaml.CParser._compose_sequence_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a plain scalar
  in "<unicode string>", line 472, column 22
found a tab character that violates indentation
  in "<unicode string>", line 473, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/arm/rockchip.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/arm/rockchip.yaml:  while scanning a plain scalar
  in "<unicode string>", line 472, column 22
found a tab character that violates indentation
  in "<unicode string>", line 473, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/arm/rockchip.yaml
make: *** [Makefile:1441: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1550787

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.