Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Nov 2021 12:49:51 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Liu Xinpeng <liuxp11@chinatelecom.cn>
Cc:     linux-kernel@vger.kernel.org, mingo@redhat.com,
        juri.lelli@redhat.com, zhouchengming@bytedance.com,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] psi: Remove repeated verbose comment
Message-ID: <YYQPL4exZUP2eruI@cmpxchg.org>
References: <1635133586-84611-1-git-send-email-liuxp11@chinatelecom.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1635133586-84611-1-git-send-email-liuxp11@chinatelecom.cn>
Precedence: bulk

On Mon, Oct 25, 2021 at 11:46:25AM +0800, Liu Xinpeng wrote:
> Comment in function psi_task_switch,there are two same lines.
> ...
> * runtime state, the cgroup that contains both tasks
> * runtime state, the cgroup that contains both tasks
> ...
> 
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Peter, could you please take this through -tip?

> ---
>  kernel/sched/psi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1652f2b..526af84 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
>  		/*
>  		 * When switching between tasks that have an identical
>  		 * runtime state, the cgroup that contains both tasks
> -		 * runtime state, the cgroup that contains both tasks
>  		 * we reach the first common ancestor. Iterate @next's
>  		 * ancestors only until we encounter @prev's ONCPU.
>  		 */