Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1977411pxb; Thu, 4 Nov 2021 11:47:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWfOM7X/kSTfoGbxP/gKmbrp9fZG4wvpElmVGoTxx7TX8D2YcTL1OcLuuAUGsBOPH9HoJe X-Received: by 2002:a05:6402:d59:: with SMTP id ec25mr47582756edb.214.1636051659806; Thu, 04 Nov 2021 11:47:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636051659; cv=none; d=google.com; s=arc-20160816; b=kBRoUPmsgVJmPijUa8MsaBztLeDSkhzscHU+2MPAU1LbMhCZtxHnVkLhN8ONBieHz4 jQVNJNLD61w30xccI8WXAIsNUKG3KtIrJifyHjd+EQpxYL72nuqlq+cxfog9LTmaKGDC Pzi6nBjfReq/GxalVFwNh0h7Rid+8Knm8BKoQcKQsTxbFZjRk8pkg1O6pjC3D6mcxMII +l/7k/2Ji7rL2fhaLdxvaZhqZ0nalzg64gP+tXer0ABUMIaiYqCCAE9IwiKkkAI3HXSq uT8sLZKYRzQ+W2liRTo82y9LseYMoXSWyZCtv4kBAyFI7kdaLX2Wo+l7x6QLbfsXdOPU +++w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ZD8CZF9Ze0sseKnWl29xT8kiXbbv03DVblgSWWWGh8I=; b=uMQzNZloZhOCFIr8DHyHTH6wQDBP0z9ZoHJPCowP/pEJa15Uqe5lD7WRej7qBj7U9e ij0QU1FL1QtNLPgI49OkmaBCUXXDWWSlIYOWca8Bz74jXXJHShsw/a8k9GcFEwM8b1GG 1sE6wIrNuayiBsLoPe8DfAKf96QYIeoMZRLHsU/tbqOeJ9yEjdKh9NU+XLfIGeXEEJAj 0CpS27OZlE1TbvFZt5jOD9wvx/ljBlj4o8NvDyttJC5Hi2GbNLrgSrcTcZhSm5PGnVtI Ro9K7xV8047x2irHiwlgylZ6CysQCx/l6EEfP3XHBSkGhv0y3TLmMaKedIYy3tx5DK9+ vlHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="F3t4Lf/9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si11437405edc.344.2021.11.04.11.47.15; Thu, 04 Nov 2021 11:47:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="F3t4Lf/9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233862AbhKDRgt (ORCPT + 99 others); Thu, 4 Nov 2021 13:36:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:47154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbhKDRgs (ORCPT ); Thu, 4 Nov 2021 13:36:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A0CC61076; Thu, 4 Nov 2021 17:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636047249; bh=A4238DQGmI4/bX7NYgaTJp0Z3vyq2cge8JI3yq/k/is=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F3t4Lf/91ADp+gdchaR5vWv+XVWBJmN8N8HXm7dTA9thuaeYeofSt/jezew3jT5Iw POTZMiBQKUl7NSwIbSFoFI9JGGMCMgwbRi0B6+klJldp6FeQMQ77H/QRABAaZ0M2vH Al7FpW2MN9PpEHsNyW+QwpepFm+B0THTi1uwllVHEWkxi1ODMxQHUonvrh5WIaVLd3 km7ScP/l/DXV9ms4NXuwAVoZEodhBedivpT1s8bdbXOGfvxRVmqfzmEcHXyO7UmDr+ z2R3IbjSmFxqyfeUzY3/wjHtx7IQR8XSMtrkZ+9B/fMxbS3zn/owLNJmfHaomJ5tU5 MvcbB9ohfyFpw== Date: Thu, 4 Nov 2021 10:34:08 -0700 From: Jakub Kicinski To: Riccardo Paolo Bestetti Cc: "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2] ipv4/raw: support binding to nonlocal addresses Message-ID: <20211104103346.29d82cb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211102141921.197561-1-pbl@bestov.io> References: <20210321002045.23700-1-pbl@bestov.io> <20211102141921.197561-1-pbl@bestov.io> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Nov 2021 15:19:21 +0100 Riccardo Paolo Bestetti wrote: > Add support to inet v4 raw sockets for binding to nonlocal addresses > through the IP_FREEBIND and IP_TRANSPARENT socket options, as well as > the ipv4.ip_nonlocal_bind kernel parameter. > > Add helper function to inet_sock.h to check for bind address validity on > the base of the address type and whether nonlocal address are enabled > for the socket via any of the sockopts/sysctl, deduplicating checks in > ipv4/ping.c, ipv4/af_inet.c, ipv6/af_inet6.c (for mapped v4->v6 > addresses), and ipv4/raw.c. > > Add test cases with IP[V6]_FREEBIND verifying that both v4 and v6 raw > sockets support binding to nonlocal addresses after the change. Add > necessary support for the test cases to nettest. > > Signed-off-by: Riccardo Paolo Bestetti Thanks for the patch, please keep Dave's review tag and repost in ~2 weeks. # Form letter - net-next is closed We have already sent the networking pull request for 5.16 and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after 5.15-rc1 is cut. Look out for the announcement on the mailing list or check: http://vger.kernel.org/~davem/net-next.html