Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1978970pxb; Thu, 4 Nov 2021 11:49:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPPPVp70lmHkpnqbsJbywKOQMf3z5Srq4XkTbXvVLvjywGBRGjTkArFvXK+mCjsrIbYrzw X-Received: by 2002:a17:907:1c9d:: with SMTP id nb29mr35876550ejc.74.1636051779909; Thu, 04 Nov 2021 11:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636051779; cv=none; d=google.com; s=arc-20160816; b=A2P1ZahPsJ6i4e85gKV7AjHCJ+YtAJINBNwQpt9YYfb/o9+rmp7Zdpr4CDzOb2Ow1g LioxcvwTFNL1XkUGGunz+R28NUBkXNRW1bCJoC3cdIPag9VWv0Za0PyTgcw3Z2i7q+DY XkUmxO2Rbktz6YSZVb5qCAbpDdI0KXB+eCsaxLNwzx2q/jI7iqI0TjSWC9egTcv4yT/O oMtTHEHaIwxbabx7j28cYPjGnaAwtLhMvX7/N6RKnwOm/8XbTXJKRmmh4WS7QooPCjKI 3m3bqYXA+VJ1+grYq01IvvUOujiBW2VIlc3GcPgVGyhnJOD+Rg+/1d0r/Hk/YrldQXTD +ZNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=OvhXza2EMyUDpF+aFsadLR2bHUxlMsQpGO/7waaP14I=; b=HULvKoi1aomcuqX8i7A0MAWlL+rAVdfd94LPOGBYZe6WjxMCxWKNa8JK5fVWAlzLEb 6eIptJdzIfJe+km0TXslWcUkbssbtcLjNhkXWumeMKiIj+OTt2tF11xuMPxmgGLPbjt3 qZrDNuNWdjgc0cN1z/mh4qgQdbbuFjG6vf7rwnIoEkTLQ37ob3qte8tgTadvEAvV0X1y OZfqolihM8BBHUefrhVhiFgN8ML0fYviXWTjEfF6Rb3GA62IlGeik+WSvSDieTo4AUQd GCf79XeL0LA9leKeQZ+SdLKY78AbOKIziFgBj+zSAbc3neISXD5AOBzPyeeWtA2tUlxO Mk1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id js3si11193548ejc.494.2021.11.04.11.49.15; Thu, 04 Nov 2021 11:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233961AbhKDSjf convert rfc822-to-8bit (ORCPT + 99 others); Thu, 4 Nov 2021 14:39:35 -0400 Received: from mga12.intel.com ([192.55.52.136]:15360 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhKDSje (ORCPT ); Thu, 4 Nov 2021 14:39:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="211820937" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="211820937" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 11:36:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="586066902" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 04 Nov 2021 11:36:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 11:36:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 11:36:55 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.012; Thu, 4 Nov 2021 11:36:55 -0700 From: "Luck, Tony" To: "Chatre, Reinette" , "dave.hansen@linux.intel.com" , "jarkko@kernel.org" , "tglx@linutronix.de" , "bp@alien8.de" , "mingo@redhat.com" , "linux-sgx@vger.kernel.org" , "x86@kernel.org" CC: "seanjc@google.com" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH] x86/sgx: Fix free page accounting Thread-Topic: [PATCH] x86/sgx: Fix free page accounting Thread-Index: AQHX0ancXoKdYS/VT063RtxMG9uqNKvzsfGg Date: Thu, 4 Nov 2021 18:36:55 +0000 Message-ID: <9f96f71fe67042a89cd1a8f79a1840fa@intel.com> References: <373992d869cd356ce9e9afe43ef4934b70d604fd.1636049678.git.reinette.chatre@intel.com> In-Reply-To: <373992d869cd356ce9e9afe43ef4934b70d604fd.1636049678.git.reinette.chatre@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -/* The free page list lock protected variables prepend the lock. */ > -static unsigned long sgx_nr_free_pages; > +atomic_long_t sgx_nr_free_pages = ATOMIC_LONG_INIT(0); You accidentally lost the "static" here. This is still only accessed within this one source file. Otherwise: Reviewed-by: Tony Luck -Tony