Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ad812781-af6a-102c-0900-c4277284f2ab@intel.com>
Date:   Thu, 4 Nov 2021 11:44:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.2.1
Subject: Re: [PATCH] x86/sgx: Fix free page accounting
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "bp@alien8.de" <bp@alien8.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     "seanjc@google.com" <seanjc@google.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
References: <373992d869cd356ce9e9afe43ef4934b70d604fd.1636049678.git.reinette.chatre@intel.com>
 <9f96f71fe67042a89cd1a8f79a1840fa@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <9f96f71fe67042a89cd1a8f79a1840fa@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3ROVURmaDZWMHZNVGJScXJDcDRpeCtPWkRFNk00WlJNdTlvY0pidjVEbHg3?=
 =?utf-8?B?SFljRU9WQmp2M2VmUE1CS3NjR3N5ZE44NmlleHJPZitRZ08yMSs3cXh3Ny9E?=
 =?utf-8?B?amhxdEd6RTdFRGVzWXd3Tnd0UnJwT0hheTFEYXFCa1pjR2FrS21XUytHTFF1?=
 =?utf-8?B?d3lrOXROR2NCOXkvRHhYbFg5ZndDb0JzVWVvY2tCdHpEQndIalU4V0Nsc3JP?=
 =?utf-8?B?T2ZqcnFJMnJ3U1hWaXRzb0NiZVpWZEhaemZoSEc0S1EyZ013emkzRUNWTklN?=
 =?utf-8?B?NkoraUNPU00vWjQ2bTlac0VXSE5CVS9OQjhsMGVLRGNaQ0hGRGI4N2VXY2dO?=
 =?utf-8?B?N0Fldy9UdUdpNkw4aG5jZU5ibVFCRFI5WFpudW53S3FPaFN4RXg1enpEZmo5?=
 =?utf-8?B?WWkzVWpnY2dseTM0dy9OaXR0NlN6ak82OFhxcDE5UkJuMmN5RUNiQVJOOVNE?=
 =?utf-8?B?emJ3UW0xWmFkUW5ieWxRbEVXeHp5ZStSOXZ2c2YyWVZmQjRTVkxTSjMraCt1?=
 =?utf-8?B?ZmtqVVR2UDl0TjJHSlRkRkhpSFRqYUw5Q1BIRldack95d2ttSGJha2F6Nkow?=
 =?utf-8?B?d0o3TDNnY0FLV2U3Z01PY1RIaXlDeC9vZUN5TnNrVXBYa3E5REE1UnB1WjRs?=
 =?utf-8?B?RmRoMjNJQWZ0RHh3UFpMVklrOUM2WFFqYTdRMDNiU0VWeHBQcHl2VEEzWCtw?=
 =?utf-8?B?MFNyVC9WMHVMSGQzNGtmVVJ0bk9yNUlyYVFDTnVOQzIvNmxoYkY2YUhma0Fn?=
 =?utf-8?B?TWYrSWVtN0xYR1NqNW54cDRqWXB3R3J6OTN6TmNCVlRpR2k1bkVVbnpuNjhu?=
 =?utf-8?B?Wkl6VXZ1ZXI3eUtxdmR3R3BtWVBDS2tJWnRlelJwZ2RIa2NmTGJBMUo2RGV0?=
 =?utf-8?B?anpCUUtWVHZnSEJwOHBUN29lRk9udWVsOW1xVUQrUE1oQWdHcTgyNSsyeDVH?=
 =?utf-8?B?bHBTYytaM21DT21pM1hpbkdUQXJUVWJzY2NlRFVHdUlycHNXVnRJVTJkVTJS?=
 =?utf-8?B?YlhlL0FiaTdMSjFYdnhkSEord0RrREVpSUZTZVF1aHUzc3R5b2R5Umt2UWhU?=
 =?utf-8?B?L3F6U0d4NmNFbGw5a25oRGlXN2QyS2k2RW9wb0lzR01Wc1NHbG1ySnRWYTNB?=
 =?utf-8?B?Si90dTRUcXh4bi9uTlo5Q0pSMldJRDZPUGQ0WnBwRFhUdVdCWllBT1FKb3NP?=
 =?utf-8?B?UE5kbVJYVExmSTh2UDRmeEptT0daMEl5WHRZRHFjazhHZGpDSHlNcmNhMjZx?=
 =?utf-8?B?MG9ZR0xOUitBck9UWXUrdjJ5cFY5azZVNGJzM21iZVYrYWpZbFVtMlVnanM5?=
 =?utf-8?B?SmZYazVoaWtiYWlZMWR6a3Z4dW5tT2hsT1lzVVFIQ0lYcDI0ekJqaVNINnJC?=
 =?utf-8?B?djJ3azh2K1RUV1VQTnVLQW5GK0N5UklBSlZLMUl3YURIcHJuTVhKcWphRUFa?=
 =?utf-8?B?SDVqcDV6RjVjeGVpSTlsZklrcnByMWtCMm1HbmYzbmJIdXozMmRpNkJQYVF0?=
 =?utf-8?B?bmtQNlEwZ1M5QTNqR0htWVFRQS9aa3ZNYVI4WDlUVkFIRnVGVVhpNDRtU21F?=
 =?utf-8?B?YmNiN2dJV3ZYcDZSVmhySmFXTjM2YWtSNm5UOG5TSUZZeEpIQWkvZWJJOC9O?=
 =?utf-8?B?SUVmcy9seVFicnFnTEUvaDBSZkU1QVhtQzcxWm5qMDhRTXlObWVmTWdnNk55?=
 =?utf-8?B?MjVjSEJiYWJyTXNDY095T2tDWEl4eE1ueGp6a2hJSzhqem1FYVJDMjlhbTBu?=
 =?utf-8?B?UDFwKzBIa2JOUDBnSWloMW5aV1hBYkFKTHVhT251dCtYbk1wVHNkWkpWd0hn?=
 =?utf-8?B?bDBzVlllMnJXU2xOc3RvbDJZd3hVU1BCNURxdWYxejJnK0RjSXNlQ0dUREdT?=
 =?utf-8?B?dkdQRkJjM0o1Z2dGdDZUUlcwdDFldVJMY21yQ2cwSFMxZXExWGs3K1lVNU1t?=
 =?utf-8?B?UGt5WUI3SFN0NDhrTUxvKytvVjFIMTFsTTU5dkp6ZlUxbTREcHY3MStVZytV?=
 =?utf-8?B?cTdmMkVoL0dHcFh0aTFtV2Zna3lHRDdFRUhOdEU1TDFFVzhuWFJPd2lFckJZ?=
 =?utf-8?B?Y0ZLdTRkd0lOV3U5Yk9WanB6cEpFTjNvRXJPMVNqbHdHNzN0M1BlbUFrR09m?=
 =?utf-8?B?YnhpbU9PNnR4am9FcUZlYUZFZ00yeFRoME1YWHdQK2VzNHJnaEdhQzRGN0c1?=
 =?utf-8?B?UjFUTDNmelMwNlJobm1FL2kxT29tcTFqbDZuakVvV0VrSkJ6TUZqWTJxL1Jj?=
 =?utf-8?B?YVQyL0Ywd2N0azRhT1lWM1greEd3PT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e134c99c-0a2a-4ec7-ace9-08d99fc33379
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 18:44:58.2369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wIv4Kk3JrMGbDCfUKCAmM+o13ieLEyJlLqfbPMmLPnyg0Dkbmho96eLgxsu6ZIjhK1lEebi4O/4TUGJxRy0Dxg0x0WYVBRngRldDTAQDUUY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4502
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On 11/4/2021 11:36 AM, Luck, Tony wrote:
>> -/* The free page list lock protected variables prepend the lock. */
>> -static unsigned long sgx_nr_free_pages;
>> +atomic_long_t sgx_nr_free_pages = ATOMIC_LONG_INIT(0);
> 
> You accidentally lost the "static" here. This is still only accessed within this
> one source file.

Thank you very much for catching this. Will fix.

> 
> Otherwise:
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> 

Thank you very much.

Reinette