Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 07:26:18 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Segher Boessenkool <segher@kernel.crashing.org>
Cc:     davidcomponentone@gmail.com, sxwjean@gmail.com,
        Zeal Robot <zealci@zte.com.cn>, linux-kernel@vger.kernel.org,
        nathan@kernel.org, yang.guang5@zte.com.cn, paulus@samba.org,
        aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner
Message-ID: <20211105072618.4afd84a9@canb.auug.org.au>
In-Reply-To: <20211104113351.GK614@gate.crashing.org>
References: <20211104061709.1505592-1-yang.guang5@zte.com.cn>
        <20211104210637.3c424bcc@elm.ozlabs.ibm.com>
        <20211104113351.GK614@gate.crashing.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/O=.71vhxXSmXnHrfLh68vph";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/O=.71vhxXSmXnHrfLh68vph
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Segher,

On Thu, 4 Nov 2021 06:33:51 -0500 Segher Boessenkool <segher@kernel.crashin=
g.org> wrote:
>
> On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote:
> > On Thu,  4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote: =
=20
> > > From: Yang Guang <yang.guang5@zte.com.cn>
> > >=20
> > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > > opencoding it. =20
> >=20
> > So if swap() is in the above include file, then you should include it. =
=20
>=20
> It is included from kernel.h already (which is included from delay.h).

And that becomes a pain when include files get "cleaned up". :-(

$ grep kernel.h include/linux/delay.h
$

See commit

  300424acf349 ("include/linux/delay.h: replace kernel.h with the necessary=
 inclusions")

currently pending the Andrew Morton's patch queue (the above is a
linux-next commit).
--=20
Cheers,
Stephen Rothwell

--Sig_/O=.71vhxXSmXnHrfLh68vph
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmGEQeoACgkQAVBC80lX
0GwV+Af/QfgNuHshpM97/m+EA6krcPslVh80rCHog7q7R2NBlPt0mHLz115zVfdS
0YvSRA/fUS8LUkDii8JRTxwjvUjXPuPOF9ldSQTH5ACmCYqkruGIiCsDSzkvE+Lf
/lR3W6/ifGUa2b0sDNQANtNwXCy1O6Vu6sYM2PO9FzZdK8+kEwl+JUfYJEtwHBfq
yL2lP/hZiqj/M+huaFEgr+gMTdQhPOsPDFNfPrJkvXE9f7/XDHt8WYXt4t/Ni9EC
bL+nOCdxxargQ+UZmF1pbkx4SbBJY9Xwh2MuAi09QRzyWIFwxoLjvdSGIkkB5HK0
VqZnLGtsn8w1kvLg3+fGk/NF4mFdVw==
=U0JT
-----END PGP SIGNATURE-----

--Sig_/O=.71vhxXSmXnHrfLh68vph--