Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20210913085226epcas5p2b516f0f591926c927faa9c60d211bf44@epcas5p2.samsung.com>
 <1631523095-8672-1-git-send-email-ravi.singh1@samsung.com> <YYQQdI8rjvN4ZEOd@cmpxchg.org>
In-Reply-To: <YYQQdI8rjvN4ZEOd@cmpxchg.org>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 4 Nov 2021 16:11:37 -0700
Message-ID: <CAJuCfpFUSBJ6fRf5vRwycdXx5vHdM9vj36+iqh8jN2wVvDtuCw@mail.gmail.com>
Subject: Re: [PATCH] psi: fix integer overflow on unsigned int multiply on 32
 bit systems
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Ravi Singh <ravi.singh1@samsung.com>, mingo@redhat.com,
        peterz@infradead.org, linux-kernel@vger.kernel.org,
        a.sahrawat@samsung.com, v.narang@samsung.com,
        vishal.goel@samsung.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 4, 2021 at 9:55 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> CC Suren

Thanks!

>
> Sorry, this fell through the cracks.
>
> On Mon, Sep 13, 2021 at 02:21:35PM +0530, Ravi Singh wrote:
> > psi accepts window sizes upto WINDOW_MAX_US(10000000). In the case
> > where window_us is larger than 4294967, the result of an
> > multiplication overflows an unsigned int/long(4 bytes on 32 bit
> > system).
> >
> > For example, this can happen when the window_us is 5000000 so 5000000
> > * 1000 (NSEC_PER_USEC) will result in 5000000000 which is greater than
> > UINT_MAX(4294967295). Due to this overflow, 705032704 is stored in
> > t->win.size instead of 5000000000. Now psi will be monitoring the
> > window size of 705 msecs instead of 5 secs as expected by user.
> >
> > Fix this by type casting the first term of the mutiply to a u64.

Looks reasonable to me.

> >
> > Issue doesnot occur on 64 bit systems because NSEC_PER_USEC is of type
> > long which is 8 bytes on 64 bit systems.
> >
> > Signed-off-by: Ravi Singh <ravi.singh1@samsung.com>
>
> Fixes: 0e94682b73bf psi: introduce psi monitor
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

>
> Peter would you mind taking this through -tip?
>
> > ---
> >  kernel/sched/psi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> > index 1652f2bb5..a2cc33dc2 100644
> > --- a/kernel/sched/psi.c
> > +++ b/kernel/sched/psi.c
> > @@ -1145,7 +1145,7 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
> >       t->group = group;
> >       t->state = state;
> >       t->threshold = threshold_us * NSEC_PER_USEC;
> > -     t->win.size = window_us * NSEC_PER_USEC;
> > +     t->win.size = (u64)window_us * NSEC_PER_USEC;
> >       window_reset(&t->win, 0, 0, 0);
> >
> >       t->event = 0;
> > --
> > 2.17.1