Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2247009pxb;
        Thu, 4 Nov 2021 16:58:55 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwoRthoLSKu8fiEgsO3vJWoq8Oo8Hu8RNcObSiy8zJ7ZGpe1GUJ9jA1xt0goYnrBJS7CRIY
X-Received: by 2002:a17:906:4793:: with SMTP id cw19mr48151861ejc.387.1636070335289;
        Thu, 04 Nov 2021 16:58:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1636070335; cv=none;
        d=google.com; s=arc-20160816;
        b=Ml6I+OPFBs4TwgHkMcH0O4oj1cpgPhrkQVeXuJCyziwV5wX/6/N+mKBr6nBsRXUIdq
         3qvFs7AbCynqIUDdxQ6m+5bi0qjnwZUDKAFG7YBFaH/OVt/4aJsYVhBtT4U4Qs1+rzOp
         jSfUbCsIz2fFqQoQVFVJ/8z54OLdyFPvwa753h2SPSW88OxikaBEifYSmtv+65Eus9lE
         cBmlGDsQpURDtux4+RGleBW/cD8CglhbF+97dR6/qd0ZKefDLzxilcBliXz2hlyHdz9T
         IzUb30P/yKQmUIEWOTfFUk6+HpsSB469Vx0h9mPsMyJ4Hz0KQskXK+z8rKQbBFK8Vp4m
         AB2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=JBKbgDsjzpRaOwjUcCtqx5/j1qfvxLSWRh1c9jUApPU=;
        b=iJrr0PGa79hU8B/UQ5+IxHlJ+oWF4cu+4Sh7ZLx/RirCrwKYhxq1xp/9v8FFPWczMu
         aADh5v14aBZJxWsxLrOEbq2FEzeVEEhuptcsiNPk51HZiZVLJdO8S7fHuh9O/daJX1gx
         SSdN4ITV4ALXMX13/rdjvN2oWiOe/QRlo8PofuqKnYGg0A66jNfkHcCZWr4WksdEOnlw
         qewF3ubWI3qDolfGeFqx7FLQA5h3MP7TD7EzL8pkg8ab4myGD5dzvzfC420bpIY/xbsz
         rWqRTLeJbn+FHOsv6CDP6dbe74w6Q2Yg2qv/lhsPvugZVtenTwd40YrAU787v4+XSa0p
         ZybQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P91c0cNK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id qw31si13124028ejc.118.2021.11.04.16.58.29;
        Thu, 04 Nov 2021 16:58:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P91c0cNK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232397AbhKDX6O (ORCPT <rfc822;ly15351151@gmail.com> + 99 others);
        Thu, 4 Nov 2021 19:58:14 -0400
Received: from mail.kernel.org ([198.145.29.99]:50536 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229725AbhKDX6M (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Nov 2021 19:58:12 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1111761245;
        Thu,  4 Nov 2021 23:55:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1636070133;
        bh=LjZJ+WVEgGR0lT5HwCCp4cTyjDkgI7NjMus+P1YMzR4=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=P91c0cNKoikNJTuqnR72z8TuKfPm+tctHmEPOSqUo6EbAcv51L0xk6+ch6MXk2OfO
         Agt1V+m2lSh2nABHkw7UE/8iajNJ98AlhXmKYEd2oV9wMpB+u7QMGAWRwepzBwuAZk
         JQzLv5yk4jEgWXXNRkvQ/+pgC15Ky5AY0GavoFKmNxcADQNGJq9E+Ysbk8bjdACfP2
         17ZVw0QPnTM6mXQOyMbIjQg/dJwBdHDLow8ndmS4fwLZRH9sLounnOCjasG6cug2DG
         idsZ3EV1HEVba0OLT4IvQ8XiC+kPNSPJIk1qzo9cl9QzNQx+dkq60Gy6WCH5VImRe1
         7XB7bad+pp9rg==
Date:   Thu, 4 Nov 2021 16:55:32 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Eugene Syromiatnikov <esyr@redhat.com>,
        Jeremy Kerr <jk@codeconstruct.com.au>
Cc:     Matt Johnston <matt@codeconstruct.com.au>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] MCTP sockaddr padding
 check/initialisation fixup
Message-ID: <20211104165532.781b3dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <cover.1635965993.git.esyr@redhat.com>
References: <cover.1635965993.git.esyr@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 3 Nov 2021 20:09:36 +0100 Eugene Syromiatnikov wrote:
> This pair of patches introduces checks for padding fields of struct
> sockaddr_mctp/sockaddr_mctp_ext to ease their re-use for possible
> extensions in the future;  as well as zeroing of these fields
> in the respective sockaddr filling routines.  While the first commit
> is definitely an ABI breakage, it is proposed in hopes that the change
> is made soon enough (the interface appeared only in Linux 5.15)
> to avoid affecting any existing user space.

Seems reasonable, Jeremy can you send an ack?