Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Xiaowei Song <songxiaowei@hisilicon.com>,
        Binghui Wang <wangbinghui@hisilicon.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com, mchehab+huawei@kernel.org,
        Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH v2] PCI: kirin: Fix of_node_put() issue in pcie-kirin
Date:   Thu,  4 Nov 2021 22:07:11 -0400
Message-Id: <20211105020711.32572-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3i8EeGvsmNIwieigmuWH/qO1jXKvAnMm445cCl0R0BRhW2t+Z6y7Yx75KtOC?=
 =?us-ascii?Q?lykf9NyGV82FKOAGVDHYM/hfSavg9UV7lCK03fUdfmhCTQeguNSEZBYPJLrV?=
 =?us-ascii?Q?ZreUTNbG1O4CnDhUiyGXUGw+dxV6V7nqEjGGmgnWT9SJtchRuNalt+ShKvYe?=
 =?us-ascii?Q?bFLB/FTRgXMNxa07Xrr1hS+zpK8LZdg4wLpwzJSyZsYDi30F99R+3oLB4gCH?=
 =?us-ascii?Q?OeYl1/OwTno46X+3sWChzNYqnZPR6EtQQ3kHkOhkot/pKYu6S1iN1dcYBmLU?=
 =?us-ascii?Q?uX27eZ7fLC9oD3/6rC79NlenEJm0loZBUCobQI/VQjfehtLpsSnpFl+nd3ky?=
 =?us-ascii?Q?+UrIART/OLHBgtjzBglIeCIK7dFS4SEVAGLXJfxsTWaW2tK+R6JBE4doPj24?=
 =?us-ascii?Q?LWExmZFWa69drlw8A0rYNUF1ap0SHTKkQihrKVRLh5j1jocenMnzBCMH22HS?=
 =?us-ascii?Q?B46vdgNaAqR095x6husVS8XVryRgupulo9D1F2xKjT+b0FafoFJlCRgH18pL?=
 =?us-ascii?Q?YbCFV8VpYxDtjj+zapHJHEg7CmV6GKhcxNywxLEzAWu1NQsx9oC9QEET9LzQ?=
 =?us-ascii?Q?caXIMoCrI7eQgAkpLnG1WBJt0WhbbbplDyV1cHo4k2qCziSNq1nUDn8YD0o8?=
 =?us-ascii?Q?Mfx7zebP3mypYurGmvhY0FrwZpkTIo+WnUsFTHXFYFcQn+RuNqOBGviYJK8t?=
 =?us-ascii?Q?Tth3wfGsRo4VWgubbmUFd++X7w8N+EHRSfBEhVbTaBvgDgLb82SWZkGdLpR0?=
 =?us-ascii?Q?FkML8cJqS/HsEcCKKDdEeNYnVDEv0j1+edsYpoE6D68VxVpFtjUHUOBhBk93?=
 =?us-ascii?Q?r4mq6eb4nXMmT34EYOCqVfiveonTIGuqzjR+gfs9hlkQTkd+J6bVlmDuEOcx?=
 =?us-ascii?Q?BDgELPTVlk6xgQKatGUjhDteJWAEiNbV7nFkgsG+JkQoDA6SQ0FcmPku/QIq?=
 =?us-ascii?Q?cfho0tp0ePX1fGO13GOgm+KWWykjn5UJkvi1aBHseV5/4bgeXG++5bOAIGe+?=
 =?us-ascii?Q?sl1z5JkPU5BcLMU4uKD9ARyYn+epE6mhu0Fv0tz4R08WQjRrjiOkkOC/VYZ1?=
 =?us-ascii?Q?4eokye7z9HMwfUUZHevi3tm8jG/cxNkfSsp/XBS47HjOd5fNGUrkS5iOFY/b?=
 =?us-ascii?Q?7YTRp4kGspjeLOXijVgy66RbEEv+OGtUWs97E688FmTkeE9Xk8/C1rqIoThJ?=
 =?us-ascii?Q?5s8kzlhJKQt/7D7mNCu7V8vebDgGtPYU50h/6OmeYa7byTQV7Xjb6eyUlln6?=
 =?us-ascii?Q?hPREzlt5HQhSvn2EH4oLzGRXh9B1Xl1b556nW61AXKV4ggsAXJRexDfjfZsM?=
 =?us-ascii?Q?95/A4xYGIWQXKNbCc1b/mTkURXTNrO9YFKRuskUyTyut7gNf7zCi7GuVucX/?=
 =?us-ascii?Q?abumF5jLZszOGBd155Xbo/2zAvG0+GecOmiMzpN5axgoBhBOokqUCcnkCBk8?=
 =?us-ascii?Q?UxoGGKvXynmK6BCbXlHXtKb3ivPNqw5yOXlJ4z5wEDpGNsWTj9ss+H4tMyAB?=
 =?us-ascii?Q?WTyfuKfwFDX7S2TBWhIYrg3v0Gy6nMVdPGAFVaDUraoqZyfSWYmUq88msNYu?=
 =?us-ascii?Q?7t4atZEZk3w+bzaTExToPR8/3tBLiEQRgOIpP7wfbMrGCjMcfiuv93yUYQSt?=
 =?us-ascii?Q?lPI2p1vN2T3YWfysr8bf7aU=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f026f3e-9daa-4af9-d32f-08d9a0010826
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 02:07:34.4447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sclEvZDBvZlyjz0/FFKYAEnc2FalfMnyti1FnZo2XEnyQQKUd6xIbPIbpHQ38eG0g5TlCmI9OzFBVmWMHt2MhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3452
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/pci/controller/dwc/pcie-kirin.c:414:2-34: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Replace return by goto here and add a missing
of_node_put for parent.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/pci/controller/dwc/pcie-kirin.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index 06017e826832..b72a12bac49d 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -422,7 +422,8 @@ static int kirin_pcie_parse_port(struct kirin_pcie *pcie,
 			pcie->num_slots++;
 			if (pcie->num_slots > MAX_PCI_SLOTS) {
 				dev_err(dev, "Too many PCI slots!\n");
-				return -EINVAL;
+				ret = -EINVAL;
+				goto put_node;
 			}
 
 			ret = of_pci_get_devfn(child);
@@ -446,6 +447,7 @@ static int kirin_pcie_parse_port(struct kirin_pcie *pcie,
 	return 0;
 
 put_node:
+	of_node_put(parent);
 	of_node_put(child);
 	return ret;
 }
-- 
2.20.1