Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] drivers/coresight: ultrasoc: Add System Memory Buffer
 driver
To:     Qi Liu <liuqi115@huawei.com>, mathieu.poirier@linaro.org,
        suzuki.poulose@arm.com, mike.leach@linaro.org
Cc:     coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
References: <20211105012012.86635-1-liuqi115@huawei.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <af9dbbbf-64f0-f3c6-fa30-4e306e6156d2@infradead.org>
Date:   Thu, 4 Nov 2021 18:36:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211105012012.86635-1-liuqi115@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/4/21 6:20 PM, Qi Liu wrote:
> diff --git a/drivers/hwtracing/coresight/ultrasoc/Kconfig b/drivers/hwtracing/coresight/ultrasoc/Kconfig
> new file mode 100644
> index 000000000000..c18c25bf9df3
> --- /dev/null
> +++ b/drivers/hwtracing/coresight/ultrasoc/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: MIT
> +#
> +# ultrasoc configuration
> +#
> +config ULTRASOC_SMB
> +	tristate "Ultrasoc system memory buffer drivers"
> +        depends on ARM64 && CORESIGHT

The "depends" line should be indented with a tab instead of spaces...

> +	help
> +	  This enables support for the Ultrasoc system memory buffer
> +	  driver that is responsible for receiving the trace data from
> +	  Coresight ETM devices and storing them to a system buffer
> +	  respectively.


-- 
~Randy