Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 11:15:08 +0800
From:   Cai Huoqing <caihuoqing@baidu.com>
To:     Xu Wang <vulab@iscas.ac.cn>
CC:     <joel@jms.id.au>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: litex: Remove unnecessary print function
 dev_err()
Message-ID: <20211105031508.GA817@LAPTOP-UKSR4ENP.internal.baidu.com>
References: <20211105014217.38681-1-vulab@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211105014217.38681-1-vulab@iscas.ac.cn>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 05 11月 21 01:42:17, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> index 3d9385a4989b..ab9fa1525053 100644
> --- a/drivers/net/ethernet/litex/litex_liteeth.c
> +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> @@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
>  	priv->dev = &pdev->dev;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
> +	if (irq < 0)
>  		return irq;
> -	}
>  	netdev->irq = irq;
>  
>  	priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
> -- 
> 2.25.1
>