Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xin Ji <xji@analogixsemi.com>
To:     a.hajda@samsung.com, narmstrong@baylibre.com,
        dan.carpenter@oracle.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        sam@ravnborg.org, pihsun@chromium.org, tzungbi@google.com,
        maxime@cerno.tech, drinkcat@google.com, hsinyi@chromium.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        bliang@analogixsemi.com, qwen@analogixsemi.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org
Cc:     Xin Ji <xji@analogixsemi.com>
Subject: [PATCH v12 2/4] drm/bridge: anx7625: fix not correct return value
Date:   Fri,  5 Nov 2021 11:19:02 +0800
Message-Id: <20211105031904.2641088-2-xji@analogixsemi.com>
In-Reply-To: <20211105031904.2641088-1-xji@analogixsemi.com>
References: <20211105031904.2641088-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oTRCH9uATP3CHu9eZMYxi1MYE0HTOd8xQlWYAhcIsoXVGe9w9gQ6rZIKzDeG?=
 =?us-ascii?Q?+qNwdSRDk0u6bHsny6ItKs43znOYmW4mVKBY+X369wzHVLk3CO0uvgC06oGY?=
 =?us-ascii?Q?sZtxxnPrW7tHkaV0nDRxZQHOHnyLgVu2Sk1L0+6DNMUK6yrrno9GelKhQN18?=
 =?us-ascii?Q?olLNKXAoLa+7wdFF064/mCU/p0pzGIEpHugb3A2oc9k6K+roJfJS+C+wcHfE?=
 =?us-ascii?Q?wqJCYWUqONjrR3pHqejpMi328BxVPPU1uVx4vANhlOTfJPMewwRy/1kxE9Wr?=
 =?us-ascii?Q?3mzg0B1qE4S/X0kBI5Qb7pV021ebQmVn4N1PjTrIKGfh6aKvxR74qBryCmxB?=
 =?us-ascii?Q?k1t8x33AWIhPKO0pC9etqsMi7IX5LMDutDMBZhW/hpYv5jWggRUtC5JyCs++?=
 =?us-ascii?Q?zi4VgX5bLpiOfHlnFHFoGjsKCKooxNkqYyscskaTykvs1Ih9gHptHKFRhBHe?=
 =?us-ascii?Q?eM3A5s/GZDjkJ6fetwOJriqsE+x6IKq8DHs5J1SPOuf5TUgBXyzFXTCBJDhz?=
 =?us-ascii?Q?o3m9QOYeue+kttei8wpmmovMQhv+aarf4Q+ZJsqMCfyHc99ak5H+tUxo6DhO?=
 =?us-ascii?Q?9co1O2mSkSVKstWATHGHWKqbikWFZzoEi2IzGXZhvI6PxWZdHqBeE57/2ovc?=
 =?us-ascii?Q?MFCc+AQV9WVmg7OaY853Bbmp0+HC2U5W1bI/RdG2K6woG3IQwBmyVT5Wtudt?=
 =?us-ascii?Q?Y0aOj266tQElyT8IZoZiIQdbDHsv0eiqYYyvYcXmfiC6H/3dxudgosa1QCon?=
 =?us-ascii?Q?IdJZgUzo12HyZtbEu9AFDqHhlso0ZH8bXxwe3Wk/942Jlg4xTNpJXAK+rmbz?=
 =?us-ascii?Q?zGNaFkvolGpKylyKnvPc3Rb7txiOxIwbEKQJdvfiKgYuqAbHs0NDKJ4Ld4Le?=
 =?us-ascii?Q?M1IjFXh1xCsGNHU1Ogs0JNtieCOo2GtMVpT71dexlnhDT/YCS1Of4pKCDBC1?=
 =?us-ascii?Q?1iJuWSYSrKjvkIFA9/0CW6Jxgju+8Jdt0xquT2LEzFfpqFdZ2YobMFLpC4KJ?=
 =?us-ascii?Q?gUWO3BzLbEi5vqhjSXDgyA80ftPs/JWgp16KPsJ9UiBh2myWwfcvcSsMFl14?=
 =?us-ascii?Q?YGW49j6z+QqbO9Wio+e3GuJy5eczMclJ5n0cXiPy8bhXBE1uD11CKhGlxBTZ?=
 =?us-ascii?Q?Q4OWtXK6fzcng0i4/TR9yQJcIfr5m46asbIC/56DeXAZoeIWeRQ2d493YfKq?=
 =?us-ascii?Q?g/bk/NmhkgFsIvz8s+mCJs+hJTz/gbXq7nn2IytAGs86/DaNc3c7s3AJ6SjJ?=
 =?us-ascii?Q?9T7FaxpspvdIOjms/9JgFEdosd91c85yIHoNp6am+1lyh/GEp5lRnLrpjp6D?=
 =?us-ascii?Q?Ie8NQjoVWT7J5UeWEfXqCpLXYER3+wRbIztvtDevcSQjL0Sco4gcItqN5ZWJ?=
 =?us-ascii?Q?NQtgwLdBIn4RLlajOVnxa/rgYNN5Lv5ZjFAN+Wjb5UUaVcY37mDIrOR6tgwA?=
 =?us-ascii?Q?V77JFpl12e7mrm14B7cP7M6Wz1zvZASi+BO9SXnNVFD9VCQDI7PKe+HKrdLG?=
 =?us-ascii?Q?HygNVpGtctKCUVxEAkmzEx2SXsSoLBAH+jbgnf5P/i2TID364MG6nyl3Jo+9?=
 =?us-ascii?Q?XqBDk6du7RFKQ2SZPJpIfc7ikFWxMw1LoLsYw2KSfCy/UAeZ62HEnUjxuFVX?=
 =?us-ascii?Q?BCcd6fs3g0cSvwNlMxyMfdU=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93f3ed15-4924-4884-eb92-08d9a00b1983
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 03:19:38.4190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Fir9mUlhugHHjL+v6g061mAsDfIxjDewJnrj/HWlJ4/v8SXczc6Cy1h540aJobqNNn0vx6ZdfqWCQcRspWM7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6438
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At some time, the original code may return non zero value, force return 0
if operation finished.

Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index d0317651cd75..f48e91134c20 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -191,10 +191,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
 			       AP_AUX_CTRL_STATUS);
 	if (val < 0 || (val & 0x0F)) {
 		DRM_DEV_ERROR(dev, "aux status %02x\n", val);
-		val = -EIO;
+		return -EIO;
 	}
 
-	return val;
+	return 0;
 }
 
 static int anx7625_video_mute_control(struct anx7625_data *ctx,
-- 
2.25.1