Date: Fri, 5 Jan 2007 21:45:09 +0100
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: David Brownell <david-b@pacbell.net>
Cc: rtc-linux@googlegroups.com,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>, Russell King <rmk@arm.linux.org.uk>,
       Woody Suwalski <woodys@xandros.com>
Subject: Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver
Message-ID: <20070105214509.12190340@inspiron>
In-Reply-To: <200701051001.58472.david-b@pacbell.net>
References: <200701051001.58472.david-b@pacbell.net>
Organization: Tower Technologies
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 42

On Fri, 5 Jan 2007 10:01:57 -0800
David Brownell <david-b@pacbell.net> wrote:

> This is an "RTC framework" driver for the "CMOS" RTCs which are standard
> on PCs and some other platforms.  That's MC146818 compatible silicon.
> Advantages of this vs. drivers/char/rtc.c (use one _or_ the other, only
> one will be able to claim the RTC irq) include:

 Hi David,

  good code and well commented, thank you.
 
 I only have some comments:

 - I would put anything that is x86 related (pnp,acpi)
 in a separate file so that people working on
 non x86 systems can have a better grasp of the driver.
 
 - the name should be rtc-mc146818 to be coherent with
 the other drivers, but this can cause confusion.

 - please put yourself in MODULE_AUTHOR

 other than that, I'm fine with the code.

 I'd appreciate if someone (Woody?) can test
 this code on ARM.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/