Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     George Kennedy <george.kennedy@oracle.com>
Cc:     gregkh@linuxfoundation.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
        dgilbert@interlog.com, joe@perches.com
Subject: Re: [PATCH v2] scsi: scsi_debug: don't call kcalloc if size arg is
 zero
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v917nu8o.fsf@ca-mkp.ca.oracle.com>
References: <1636056397-13151-1-git-send-email-george.kennedy@oracle.com>
Date:   Thu, 04 Nov 2021 23:42:47 -0400
In-Reply-To: <1636056397-13151-1-git-send-email-george.kennedy@oracle.com>
        (George Kennedy's message of "Thu, 4 Nov 2021 15:06:37 -0500")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rIYT53umyK4sn0qagsAMSpR/PZ0ppnkf3WWh1aw4VrDNW0JkcDj4wUseIce5?=
 =?us-ascii?Q?E2cImxgWf2Pj8blJ7YwTRg7HU+mIcRl9mmMV3g3hM35N7MSFnYXSlGjXB4//?=
 =?us-ascii?Q?biDyCcK+Yn5cJsFRWXMwyVr8oG1QrTfWh5fmd3iyo0T0xDB8nnX0IcwB6xm7?=
 =?us-ascii?Q?LUKvVhDrY+3WkKze3vyTHxDOaJAraGsN9kNhFiCeJDV7hG7tLRY/amcHcHT6?=
 =?us-ascii?Q?SXMD5J7FPVcSMTpt98lP02UsZnKzRU4MtEwazHt/AFO0R+6xMPYZQSXzULqG?=
 =?us-ascii?Q?xFGqSCm7iNHarsz6d8PS5OtuteToS5msmS4kYg+9t2U5rnHsuUF9mKdMQcTX?=
 =?us-ascii?Q?69ojSjdDcCA93jD1Vzefc3k5rYsaws9wPAXX0Z1/f/8j4ZRr7veKjPWX7MlW?=
 =?us-ascii?Q?HPeSvyziCk8YMIbmlv2ShyLGbUNPAQ/ppFrVk/mUxfJmVZSu9ciRmq9C1/m2?=
 =?us-ascii?Q?/bjrzQJwa+TgJTEWqh2Cvz0CearuKP2zUFBOlqd1eaN257QZzvJwSILaQqS6?=
 =?us-ascii?Q?uAf1jFMgevWEGWvw1neqYHdwEWfERr7nS3L/GtWRnB8LZHx05YQ8OZKS0yhu?=
 =?us-ascii?Q?5/akVECKKSHQ0nbFIqe11xcmgzIPeZbMqux5kwwsXZww5p7NvdkadoP4adi8?=
 =?us-ascii?Q?WRsNINWgY9dqlTZIvZiexH/4UZyFUUzRxQe1FyVCPKsEe1LF0l+8+yIr2d1b?=
 =?us-ascii?Q?yN1+vaB/tvuXctcJrklUUeQjL1oxDXA/kdstBCVcgWHzLly8h6VlUsCeh+kP?=
 =?us-ascii?Q?fNgHUNt0Z5X5uVEPJvZ5pZdlLwK5o2T2Ny/AJt7zYbIj7XLYOfae7x4nZ0MM?=
 =?us-ascii?Q?6CIfl1Pqf5X1TFOc91u8emq7gnxP8TNZMQcaFMxbFCzHokp9eBXYFLpZS+d4?=
 =?us-ascii?Q?cCYNSSbe73c152iF8LgF2EYyWEXc3l/LSuy1TAtkgACcHxbMosCG6LL48273?=
 =?us-ascii?Q?hJw69DtWHAON0C683HuKXpk8ahM1HCRhTmo9LKLp3VuviE3Xg8DSmaOcPvOE?=
 =?us-ascii?Q?jFe7VxaY+Zn77NiFWmrQcQIapKrR82S1h/96ZAhGKI7kYmcgcOG6JuPanCbF?=
 =?us-ascii?Q?TwgUBeg9bPDKTxposay8yua64Q7Mt+sWlNPP5goqtLA862HLoSBDbJGoQjET?=
 =?us-ascii?Q?lxxwgIoprG5E0+ttwX9tlmeY5qoAWV12c1jJPFCGzOIRlMA7Mg0bi82EjXFo?=
 =?us-ascii?Q?IFr/3AGizDnU7jtmhOFyq3aUt+VKibRMunj1LHa24hqG8fVuovyliujSlGnh?=
 =?us-ascii?Q?ecmJiD3yNdN6P1NQjgI9yUv+8d1ZZ5zeJx1hzzGIszw4blK1enpY1kL2zUmZ?=
 =?us-ascii?Q?ajMvu9Ukf0ppVj/u0U4RpTYO0GIR76L8AOoB61ZQ5NRQRQP0J6u0u2+dkqQ0?=
 =?us-ascii?Q?Dc3442a2fwYSaMaZvVRziW6maV40/pBVOjhWDZE6rnWhIcqLnnFCSXhokPoW?=
 =?us-ascii?Q?h76M9K28W+v/rDIc2moqBzAFJ2DcLCBM09bLiXMwNkP7f3GnyCQ8uR0lfpq7?=
 =?us-ascii?Q?NgXdXuladzwq511gmoSgx2b9aoqzhVNTXi0w1G1txLErWHvlaf5ciq64VosE?=
 =?us-ascii?Q?dFdSYYL/wjLu7UnAhVu2Ao8lOyvZSzuO4w3lQ+aILork3QWRvxFFH0A0CH/H?=
 =?us-ascii?Q?TZQMM+y+/LWnvlbwvQRiQxMzLLmZot++iDQ+VK9DNLo/Jv88y4DNjaMCUTZF?=
 =?us-ascii?Q?xlMxHg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9d8d4a-3b0f-48c6-7077-08d9a00e5704
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 03:42:50.0835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: syRO6SVda+62YuMSfMEKm0J08CJ/hd293s51RFfySSAEmDmhYb5PzvUC/QnSpZZxwOzbmXYlgq1lWrv1sxScYKHqe67JS/p/sN3fhHW48ic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5675
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10158 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=586 suspectscore=0
 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111050018
X-Proofpoint-ORIG-GUID: TIv3ZWlyYkjtjcfljwrmdJREVenhacII
X-Proofpoint-GUID: TIv3ZWlyYkjtjcfljwrmdJREVenhacII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


George,

> If the size arg to kcalloc() is zero, it returns ZERO_SIZE_PTR.
> Because of that, for a following NULL pointer check to work on the
> returned pointer, kcalloc() must not be called with the size arg equal
> to zero. Return early without error before the kcalloc() call if size
> arg is zero.

Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering