Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 12:20:47 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Fontenot, Nathan" <Nathan.Fontenot@amd.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 06/21] cpufreq: amd: introduce a new amd pstate driver
 to support future processors
Message-ID: <YYSxH3PN70zeyNLX@hr-amd>
References: <20211029130241.1984459-1-ray.huang@amd.com>
 <20211029130241.1984459-7-ray.huang@amd.com>
 <012f60e6-af5a-5102-b35f-7b14ac9ad198@amd.com>
 <YYIzwuzoqXRscqif@hr-amd>
 <6e1831dc-9d7c-151c-ca83-594d249d6442@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6e1831dc-9d7c-151c-ca83-594d249d6442@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x6G7ynq054Pp0vHx1j698X80DCLq84JVLgR/Rz2QC5avkdxJ28R5daviHyQC?=
 =?us-ascii?Q?Fnn7RRjvQAIzI8nCHv5UBg9+XlZHbIh39HetDm1Ay8e8sWvb+VFeUxoFx095?=
 =?us-ascii?Q?/suz1aVP+yFuTMAPfThMNkjNgt4+RapWxeAM9UtwkzGa4NeTh67k9LI53FTJ?=
 =?us-ascii?Q?rsinTZ8dHSuIC/B5P2eysHix4OhAfr07f9FRI7ciizNT/EcVSk4dNpWyzmCc?=
 =?us-ascii?Q?9TCsB4rxUbbTQ60tCmWIasIJbCEaieWRQYi0NlNNK36L1untuCPtZ/BCRc4N?=
 =?us-ascii?Q?8UToLwCzCT0QdbozF3nbYOI8aibxwiFZj2moegXzkHrgtYJv+qzkDmYDh3/3?=
 =?us-ascii?Q?mHO78gt/hBor3WKItUEDlnF/Zg/E+dmEDk+kDqTWqcGgD1+mP2Z4mojYzIdI?=
 =?us-ascii?Q?j9IRMumSXl8bP+w4eUFZEpbXYqzls6AZfGA5H0QwElMCaO6LTm0/Pw4BeHvZ?=
 =?us-ascii?Q?hvcYf/f3DSz0+6M276eKs9j8lMuVHaTvPQUZd3Ukc7pzkSTQhqEEszvvmf0P?=
 =?us-ascii?Q?WpVc7liXe986MVttWLC1LJL6UtiyDK8ffgr1wZFlravCK0NLFV3rXkzYylTp?=
 =?us-ascii?Q?SbEVXMSOOlhlX4A734Dds6b/Z9vbs9kYHc5E3dpalGmLi31CLfazmWfl5tm4?=
 =?us-ascii?Q?ZT0WJNVQ3mEVFILjzHAOhSI6WN1f5WubyQATlb4CpB+jWW1KMA5/0cAvhgTV?=
 =?us-ascii?Q?Pg0GH6PqLz1ePEGYIqdUkDcyqRFIscOadcCKU4d2u6nOccwKqaBYzGXtgY18?=
 =?us-ascii?Q?qEfysWRWcD1Fs3HdyD//TmnXMWtTSNtbqkUFQjCWsKY6tBZShHgOIftJGGzC?=
 =?us-ascii?Q?hcPInnbIQeqXPolilNuIjOH5YNMmfBZNY0JYBrzDpXwLPbs7lDYRGOYcUE3k?=
 =?us-ascii?Q?3eHAx6k+2IT34BajvHNDFl23tNrz5LTU3wxY2EE1sRg9FWRqWHrB/4JEV7jF?=
 =?us-ascii?Q?QaLz7dnIMWKGlPB7qPltBmXsxee+OCr3qs+cOU+KEu1zWmahhsIRYdZ+LXjd?=
 =?us-ascii?Q?uoQ0SpUna/Gj8Fz5K32/m2tTIW9x4X7P4RoeaWq4iZx9YJ7A59EA545BOgmW?=
 =?us-ascii?Q?k9Jjm0p/n4F3w57E882qPzx1gSY2ebBDGO5Hu+Bu3gzma8eBtpZYX4lb01GL?=
 =?us-ascii?Q?LyJyOKew8NRuMoUvyPhtxZNVy7imqsOIogosp9NqpaK8SQATF4PEFRNxnlk4?=
 =?us-ascii?Q?cfwdl7QFjGJHqqAO4h2X/lWxe5pEg3W6sVM7dfZ5RmVweRTbaytWwGJV4rrC?=
 =?us-ascii?Q?Ja/vpTD0NXaDKqHMmfF8i9QmV/6HsuaysXvfLDP5pIvCvAYuaVAwwclcN+M0?=
 =?us-ascii?Q?gMJ03MZxpq0hbuElV+63R3A7RH6Jv5Z+xQtWt+9tOPxR646GhH0qFyhS6srL?=
 =?us-ascii?Q?52VGZttWqUErK4/Do9KoQw4LA/9GHZ5ADLOQooF6NT5k1UshdffAAXZqVQ2e?=
 =?us-ascii?Q?5s2SsdcuYSlOtGL2IdmenXLNnQ7xyAgcT2A2MNinzXE8zmLvfpWxP2azme/K?=
 =?us-ascii?Q?s8OWqWBAdV2TA7crijBD2YpNjMYBdueMEedKcOgMD8Tpx28qzTqz1si03icE?=
 =?us-ascii?Q?Cdb/B9gAecWXRQxm9VzZcBx84iv3wkhhYmYNPhdg73wQipn+JnXUWwWPKL73?=
 =?us-ascii?Q?6uFdgL64H7jSDMJGNvLBRUQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a51882e-50a1-4617-742a-08d9a013b32f
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0246.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 04:21:12.4428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mIpCUrvfUDOnWMuHP4vLYU5O3ogmztFyvajqZNLSf1hYcCeDuq3x8EPEifnWJnDq+nnotxTXogPuoHm3g7Nurg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1432
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 04, 2021 at 11:10:59PM +0800, Fontenot, Nathan wrote:
> On 11/3/21 2:01 AM, Huang Rui wrote:
> 
> >>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> >>> new file mode 100644
> >>> index 000000000000..a400861c7fdc
> >>> --- /dev/null
> >>> +++ b/drivers/cpufreq/amd-pstate.c
> >>> @@ -0,0 +1,413 @@
> >>> +/*
> >>> + * amd-pstate.c - AMD Processor P-state Frequency Driver
> >>> + *
> >>> + * Copyright (C) 2021 Advanced Micro Devices, Inc. All Rights Reserved.
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or
> >>> + * modify it under the terms of the GNU General Public License
> >>> + * as published by the Free Software Foundation; either version 2
> >>> + * of the License, or (at your option) any later version.
> >>> + *
> >>> + * This program is distributed in the hope that it will be useful,
> >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> >>> + * GNU General Public License for more details.
> >>> + *
> >>> + * You should have received a copy of the GNU General Public License along with
> >>> + * this program; if not, write to the Free Software
> >>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> >>
> >> You should use a SPDX license identifier instead of copying the GPL text
> >> in the file. See Documentation/process/license-rules.rst
> > 
> > The SPDX license identifier is an alternative way to instead of the common
> > way to express the license at the top comment of the file. Acutally it's
> > not mandatory, right?
> > 
> 
> It's not mandatory but I believe using SPDX identifiers is the preferred method.
> 

Yes, indeed, I will change this in V4.

> ...
> 
> >>> +static int __init amd_pstate_init(void)
> >>> +{
> >>> +	int ret;
> >>> +
> >>> +	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> >>> +		return -ENODEV;
> >>> +
> >>> +	if (!acpi_cpc_valid()) {
> >>> +		pr_debug("%s, the _CPC object is not present in SBIOS\n",
> >>> +			 __func__);
> >>
> >> Do we need to print the function name here (and below)?
> > 
> > It's a soft reminder to tell the user where the message comes from.
> >
> 
> True, but you do define pr_fmt at the top of the file so users will know
> this is coming from the amd_pstate driver.
> 

Hmm, yes, will clean this in V4.

Thanks,
Ray