Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2593015pxb; Fri, 5 Nov 2021 00:55:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfjzqolMPbpHIhH52WdDDPWkkjxFyDtj7Cn0z3EsvoqqC7ftdrezop78LNJcLmk+z7oLKI X-Received: by 2002:a50:e1c4:: with SMTP id m4mr75984706edl.307.1636098952408; Fri, 05 Nov 2021 00:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636098952; cv=none; d=google.com; s=arc-20160816; b=JR6/L7F+lKyEIeHDnULPKyI2wKEOEyq2b2yaatMqpxMov3OuZAqqSCv3yXv53pE6WM GPNu+UkLm8zzL3ZhRebqm7u4YhfsPY9G4x9eG93dNMjkN0R+Fwx9x2qj9JUstEvRwIMf pHRkoCPE6hUJ8xFJamzFh0fCK9XOX2bca03/ABU+6Q3zhjS6jkGLGHPNNI0pWvNKqr6f 8pEHby2FvZdXWh5RtCncg18f946gml3GHx4Bmdj5ZXKaiOvhUPrYT0J2wIc0TE2LI+g6 6t6sKVP+kaBCtMTvRtiZvSWXPZbFRvWcP+7IUR2x/5ngdPaRqxpfXBZVa4UcFOAQ4tMN hhKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+9e4iu7Il3mJH2p+xq10l16JnDP727LUXD/PNUmBJT0=; b=xn553vGiLE9nl96JyBb1u1cog28IRTeRa9ONyFUIlnD2kWeIUPsOnq7/62ujFovY1k IdkU4J+0BBPZC8017OKyK+wTgTGNzL88R9x8r9KQIqVgjU+QZMvZSQ357nSCqaU66Iiy 8Ny6rGNCeoDqmCQarCBX1yxwByQCRz6YcuM+xWMt0ESsmMm2TnD2NHUBL2wBgABLuixI CnsoC0H0KrMqa69b1dwyGphJ7aRxVZvpNSe5h6L6qAW89mas/CRtw5pJ8JgMVv/y0n41 PpTfXmQ5Ejwm4NOK/FrlFO9kdnCs23d6Y5+2ERnjKmIhTvx1SiaIY5XB/nzAWZZ6/eG2 b3uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fz1si14138524ejc.72.2021.11.05.00.55.28; Fri, 05 Nov 2021 00:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231856AbhKEGge (ORCPT + 99 others); Fri, 5 Nov 2021 02:36:34 -0400 Received: from mga17.intel.com ([192.55.52.151]:4603 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhKEGgd (ORCPT ); Fri, 5 Nov 2021 02:36:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="212598629" X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="212598629" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 23:33:54 -0700 X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="639630158" Received: from therrane-mobl.ger.corp.intel.com (HELO [10.249.32.113]) ([10.249.32.113]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 23:33:53 -0700 Subject: Re: [RFC 6/8] HID: usi: Add driver for Universal Stylus Interface (USI) To: Randy Dunlap , jikos@kernel.org, benjamin.tissoires@redhat.com, mika.westerberg@linux.intel.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211104133701.1733551-1-tero.kristo@linux.intel.com> <20211104133701.1733551-7-tero.kristo@linux.intel.com> <07757860-06bd-b47a-51ff-24cf31a7b28b@infradead.org> From: Tero Kristo Message-ID: <1c3bb031-c4dc-6525-95c0-c41c84b47ea5@linux.intel.com> Date: Fri, 5 Nov 2021 08:33:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <07757860-06bd-b47a-51ff-24cf31a7b28b@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2021 17:03, Randy Dunlap wrote: > On 11/4/21 6:36 AM, Tero Kristo wrote: >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >> index 3c33bf572d6d..c235ecb8f037 100644 >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -1222,6 +1222,11 @@ config HID_MCP2221 >>       To compile this driver as a module, choose M here: the module >>       will be called hid-mcp2221.ko. >>   +config HID_USI >> +    tristate "USI (Universal Stylus Interface) support" >> +    help >> +    Provides USI support over I2C HID interface. > > Indent help text "Provides ..." with 2 additional spaces, please, > per coding-style.rst. > Sorry yeah, this slipped through. Seems most of the drivers/hid/Kconfig is with wrong indentation, copied layout from there. I also need to add a bit more beef to this help text while updating it, and remove the mention of i2c only. -Tero