Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750710AbXAEVZT (ORCPT ); Fri, 5 Jan 2007 16:25:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750718AbXAEVZS (ORCPT ); Fri, 5 Jan 2007 16:25:18 -0500 Received: from gate.crashing.org ([63.228.1.57]:56879 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbXAEVZR (ORCPT ); Fri, 5 Jan 2007 16:25:17 -0500 Subject: Re: 2.6.20-rc3-mm1 From: Benjamin Herrenschmidt To: Andrew Morton Cc: Mariusz Kozlowski , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Cornelia Huck , Greg KH In-Reply-To: <20070105131516.bd9d8f45.akpm@osdl.org> References: <20070104220200.ae4e9a46.akpm@osdl.org> <200701051723.08112.m.kozlowski@tuxland.pl> <1168030536.22458.28.camel@localhost.localdomain> <20070105131516.bd9d8f45.akpm@osdl.org> Content-Type: text/plain Date: Sat, 06 Jan 2007 08:24:44 +1100 Message-Id: <1168032284.22458.33.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 37 On Fri, 2007-01-05 at 13:15 -0800, Andrew Morton wrote: > On Sat, 06 Jan 2007 07:55:36 +1100 > Benjamin Herrenschmidt wrote: > > > On Fri, 2007-01-05 at 17:23 +0100, Mariusz Kozlowski wrote: > > > Hello, > > > > > > Doesn't build on my iMac G3 based garage jukebox ;-) > > > > > > arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer > > > arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast > > > make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1 > > > make: *** [arch/powerpc/kernel] Blad 2 > > > > > > I guess someone who knows multithread code should take a look at it. > > > > Hrm. struct driver -> multithread_probe is gone in -mm ? > > > > yeah, it moved into struct bus_type. > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/broken-out/driver-core-per-subsystem-multithreaded-probing.patch Hrm. I disagree with this change. I have a few cases where drivers actually want to explicitely do that. I suppose they can always fire off a thread themselves from probe() but I don't see the reason to move it to the bus type... Easy enough for the bus type to force it if it wants. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/